New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625598 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Browser gets crashed after click on 'Add' button of site exception in chrome://md-settings.

Reported by rk...@etouch.net, Jul 4 2016

Issue description

Chrome Version:54.0.2787.0 (Official Build)229c5186fc07b397ec91db5f03367db2cf06f9a9-refs/heads/master@{#403602}
OS: Windows(7,8,10), Mac (10.10.5)(10.11.4), Linux(Ubuntu 14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://md-settings page.
(2) Click on Advanced and then click on 'Site settings'
(3) Click on All sites, click on Add site exception and type anything in field.
(4) Click on Add button and observe.

Actual: Browser gets crashed after click on Add button.
Crash ID fc09087b-6b6f-46a6-aa07-a3dda9ff7449 (Server ID: d5349af100000000)

Expected: Browser should never crash.

This is regression issue broken in ‘M 53’,below is narrow bisect:

Good build:53.0.2764.0
Bad build:54.0.2768.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/328468578fa1104659f135e0364f0a352dee6f1d..567e04a5b298f348278fec5d6783b327c3156847?pretty=fuller&n=100

Suspecting: r399145







 
Actual_Crash.mp4
851 KB View Download

Comment 1 by rk...@etouch.net, Jul 4 2016

Correction in Bad Build: 53.0.2766.0
Status: Started (was: Assigned)
Yup. Fix coming. Add Exception shouldn't appear on the All Sites list.
Labels: ReleaseBlock-Beta
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 4 Deleted

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29a171d38c0b053d35306560263073f8f7988ebc

commit 29a171d38c0b053d35306560263073f8f7988ebc
Author: finnur <finnur@chromium.org>
Date: Thu Jul 07 10:26:13 2016

Prevent Add Exception from showing on the All Sites list.

BUG= 625598 ,  543635 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2117033002
Cr-Commit-Position: refs/heads/master@{#404118}

[modify] https://crrev.com/29a171d38c0b053d35306560263073f8f7988ebc/chrome/browser/resources/settings/site_settings/site_list.html

Status: Fixed (was: Started)

Comment 7 by finnur@chromium.org, Jul 13 2016

Cc: raymes@chromium.org finnur@chromium.org bauerb@chromium.org jochen@chromium.org
 Issue 625682  has been merged into this issue.

Sign in to add a comment