New issue
Advanced search Search tips

Issue 625597 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task



Sign in to add a comment

Add more unit tests for Blink loader code

Project Member Reported by hirosh...@chromium.org, Jul 4 2016

Issue description

The classes of Blink's loader such as Resource/ResourceLoader/ResourceFetcher/MemoryCache have many corner cases that are not tested by unit tests (or by even any tests).
Adding more tests will help clarifying the assumption/behavior of the loader code as well as finding existing bugs and catching regressions.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c01b976a2461e60e1bb83cc85bb085fd9ce08819

commit c01b976a2461e60e1bb83cc85bb085fd9ce08819
Author: hiroshige <hiroshige@chromium.org>
Date: Mon Jul 04 11:34:20 2016

Add unit tests for revalidating ImageResource

BUG=625597,  618623 

Review-Url: https://codereview.chromium.org/2101103004
Cr-Commit-Position: refs/heads/master@{#403666}

[modify] https://crrev.com/c01b976a2461e60e1bb83cc85bb085fd9ce08819/third_party/WebKit/Source/core/fetch/ImageResourceTest.cpp

I'm working on TextResourceTest now.

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de7903c84701c01184c6ef2593c274f4d5de2bb0

commit de7903c84701c01184c6ef2593c274f4d5de2bb0
Author: hyungwook.lee <hyungwook.lee@navercorp.com>
Date: Wed Jul 27 02:55:22 2016

Add FragmentIdentifier(), MakeLiveAndDead(), RemoveURLFromCache() unit tests for MemoryCache.

BUG=625597
R=morrita@chromium.org

Review-Url: https://codereview.chromium.org/2140993002
Cr-Commit-Position: refs/heads/master@{#408026}

[modify] https://crrev.com/de7903c84701c01184c6ef2593c274f4d5de2bb0/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp

Project Member

Comment 4 by sheriffbot@chromium.org, Jul 27 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Available (was: Untriaged)
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 31

Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -hirosh...@chromium.org
Labels: -Type-Bug -Hotlist-Recharge-Cold Type-Task
Owner: hirosh...@chromium.org
Status: Assigned (was: Untriaged)
loading triage:
hiroshige-san, do you think we need more works for this bug?

Sign in to add a comment