New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625596 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Focus stays on 'Always do this' checkbox of translate bubble after tap/touch on 'Options' drop-down list.

Reported by jshan...@etouch.net, Jul 4 2016

Issue description

Chrome Version: 54.0.2787.0 (Official Build) 229c5186fc07b397ec91db5f03367db2cf06f9a9-refs/heads/master@{#403602}-32/64 bit
OS: Windows 10(Touch device)

Pre-condition: Enabled 'Translate 2016Q2 UI' flag from chrome://flags

Steps:
1. Launch chrome,navigate to http://www.bbc.com/hindi (Translation bubble appears)
2. Press tab key such that focus ring is on 'Always do this' checkbox.
3. Now tap/touch on 'Options' drop-down list and observe.

Actual: Unnecessary focus stays on 'Always do this' checkbox even after tap/touch on 'Options' drop-down list.

Expected: Focus should not stay on 'Always do this' checkbox after tap/touch on 'Options' drop-down list.

This is a non-regression issue seen from 'M-52', as this is a new feature introduced in 52.0.2728.0 

Note: This is touch device specific issue, same works fine via mouse click


 
Actual_result.jpg
109 KB View Download
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Windows. Changing the status to Untriaged so that the issue could get addressed.
Thank You.
Blocking: 608500
Owner: ftang@chromium.org
Labels: Proj-TabletChrome
Labels: Hotlist-Translate2016Q2UI
Status: Assigned (was: Untriaged)
Cc: reg@google.com

Comment 7 by ftang@google.com, Apr 15 2017

I cannot reproduce this on windows. Can anyone still be able to reproduce this?

Comment 8 by ftang@google.com, Apr 15 2017

ok, correction. If I mouse click, I cannot reproduce this. But if I TOUCH on the menu, I can reproduce this. However, this behavior is align with the bookmark bubble. when the bookmark bubble show up, the focus is on the Name field, if I TOUCH the folder menu, the drop down won't change the focus from the Name field. Should this bug be marked as invalid?
Owner: napper@chromium.org
Leaving this for after launch. Need to investigate whether this is a Translate bubble  issue or a wider bubble issue.
Blocking: -608500
Labels: Proj-TabletChrome-Phase1
RE #8: Two things:

The folder menu is discussed in  issue 699652  - and it is considered a bug.

I'm unable to reproduce under 57.0.2987.133 on Win10. The checkbox does not appear. Is there a flag I should be using, or am I missing something?
Labels: -Pri-2 Pri-3
Components: -UI>Browser>Translate UI>Browser>Language>Translate
Cc: -reg@google.com yyushkina@chromium.org
@girard@: sorry was not cc'ed on the bug so did not see your question. You should use the flag for 'Translate 2016Q2 UI' in chrome://flags.

Comment 15 by ftang@google.com, May 3 2017

I believe the issue is code inside src/ui/views/bubble/ or ui/views/focus/ does not handle the touch event correctly. you should owner of that two directories to look at this bug and 699652 instead.

Comment 16 by ftang@google.com, May 3 2017

or ui/views/touchui ask riajiang@chromium.org or sky@chromium.org

Comment 17 by sky@chromium.org, May 4 2017

Owner: est...@chromium.org
Combobox does not request focus in material-design. Evan can hopefully comment on why that decision was made.
Owner: yyushkina@chromium.org
That dialog isn't using material design, and that's not actually a combobox but a MenuButton.[1] Menu buttons don't take focus. That way of using a MenuButton is unique to the translate bubble and it's also the last use of LabelButton::SetStyle. In short, I hope it can just be removed.

[1] https://cs.chromium.org/chromium/src/chrome/browser/ui/views/translate/translate_bubble_view.cc?rcl=b14926c905396fbeb0a77bfc6cce569c8a35fa5f&l=623
I think in this case it makes sense to tackle this in conjunction with our existing plans to replace the drop down menu with another treatment.
Status: WontFix (was: Assigned)
Marking this as won't fix since we won't ship this UI

Sign in to add a comment