New issue
Advanced search Search tips

Issue 625594 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 625877
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

"git cl upload" fails on buildbot_unittest

Project Member Reported by mlamouri@chromium.org, Jul 4 2016

Issue description

Trying to call `git cl upload` gives the following error:
"""
** Presubmit ERRORS **
check-webkit-style failed
  Traceback (most recent call last):
  File "/usr/local/google/home/mlamouri/projects/google/chromium/src/third_party/WebKit/Tools/Scripts/check-webkit-style", line 44, in <module>
    from webkitpy.style.main import CheckWebKitStyle
  File "/usr/local/google/home/mlamouri/projects/google/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/style/main.py", line 27, in <module>
    import webkitpy.style.checker as checker
  File "/usr/local/google/home/mlamouri/projects/google/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/style/checker.py", line 44, in <module>
    from checkers.test_expectations import TestExpectationsChecker
  File "/usr/local/google/home/mlamouri/projects/google/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/test_expectations.py", line 34, in <module>
    from webkitpy.common.host import Host
  File "/usr/local/google/home/mlamouri/projects/google/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py", line 36, in <module>
    from webkitpy.common.net.buildbot import BuildBot
  File "/usr/local/google/home/mlamouri/projects/google/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py", line 5, in <module>
  File "/usr/local/google/home/mlamouri/projects/google/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 220, in <module>
  File "/usr/local/google/home/mlamouri/projects/google/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 222, in BuildBot
AttributeError: 'module' object has no attribute 'chromium_buildbot_url'
"""

I was able to bypass hooks and the patch seems to be on its way to land (chromium_presubmit is green).

I tried to revert a recent CL but it led to other errors. I would prefer to leave this to people who actually know what they are doing or have time to look into it :)
 
Sounds like the same issue as reported in https://codereview.chromium.org/2112133002.
Try deleting your local *.pyc files.
$ (cd third_party/WebKit/Tools/Scripts/webkitpy;find|grep pyc|xargs rm)
worked for me.
Mergedinto: 625877
Status: Duplicate (was: Assigned)
Components: Infra>Client>Chrome
Components: -Infra>Client>Blink

Sign in to add a comment