New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625585 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Regression: Scrollbar is misplaced in clear browsing data overlay when emulated to landscape direction in devtools.

Project Member Reported by bj00129...@techmahindra.com, Jul 4 2016

Issue description

Version: 54.0.2787.0 Dev
OS: Ubuntu 14.04, Windows

What steps will reproduce the problem?
(1)Launch chrome>>Navigate to chrome://md-settings>>Open devtools and click on toggle device toolbar icon.
(2)Select device iPhone 5 and click on rotate icon
(3)Now navigate to privacy and security section>>click on clear browsing data button and observe scrollbar in clear browsing data overlay (Please refer video)

Expected: Scrollbar should be properly placed in clear browsing data overlay.
Actual: Instead Scrollbar is misplaced.

This is a Regression issue broken in M-53.
Good Build:53.0.2748.0
Bad Build:53.0.2750.0

CHANGELOG URL:  https://chromium.googlesource.com/chromium/src/+log/ccd00a04a4523653ae3cf82550b9a1e52f99b91f..e9c93f8c46594e5437074d153222d2c48e754df6

Suspecting https://codereview.chromium.org/1974193002 from changelog.

@dbeam- Please help in reassigning if it is not related to your change.

Attaching screen cast for reference.
 
Actual_ScrollbarMisplaced-1.ogv
2.5 MB View Download
Expected_Scrollbar.ogv
1.8 MB View Download
Labels: OS-Mac
Able to reproduce the issue on Mac OS 10.11.5 using chrome latest Dev M54-54.0.2787.0. Observed the scroll bar is misplaced after clearing the browsing data.


Comment 2 Deleted

Comment 3 by dbeam@chromium.org, Jul 6 2016

Owner: ----
Status: Untriaged (was: Assigned)
Labels: Proj-MaterialDesign-WebUI Hotlist-Settings-Privacy-CBD
Labels: -Hotlist-Settings-Privacy-CBD Hotlist-MD-Settings-Privacy-CBD
Owner: msramek@chromium.org
Status: Assigned (was: Untriaged)
This seems to be working as intended in the latest Canary on Mac. If it's only a problem on mobile, I'm okay marking this WontFix.
Status: Started (was: Assigned)
Can reproduce. Specifying "overflow-y: scroll;" on the dialog body places the scrollbar correctly, I'll upload the patch shortly.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/564cf64fb5e60187511b316edf7b82e71b209e74

commit 564cf64fb5e60187511b316edf7b82e71b209e74
Author: msramek <msramek@chromium.org>
Date: Thu Jul 21 21:09:51 2016

Explicitly specify the vertical scrollbar in the MD settings CDB dialog

Otherwise, a misplaced scrollbar appears (presumably on some related element
from inside cr-dialog's shadow DOM).

On the way, also relax the condition for the "< 714px height" screens to
any media devices - there is no reason not to apply the same in print etc.

BUG= 625585 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2140613002
Cr-Commit-Position: refs/heads/master@{#406936}

[modify] https://crrev.com/564cf64fb5e60187511b316edf7b82e71b209e74/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html

Status: Fixed (was: Started)
This should be fixed now with the CL in #8.

Sign in to add a comment