New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625567 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MD-History]Focus highlight does not get shifted to iron icon while removing bookmark on clicking star icon.

Reported by dmascare...@etouch.net, Jul 4 2016

Issue description

Chrome Version:54.0.2787.0 (Official Build)229c5186fc07b397ec91db5f03367db2cf06f9a9-refs/heads/master@{#403602}
OS: Windows(7,8,10), Mac (10.10.5)(10.11.4), Linux(Ubuntu 14.04 LTS)

Pre-Condition: 1. Enable Material Design history flag.

What steps will reproduce the problem?
1.Launch chrome and navigate to any webpage and click on star icon to bookmark the page.
2.Navigate to chrome://history and click on star icon seen beside bookmarked url.
3.Observe.

Actual: Focus highlight does not get shifted to iron icon after step 2.
Expected: Focus highlight should get shifted to iron icon after step 2.

This is non-regression issue, seen from ‘M 54’ (54.0.2787.0)

@lshang- Please take a look

 
Actual.mov
2.1 MB Download
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Windows, Mac and Linux. Changing the status to Untriaged so that the issue could get addressed.
Thank You.
Owner: lshang@chromium.org
Status: Assigned (was: Untriaged)
Labels: Proj-MaterialDesign-WebUI
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3ec3feb3034ef9b28c320b27696094bbab654b3

commit b3ec3feb3034ef9b28c320b27696094bbab654b3
Author: lshang <lshang@chromium.org>
Date: Wed Jul 20 00:20:13 2016

MD History: Shift focus to overflow menu icon while removing bookmark

After clicking on the bookmark star to remove bookmark of an url, the focus
highlight is shifted to overflow menu icon which is on the right of the star.

BUG= 625567 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2141433003
Cr-Commit-Position: refs/heads/master@{#406426}

[modify] https://crrev.com/b3ec3feb3034ef9b28c320b27696094bbab654b3/chrome/browser/resources/md_history/history_item.js
[modify] https://crrev.com/b3ec3feb3034ef9b28c320b27696094bbab654b3/chrome/test/data/webui/md_history/history_item_test.js

Comment 5 by lshang@chromium.org, Jul 21 2016

Status: Fixed (was: Assigned)

Sign in to add a comment