New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 625565 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Jul 2016
Cc:
█ dfalcant...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

Show complete addresses on top. Limit addresses to top 4.

Project Member Reported by rouslan@chromium.org, Jul 4 2016 
...for shipping addresses in PaymentRequest UI.

Comment 1 by rouslan@chromium.org, Jul 7 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40dd55f9afba8922e99f8e773ce6fbb980f42196

commit 40dd55f9afba8922e99f8e773ce6fbb980f42196
Author: sebsg <sebsg@chromium.org>
Date: Wed Jul 13 21:41:50 2016

Suggest complete addresses and contact details first and limit to the top four suggestions.

BUG= 625565 
TEST=PaymentRequestDynamicShippingMultipleAddressesTest,
     PaymentRequestMultipleContactDetailTest

Review-Url: https://codereview.chromium.org/2120973002
Cr-Commit-Position: refs/heads/master@{#405302}

[modify] https://crrev.com/40dd55f9afba8922e99f8e773ce6fbb980f42196/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
[modify] https://crrev.com/40dd55f9afba8922e99f8e773ce6fbb980f42196/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java
[modify] https://crrev.com/40dd55f9afba8922e99f8e773ce6fbb980f42196/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[add] https://crrev.com/40dd55f9afba8922e99f8e773ce6fbb980f42196/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/Completable.java
[modify] https://crrev.com/40dd55f9afba8922e99f8e773ce6fbb980f42196/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java
[modify] https://crrev.com/40dd55f9afba8922e99f8e773ce6fbb980f42196/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/40dd55f9afba8922e99f8e773ce6fbb980f42196/chrome/android/java_sources.gni
[modify] https://crrev.com/40dd55f9afba8922e99f8e773ce6fbb980f42196/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[add] https://crrev.com/40dd55f9afba8922e99f8e773ce6fbb980f42196/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java
[add] https://crrev.com/40dd55f9afba8922e99f8e773ce6fbb980f42196/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultipleContactDetailsTest.java
[modify] https://crrev.com/40dd55f9afba8922e99f8e773ce6fbb980f42196/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Comment 3 by rouslan@chromium.org, Jul 15 2016

Labels: Merge-Request-53 M-53

Comment 4 by dimu@google.com, Jul 15 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 15 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/937d40d69aa608b89926bbd8869275bca6b7d555

commit 937d40d69aa608b89926bbd8869275bca6b7d555
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Fri Jul 15 16:44:36 2016

[Merge M-53] Suggest complete addresses and contact details first and limit to the top four suggestions.

BUG= 625565 
TEST=PaymentRequestDynamicShippingMultipleAddressesTest,
     PaymentRequestMultipleContactDetailTest

Review-Url: https://codereview.chromium.org/2120973002
Cr-Commit-Position: refs/heads/master@{#405302}
(cherry picked from commit 40dd55f9afba8922e99f8e773ce6fbb980f42196)

Review URL: https://codereview.chromium.org/2149263003 .

Cr-Commit-Position: refs/branch-heads/2785@{#154}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/937d40d69aa608b89926bbd8869275bca6b7d555/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java
[modify] https://crrev.com/937d40d69aa608b89926bbd8869275bca6b7d555/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillContact.java
[modify] https://crrev.com/937d40d69aa608b89926bbd8869275bca6b7d555/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[add] https://crrev.com/937d40d69aa608b89926bbd8869275bca6b7d555/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/Completable.java
[modify] https://crrev.com/937d40d69aa608b89926bbd8869275bca6b7d555/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentOption.java
[modify] https://crrev.com/937d40d69aa608b89926bbd8869275bca6b7d555/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java
[modify] https://crrev.com/937d40d69aa608b89926bbd8869275bca6b7d555/chrome/android/java_sources.gni
[modify] https://crrev.com/937d40d69aa608b89926bbd8869275bca6b7d555/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
[add] https://crrev.com/937d40d69aa608b89926bbd8869275bca6b7d555/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestDynamicShippingMultipleAddressesTest.java
[add] https://crrev.com/937d40d69aa608b89926bbd8869275bca6b7d555/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMultipleContactDetailsTest.java
[modify] https://crrev.com/937d40d69aa608b89926bbd8869275bca6b7d555/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java

Comment 6 by rouslan@chromium.org, Jul 15 2016

Status: Fixed (was: Started)

Comment 7 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment