Issue metadata
Sign in to add a comment
|
Regression:"video play back error" is displayed in play.google.com
Reported by
adha...@etouch.net,
Jul 4 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:54.0.2787.0 (Official Build) 229c5186fc07b397ec91db5f03367db2cf06f9a9-refs/heads/master@{#403602}(32/64-bit) OS:Windows 8 URL:https://play.google.com/store/movies?hl=en What steps will reproduce the problem? (1)Launch Chrome and navigate to above URL. (2)Play any video and forward it by moving the seek bar and observe.(kindly Refer the video) Actual:"video play back error" is displayed and video does not play. Expected:Video should play properly without any error. This is a Regression issue broken in M-53. Good build:53.0.2784.0 Bad build:53.0.2785.0 ChangeLog URL:(Providing Changelog as unable to play the video in Chromium build ) https://chromium.googlesource.com/chromium/src/+log/53.0.2784.0..53.0.2785.0?pretty=fuller&n=10000 Suspecting:r403334? Kindly help to re-assign if your change is not the cause for this issue. Note:This is a Windows8 specific issue,not seen on Mac,Linux and Windows 7,10.
,
Jul 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1e1331024f9e1fa5c633c0d29d6339c8e9fbe83 commit d1e1331024f9e1fa5c633c0d29d6339c8e9fbe83 Author: jbauman <jbauman@chromium.org> Date: Thu Jul 07 00:07:40 2016 Correctly handle reusing reset picture buffers. Pending output samples are marked as ready for reuse in DXVAVideoDecodeAccelerator::Reset. CopySurfaceComplete hasn't executed to acquire the keyed mutex, so it shouldn't be released. The incrementing of keyed_mutex_value_ also needs to be moved to someplace where it's certain that it will be executed even if CopySurfaceComplete is skipped. BUG= 625564 Review-Url: https://codereview.chromium.org/2128663003 Cr-Commit-Position: refs/heads/master@{#403997} [modify] https://crrev.com/d1e1331024f9e1fa5c633c0d29d6339c8e9fbe83/media/gpu/dxva_picture_buffer_win.cc [modify] https://crrev.com/d1e1331024f9e1fa5c633c0d29d6339c8e9fbe83/media/gpu/dxva_picture_buffer_win.h
,
Jul 7 2016
,
Jul 7 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34dae98bb2bcbd735d00d38c627478df4293aa8b commit 34dae98bb2bcbd735d00d38c627478df4293aa8b Author: John Bauman <jbauman@chromium.org> Date: Fri Jul 08 01:48:46 2016 Correctly handle reusing reset picture buffers. Pending output samples are marked as ready for reuse in DXVAVideoDecodeAccelerator::Reset. CopySurfaceComplete hasn't executed to acquire the keyed mutex, so it shouldn't be released. The incrementing of keyed_mutex_value_ also needs to be moved to someplace where it's certain that it will be executed even if CopySurfaceComplete is skipped. BUG= 625564 Review-Url: https://codereview.chromium.org/2128663003 Cr-Commit-Position: refs/heads/master@{#403997} (cherry picked from commit d1e1331024f9e1fa5c633c0d29d6339c8e9fbe83) Review URL: https://codereview.chromium.org/2135513002 . Cr-Commit-Position: refs/branch-heads/2785@{#52} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/34dae98bb2bcbd735d00d38c627478df4293aa8b/media/gpu/dxva_picture_buffer_win.cc [modify] https://crrev.com/34dae98bb2bcbd735d00d38c627478df4293aa8b/media/gpu/dxva_picture_buffer_win.h
,
Jul 9 2016
,
Jul 12 2016
Rechecked this on Windows 8.1 for chrome version 53.0.2785.14, fix is working as intended. No playback errors are displayed when seeking the videos manually. Adding TE-Verified labels. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Jul 4 2016