Remove uses of setTimeout in animations layout tests |
|||||
Issue descriptionSeveral of the tests in LayoutTests/animations call setTimeout. This seems to be leading to unreliability in the tests, and should be removed. If the call cannot be replaced with some other deterministic means, a comment should be added explaining why.
,
Sep 12 2016
Downgrading to quarterly as our OKRs are not pushing for this and this is not the only source of flakiness in animation tests.
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76c4b641970195a676ed7ae6e0d74860c7c5ea51 commit 76c4b641970195a676ed7ae6e0d74860c7c5ea51 Author: ericwilligers <ericwilligers@chromium.org> Date: Wed Oct 12 08:14:37 2016 CSS Animations: Reduce usage of setTimeout in Layout tests BUG=625562 Review-Url: https://codereview.chromium.org/2411163003 Cr-Commit-Position: refs/heads/master@{#424691} [modify] https://crrev.com/76c4b641970195a676ed7ae6e0d74860c7c5ea51/third_party/WebKit/LayoutTests/animations/animation-events-prefixed-01.html [modify] https://crrev.com/76c4b641970195a676ed7ae6e0d74860c7c5ea51/third_party/WebKit/LayoutTests/animations/animation-events-unprefixed-02.html [modify] https://crrev.com/76c4b641970195a676ed7ae6e0d74860c7c5ea51/third_party/WebKit/LayoutTests/animations/animation-events-unprefixed-03.html [modify] https://crrev.com/76c4b641970195a676ed7ae6e0d74860c7c5ea51/third_party/WebKit/LayoutTests/animations/animation-shorthand-name-order.html [modify] https://crrev.com/76c4b641970195a676ed7ae6e0d74860c7c5ea51/third_party/WebKit/LayoutTests/animations/change-keyframes-name.html [modify] https://crrev.com/76c4b641970195a676ed7ae6e0d74860c7c5ea51/third_party/WebKit/LayoutTests/animations/composited-with-hit-testing.html
,
Nov 2 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 2 2017
,
Sep 17
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by suzyh@chromium.org
, Jul 4 2016