New issue
Advanced search Search tips

Issue 625557 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 604282



Sign in to add a comment

Get rid of (IPC::ChannelHandle, mus::mojom::ChannelHandlePtr) type converter

Project Member Reported by dcheng@chromium.org, Jul 4 2016

Issue description

There's a bunch of DCHECK()s in the code, and it's not clear to me if these are to try to enforce internal invariants or if it's to try to catch bad states across process boundaries. Either way, this should be changed to use StructTraits.
 
Components: MUS
Labels: ReleaseBlock-Dev OS-All
Looks like if we start using IPC::ChannelHandle::mojo_handle in GPU, we will not need a ChannelHandle in mojom anymore. We could just pass a mojo handle around.
Blockedon: 604282
Any updates on this?  We're planning on promoting M54 to Dev next week so it should be fixed/resolved by then.
I don't believe this should be a release-blocker until the team starts shipping mus/mash in dev.

As for blocking dependency, it should be submitted soon (I _just_ got the lgtm). Once that's stuck for a few days, I think the type converter can be removed.

Comment 6 by dcheng@chromium.org, Jul 21 2016

Labels: -ReleaseBlock-Dev
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7280ca5addaf050ea058416990a3eb1a12aba5e

commit a7280ca5addaf050ea058416990a3eb1a12aba5e
Author: penghuang <penghuang@chromium.org>
Date: Thu Aug 18 15:20:04 2016

services/ui: Get rid of IPC::ChannelHandle type converter

BUG= 625557 

Review-Url: https://codereview.chromium.org/2247183005
Cr-Commit-Position: refs/heads/master@{#412832}

[modify] https://crrev.com/a7280ca5addaf050ea058416990a3eb1a12aba5e/services/ui/common/gpu_type_converters.cc
[modify] https://crrev.com/a7280ca5addaf050ea058416990a3eb1a12aba5e/services/ui/common/gpu_type_converters.h
[modify] https://crrev.com/a7280ca5addaf050ea058416990a3eb1a12aba5e/services/ui/common/gpu_type_converters_unittest.cc
[modify] https://crrev.com/a7280ca5addaf050ea058416990a3eb1a12aba5e/services/ui/gpu/gpu_service_impl.cc
[modify] https://crrev.com/a7280ca5addaf050ea058416990a3eb1a12aba5e/services/ui/gpu/gpu_service_mus.cc
[modify] https://crrev.com/a7280ca5addaf050ea058416990a3eb1a12aba5e/services/ui/gpu/gpu_service_mus.h
[modify] https://crrev.com/a7280ca5addaf050ea058416990a3eb1a12aba5e/services/ui/public/cpp/gpu_service.cc
[modify] https://crrev.com/a7280ca5addaf050ea058416990a3eb1a12aba5e/services/ui/public/cpp/gpu_service.h
[modify] https://crrev.com/a7280ca5addaf050ea058416990a3eb1a12aba5e/services/ui/public/interfaces/BUILD.gn
[delete] https://crrev.com/208cb0cd3a4126cca32286ee9afbb7597bf03e08/services/ui/public/interfaces/channel_handle.mojom
[modify] https://crrev.com/a7280ca5addaf050ea058416990a3eb1a12aba5e/services/ui/public/interfaces/gpu_service.mojom

Status: Fixed (was: Assigned)
Components: -MUS Internals>Services>WindowService

Sign in to add a comment