Issue metadata
Sign in to add a comment
|
Regression: First run bubble is not seen on opening New tab for freshly installed chrome.
Reported by
vvishwak...@etouch.net,
Jul 4 2016
|
||||||||||||||||||||||
Issue descriptionVersion: 54.0.2787.0 (Official Build) canary 229c5186fc07b397ec91db5f03367db2cf06f9a9-refs/heads/master@{#403602} (32/64-bit) OS: Windows (7,10) What steps will reproduce the problem? 1) Freshly install chrome and launch chrome. 2) Open a New tab and observe. First run bubble is not seen on opening New tab. First run bubble should be seen on opening New tab. This is a Regression issue broken in M-53, will soon update other info
,
Jul 4 2016
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Jul 5 2016
Is there a way to get a narrower bisect range for this? I'm pretty sure it's not my CL (my code doesn't run on Mac), but I looked through the revision list and I don't see an easy suspect. Does it repro on the next build of 53? Thanks.
,
Jul 5 2016
Er, the next build of 54?
,
Jul 5 2016
Oh, it's been broken since June 22nd. Never mind about the next build of 53/54. tommycli@ - could this be due to this CL? It's the only thing I see in the blame list that would touch both Win and Mac and possibly be related to startup. If not it's gotta be something like one of the WeakPtr or MessageLoop CLs. :-( Clean up LoginUIService. Remove Singleton behavior from PeopleHandler The old SyncSetupHandler used in Old Options should retain its Singleton behavior. BUG=563721 Committed: https://crrev.com/86fed6eaf1ec5922b03282b0e99d91c5b87ea1da Cr-Commit-Position: refs/heads/master@{#401357}
,
Jul 5 2016
Yeah, I double-checked and my code doesn't run on Windows either, just Chrome OS.
,
Jul 11 2016
tommycli@ - Since this issue is marked as RB-Stable will you mind checking it as per comment #5? If it's not related to your change please feel free to reassign it to the concerned Dev person . Thanks!
,
Jul 11 2016
I will check it. Sorry for the delay.
,
Jul 11 2016
I ran a git bisect, and the culprit is https://codereview.chromium.org/2054773002. This can be reproduced with Chromium Linux if you put the following in the out/rel/master_preferences file (or wherever your build directory is): { "distribution": { "skip_first_run_ui": false }, "first_run_tabs": [ "http://welcome_page", "http://new_tab_page" ] } Also, when verifying this bug, you must wait for the Welcome tab to finish loading. If you click "New Tab" before the Welcome tab finishes, the bug does not manifest. The fix will need to be merged to 53.
,
Jul 14 2016
,
Jul 15 2016
Most probably this is due to this bug crbug.com/627522 According to this https://cs.chromium.org/chromium/src/chrome/browser/first_run/first_run.cc?sq=package:chromium&dr=C&rcl=1468567049&l=436 The first run bubble is suppressed if a global error bubble is pending. A fix for crbug.com/627522 has landed. I will test it in the next Canary build on a Mac.
,
Jul 17 2016
I tested Canary version 54.0.2799.0 on Mac 10.11.5, and the issue is fixed there. The bubble showed as expected.
,
Jul 18 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vvishwak...@etouch.net
, Jul 4 2016Owner: jamescook@chromium.org
Status: Assigned (was: Unconfirmed)
868 KB
868 KB View Download
449 KB
449 KB View Download