MultibufferDataSource::GetSize returns incorrect value
Reported by
kosty...@yandex-team.ru,
Jul 4 2016
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.6 YaBrowser/16.9.0.790 Yowser/2.5 Safari/537.36 Example URL: http://html5player.ru/html5.mp4 Steps to reproduce the problem: 1. Start playing any media file (file size shouldn't be multiple of data source block size) 2. Ensure that WMPI is using MultibufferDataSource 3. Wait until load finished 4. Check MultibufferDataSource::GetSize value What is the expected behavior? MultibufferDataSource::GetSize returns correct file size What went wrong? MultibufferDataSource::GetSize counts last block twice Did this work before? Yes Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? Yes Chrome version: 52.0.2743.6 Channel: dev OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 22.0 r0 I was trying to fix it in cl https://codereview.chromium.org/2110853006/ But some of gpu_tests start failing, examples: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NV... https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A... https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release... Sadly, I can't reproduce this on my setup
,
Jul 6 2016
,
Jul 12 2016
,
Jul 12 2016
,
Jul 12 2016
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e50a4b489e2c06e368ee239911e8191b1a507e9 commit 6e50a4b489e2c06e368ee239911e8191b1a507e9 Author: hubbe <hubbe@chromium.org> Date: Wed Jul 13 19:55:10 2016 Fix MultibufferDataSource::GetSize When file loading is finished ResourceMultiBufferDataProvider count DataBuffer queue size twice, so GetSize returned incorrect value. BUG= 625515 , 627525 , 624853 patch from issue 2110853006 at patchset 1 (http://crrev.com/2110853006#ps1) Review-Url: https://codereview.chromium.org/2133803004 Cr-Commit-Position: refs/heads/master@{#405242} [modify] https://crrev.com/6e50a4b489e2c06e368ee239911e8191b1a507e9/media/blink/multibuffer_data_source_unittest.cc [modify] https://crrev.com/6e50a4b489e2c06e368ee239911e8191b1a507e9/media/blink/resource_multibuffer_data_provider.cc [modify] https://crrev.com/6e50a4b489e2c06e368ee239911e8191b1a507e9/media/blink/resource_multibuffer_data_provider.h
,
Jul 14 2016
,
Jul 18 2016
Merge? |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by liber...@chromium.org
, Jul 6 2016