Dark theme: Tree arrows on global search have bad contrast
Reported by
maurice....@gmail.com,
Jul 3 2016
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36 Steps to reproduce the problem: 1. Open devtools global find (cmd + opt + F) 2. search for 'div' 3. Observe tree arrows What is the expected behavior? The arrows should reflect the same color as the theme (greyish white in this case) What went wrong? Arrow colors reflect the light theme colors. Did this work before? No Chrome version: 51.0.2704.106 Channel: stable OS Version: OS X 10.11.5 Flash Version: Shockwave Flash 22.0 r0
,
Jul 4 2016
Could you please let us know which them you have applied, as when I applied dark themes I am seeing only Dev-tools with a white background (Regula Dev tools Window). Tried on MAC 10.11.5 on chrome version 51.0.2704.106. Screen Shot attached.
,
Jul 4 2016
I have the native dark theme applied on stable channel.
,
Jul 5 2016
Thank you for providing more feedback. Adding requester "ranjitkan@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 7 2016
,
Sep 12 2016
,
Sep 12 2016
It appears those triangles are using background-image (with fixed colors) rather than -webkit-mask-image (with changeable colors). This will need to be changed to support themes. The colors of the triangles should be #6e6e6e in light (default) mode and #919191 in dark mode (same as used by trees in the Elements and Sources panels).
,
Dec 1 2016
,
Dec 9 2016
It looks like this was fixed 3 months ago with this CL: https://chromium.googlesource.com/chromium/src/+/9e53b1921cdcfb0397ad769205f8be28eeb39a09 We use arrows in many places besides the search drawer, but after a manual search I couldn't find any bad contrast examples. Please let us know if you happen to discover more! Marking as fixed.
,
Jan 5 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by maurice....@gmail.com
, Jul 3 201612.3 KB
12.3 KB View Download