New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625468 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression


Participants' hotlists:
HSTS-Preload


Sign in to add a comment

1.5% regression in page_cycler.intl_ko_th_vi at 403040:403086

Project Member Reported by qyears...@chromium.org, Jul 3 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=625468

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgktbXsgoM


Bot(s) for this bug's original alert(s):

android-nexus6
Cc: lgar...@chromium.org
Owner: lgar...@chromium.org

=== Auto-CCing suspected CL author lgarron@chromium.org ===

Hi lgarron@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : HSTS preload updates for Chrome 53 (additions and changes).
Author  : Lucas Garron
Commit description:
  
TBR=palmer@chromium.org

Review URL: https://codereview.chromium.org/2008043003 .

Cr-Commit-Position: refs/heads/master@{#403072}
Commit  : 015eb655e3e422c718dbaa849b2272510140acb7
Date    : Thu Jun 30 02:27:13 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@403039  35546.2  67.2649  6  good
chromium@403063  35587.6  109.731  5  good
chromium@403069  35474.6  163.726  5  good
chromium@403071  35509.4  142.805  5  good
chromium@403072  36168.6  89.1308  5  bad    <--
chromium@403075  36110.2  128.229  5  bad
chromium@403086  36108.4  146.887  5  bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 625468

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.intl_ko_th_vi
Test Metric: vm_private_dirty_final_browser/vm_private_dirty_final_browser
Relative Change: 1.48%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2285
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9008185608627827984


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5860548143480832

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : HSTS preload updates for Chrome 53 (additions and changes).
Author  : Lucas Garron
Commit description:
  
TBR=palmer@chromium.org

Review URL: https://codereview.chromium.org/2008043003 .

Cr-Commit-Position: refs/heads/master@{#403072}
Commit  : 015eb655e3e422c718dbaa849b2272510140acb7
Date    : Thu Jun 30 02:27:13 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@403039  35570.2  160.985  6  good
chromium@403063  35578.6  211.437  5  good
chromium@403069  35578.4  144.875  5  good
chromium@403071  35551.2  194.672  5  good
chromium@403072  36117.4  113.597  5  bad    <--
chromium@403075  36034.8  102.458  5  bad
chromium@403086  36154.6  157.9    5  bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 625468

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests page_cycler.intl_ko_th_vi
Test Metric: vm_private_dirty_final_browser/vm_private_dirty_final_browser
Relative Change: 1.81%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2286
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9008140267656408512


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5798307356475392

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
lgarron@ - ping!
Hmm, a slight regression is not surprising (we're increasing the size of a static data structure slightly), but this change is actually significantly smaller than some other recent changes to it, due to some work to slow down the growth.

Unfortunately, there is nothing to do except double down on Issue 587954 (☂ HSTS Preload List: Address Growing Pains) and Hotlist-HSTS-Preload issues, so I'm afraid this is WontFix.

qyearsley@, could you possibly check if any other of the last dozen commits to net / http / transport_security_state_static.json [2] had similar regressions? If this regression is larger than the ones 4 or 5 months ago, something unusual is going on.

[1] https://bugs.chromium.org/p/chromium/issues/list?can=2&q=label%3AHotlist-HSTS-Preload+-label%3AHotlist-HSTS-Preload-Removals&sort=status&colspec=ID+Status+Owner+Summary+Modified&x=m&y=releaseblock&cells=ids
[2] https://chromium.googlesource.com/chromium/src/+log/015eb655e3e422c718dbaa849b2272510140acb7/net/http/transport_security_state_static.json
Labels: Hotlist-HSTS-Preload
Perf sheriff ping: reminder to follow up on possible performance issues
Status: WontFix (was: Assigned)
Marking wontfix per recommendation. 
Components: Internals>Network>DomainSecurityPolicy

Sign in to add a comment