New issue
Advanced search Search tips

Issue 625460 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 625434
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

29.3% regression in smoothness.sync_scroll.key_mobile_sites_smooth at 402894:402930

Project Member Reported by qyears...@chromium.org, Jul 3 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=625460

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgkvTbpQoM


Bot(s) for this bug's original alert(s):

android-galaxy-s5
Mergedinto: 625434
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Implement the new text-size-adjust CSS property
Author  : pdr
Commit description:
  
This patch adds a new CSS property for controlling text autosizing:
text-size-adjust (https://drafts.csswg.org/css-size-adjust).

Intent to implement and ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-vHFK4g93jA/JW9wAJyKAQAJ

At a high level, this patch adds a new CSS property and plumbs it to
storage on the rare inherited style data. The new datatype for this is
"TextSizeAdjust" which just wraps a float with logic for storing both
a floating point adjustment value, and whether 'auto' should be used.
The text autosizer itself has been modified to read this new property.

A few changes were needed to allow the text autosizer to use
multipliers less than 1 (see: TextAutosizer::computeAutosizedFontSize
and callers to that function).

The simple-paragraph.html layouttest has been switched to a unit test
to prove the unit test infrastructure works, and many new tests have
been added for the text-size-adjust feature.

BUG= 623158 

Review-Url: https://codereview.chromium.org/2100013002
Cr-Commit-Position: refs/heads/master@{#402916}
Commit  : 5365b8ad85c2f5cee6034b8baea3c764ed78e1ea
Date    : Wed Jun 29 20:09:42 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@402893  19.7086  1.53103  5  good
chromium@402912  20.9984  1.4426   5  good
chromium@402915  20.4882  1.04145  5  good
chromium@402916  28.0224  1.50123  5  bad    <--
chromium@402917  27.2496  1.17876  5  bad
chromium@402921  29.1928  2.87753  5  bad
chromium@402930  26.9562  1.68633  5  bad

Bisect job ran on: android_s5_perf_bisect
Bug ID: 625460

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests smoothness.sync_scroll.key_mobile_sites_smooth
Test Metric: mean_input_event_latency/Wordpress
Relative Change: 36.77%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/758
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9008186231102619392


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5773594785742848

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment