New issue
Advanced search Search tips

Issue 625451 link

Starred by 5 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

cvox commands don't work with all windows closed

Project Member Reported by chaok@google.com, Jul 3 2016

Issue description

Mode: force_next
Version: 53.0.2773.0
Reproduction Steps: 
1. https://groups.google.com/forum/#!topic/accessible/sQx5UE_BDko
2. It looks as if when all windows are closed, ChromeVox doesn't take
commands. After pressing ctrl+N CV is back.
3.


 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 3 2016

Labels: Hotlist-Google
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e451a40f0789251b6bebd1df69a00bc49dcac873

commit e451a40f0789251b6bebd1df69a00bc49dcac873
Author: dtseng <dtseng@chromium.org>
Date: Fri Jul 15 18:36:34 2016

Refactor: Extract a KeyboardHandler and CommandHandler from Background

Besides the mechanical changes needed, some simplification of the mode change logic was done. These changes should have no functional effects.

In addition, many commands that required a range in CommandHandler.onCommand were moved to the switch block not requiring a current range. This should be the only behavioral change introduced.

BUG= 625451 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2150623002
Cr-Commit-Position: refs/heads/master@{#405799}

[modify] https://crrev.com/e451a40f0789251b6bebd1df69a00bc49dcac873/chrome/browser/resources/chromeos/chromevox/chromevox.gni
[modify] https://crrev.com/e451a40f0789251b6bebd1df69a00bc49dcac873/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js
[modify] https://crrev.com/e451a40f0789251b6bebd1df69a00bc49dcac873/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
[add] https://crrev.com/e451a40f0789251b6bebd1df69a00bc49dcac873/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
[add] https://crrev.com/e451a40f0789251b6bebd1df69a00bc49dcac873/chrome/browser/resources/chromeos/chromevox/cvox2/background/keyboard_handler.js
[modify] https://crrev.com/e451a40f0789251b6bebd1df69a00bc49dcac873/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
[modify] https://crrev.com/e451a40f0789251b6bebd1df69a00bc49dcac873/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js
[modify] https://crrev.com/e451a40f0789251b6bebd1df69a00bc49dcac873/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js

Labels: Phase3
Owner: dtseng@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 4 by chaok@google.com, Sep 5 2016

Should this be marked fixed/verified? 
Status: fixed (was: Assigned)

Comment 6 by chaok@google.com, Sep 13 2016

Status: Verified (was: Fixed)

Sign in to add a comment