ReleaseBlock-Beta for end-user-reproducible crash.

I talked to elijahtaylor@ on the ARC team. We think it's a mistake that the icon is showing, so hiding it seems like the right solution.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/198e264eb577cab76a6cb13d1d8b4b5d0135cb3c

commit 198e264eb577cab76a6cb13d1d8b4b5d0135cb3c
Author: warx <warx@chromium.org>
Date: Wed Jul 06 21:21:28 2016

Hide web notification tray when LoginStatus is locked

BUG= 625357 
TEST=manual test: locked screen state will see web notification tray be hidden and shown when logged in

Review-Url: https://codereview.chromium.org/2120033002
Cr-Commit-Position: refs/heads/master@{#403955}

[modify] https://crrev.com/198e264eb577cab76a6cb13d1d8b4b5d0135cb3c/ash/common/system/web_notification/web_notification_tray.cc

Could you tell me a crash ID if you have?

Both desktop debug build and simple chrome release build are not showing crash ID. I put what I saw in review link comments.

Thanks, let me check and fix a root cause of the crash later.

Do I need to remove merge-request-53, or keep it right now?

Removed merge-request. We'll need to port the crash fix to M53.

You can probably get a call stack by running chrome (on desktop) inside gdb.

yoshiki, I presume you'll revert warx's change as part of your fix?

Here's a crash from me:

https://crash.corp.google.com/browse?q=reportid=%27300783f100000000%27

	0x00007fc9123dd121	(chrome -message_center_bubble.cc:109 )	message_center::MessageCenterBubble::InitializeContents
0x00007fc911be6e17	(chrome -web_notification_tray.cc:102 )	ash::WebNotificationTray::ShowMessageCenterInternal
0x00007fc9123d9815	(chrome -message_center_tray.cc:127 )	message_center::MessageCenterTray::ShowMessageCenterBubble
0x00007fc911be5bfc	(chrome -web_notification_tray.cc:392 )	ash::WebNotificationTray::PerformAction
0x00007fc91234d05f	(chrome -custom_button.cc:191 )	views::CustomButton::OnMouseReleased
0x00007fc9131e5496	(chrome -event_dispatcher.cc:191 )	ui::EventDispatcher::DispatchEvent
0x00007fc9131e5880	(chrome -event_dispatcher.cc:139 )	ui::EventDispatcher::ProcessEvent
0x00007fc9131e5966	(chrome -event_dispatcher.cc:86 )	ui::EventDispatcherDelegate::DispatchEventToTarget
0x00007fc9131e5a68	(chrome -event_dispatcher.cc:58 )	ui::EventDispatcherDelegate::DispatchEvent
0x00007fc912394bab	(chrome -root_view.cc:447 )	views::internal::RootView::OnMouseReleased
0x00007fc912399e98	(chrome -widget.cc:1208 )	views::Widget::OnMouseEvent
0x00007fc911bd52d1	(chrome -status_area_widget.cc:136 )	ash::StatusAreaWidget::OnMouseEvent
0x00007fc9131e5496	(chrome -event_dispatcher.cc:191 )	ui::EventDispatcher::DispatchEvent
0x00007fc9131e5880	(chrome -event_dispatcher.cc:139 )	ui::EventDispatcher::ProcessEvent
0x00007fc9131e5966	(chrome -event_dispatcher.cc:86 )	ui::EventDispatcherDelegate::DispatchEventToTarget
0x00007fc9131e5a68	(chrome -event_dispatcher.cc:58 )	ui::EventDispatcherDelegate::DispatchEvent
0x00007fc9131e6066	(chrome -event_processor.cc:35 )	ui::EventProcessor::OnEventFromSource
0x00007fc9131e62e2	(chrome -event_source.cc:73 )	ui::EventSource::DeliverEventToProcessor
0x00007fc9131e651d	(chrome -event_source.cc:51 )	ui::EventSource::SendEventToProcessor
0x00007fc911bb6c7e	(chrome -ash_window_tree_host_platform.cc:110 )	ash::AshWindowTreeHostPlatform::DispatchEvent
0x00007fc9131e88ff	(chrome -callback.h:397 )	ui::DispatchEventFromNativeUiEvent
0x00007fc9104423f5	(chrome -drm_window_host.cc:185 )	ui::DrmWindowHost::DispatchEvent
0x00007fc9100bd89c	(chrome -platform_event_source.cc:83 )	ui::PlatformEventSource::DispatchEvent
0x00007fc9131f9586	(chrome -event_factory_evdev.cc:318 )	ui::EventFactoryEvdev::DispatchMouseButtonEvent
0x00007fc90f0c2808	(chrome -callback.h:397 )	base::debug::TaskAnnotator::RunTask
0x00007fc90f0adb49	(chrome -message_loop.cc:493 )	base::MessageLoop::DoWork
0x00007fc90f0a5bd1	(chrome -message_pump_libevent.cc:217 )	base::MessagePumpLibevent::Run
0x00007fc90f9c3bf7	(chrome -run_loop.cc:35 )	base::RunLoop::Run

(By the way, it's possible that one of my refactor CLs caused this crash. I looked at them again and I didn't see anything obvious. Please let me know if I can help more.)

Found the suspect CL: http://crrev.com/2054473003
And create the fix: https://codereview.chromium.org/2124093003/

Let me revert the warx's CL just before landing the fix.

 Issue 625004  has been merged into this issue.

Just FYI; I think I caused this by adding notifications to ChromeVox (which is a component extension). 

 Issue 624876  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e65c8d661f1207d8fd4f08622d259dcb90510bca

commit e65c8d661f1207d8fd4f08622d259dcb90510bca
Author: yoshiki <yoshiki@chromium.org>
Date: Wed Jul 13 10:25:37 2016

Fix crash on clicking the web notification tray

This patch adds null-check for focusable view.

BUG= 625357 
TEST=crash doesn't happen

Review-Url: https://codereview.chromium.org/2124093003
Cr-Commit-Position: refs/heads/master@{#405112}

[modify] https://crrev.com/e65c8d661f1207d8fd4f08622d259dcb90510bca/ui/message_center/views/message_center_bubble.cc

Looks like this is superseded by the following? 

commit 198e264eb577cab76a6cb13d1d8b4b5d0135cb3c
Author: warx <warx@chromium.org>
Date:   Wed Jul 6 14:21:28 2016 -0700

    Hide web notification tray when LoginStatus is locked
    
    BUG= 625357 
    TEST=manual test: locked screen state will see web notification tray be hidden and shown when logged in
    
    Review-Url: https://codereview.chromium.org/2120033002
    Cr-Commit-Position: refs/heads/master@{#403955}

I think mine should be reverted on the trunk. Need confirmation from the author : )

Yes, let me revert it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f78cb96761fe87d72220e08744a5c203c7f5a26

commit 4f78cb96761fe87d72220e08744a5c203c7f5a26
Author: yoshiki <yoshiki@chromium.org>
Date: Wed Jul 13 19:52:46 2016

Revert "Hide web notification tray when LoginStatus is locked"

This reverts commit 198e264eb577cab76a6cb13d1d8b4b5d0135cb3c.

The root cause of the crash has been fixed and we don't need this patch now.

BUG= 625357 
TBR=warx@chromium.org

Review-Url: https://codereview.chromium.org/2151613002
Cr-Commit-Position: refs/heads/master@{#405239}

[modify] https://crrev.com/4f78cb96761fe87d72220e08744a5c203c7f5a26/ash/common/system/web_notification/web_notification_tray.cc

still reprod on ChromeOs:8530.20.0/Chrome:53.0.2785.15

 Issue 629247  has been merged into this issue.

yoshiki@, the fix is merged to 2795 in #16. For M53, should we merge this to 2785 instead?

Issue 628048 has been merged into this issue.

Change back to Fixed.
Requesting to merge https://codereview.chromium.org/2124093003 in #16 to M53.

Your change meets the bar and is auto-approved for M53 (branch: 2785)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5fdd54c49249534b7f5ade2ae462d30db30df38

commit d5fdd54c49249534b7f5ade2ae462d30db30df38
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Tue Jul 26 18:42:07 2016

Fix crash on clicking the web notification tray

This patch adds null-check for focusable view.

BUG= 625357 
TEST=crash doesn't happen

Review-Url: https://codereview.chromium.org/2124093003
Cr-Commit-Position: refs/heads/master@{#405112}
(cherry picked from commit e65c8d661f1207d8fd4f08622d259dcb90510bca)

Review URL: https://codereview.chromium.org/2188503002 .

Cr-Commit-Position: refs/branch-heads/2785@{#359}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/d5fdd54c49249534b7f5ade2ae462d30db30df38/ui/message_center/views/message_center_bubble.cc

Verified on 8530.35.0, 53.0.2785.36