New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 625354 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Jul 2016
Cc:
█ apaci...@chromium.org
sko...@chromium.org
█ jonnymack@chromium.org
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router] Route description seems too close to route details header

Project Member Reported by mfo...@chromium.org, Jul 2 2016 
Version: Version 52.0.2743.57 beta (64-bit)
Platform 8350.46.0 (Official Build) beta-channel samus
Firmware Google_Samus.6300.174.0
OS: Chrome

What steps will reproduce the problem?
(1) Cast netflix.com from another device
(2) Click into route details from the MR dialog for the device
(3) Observe attached dialog below

What is the expected output?

I would expect there to be more white space between the bottom of the route details header (blue background) and the top of the route description ("Netflix").  As is the text seems crowded against it.  I wonder if this is as intended vis-a-vis mocks/redlines.

I'm pretty sure this repros on platforms other than CrOS.
Screenshot 2016-07-01 at 17.54.55.png
13.7 KB View Download

Comment 1 by mfo...@chromium.org, Jul 2 2016 

There also seems to be some extra whitespace between the bottom of the media controls and the "Cast"/"Stop" buttons, but I don't feel certain that reducing it would make a big improvement.

Comment 2 by taku...@chromium.org, Jul 2 2016

Status: Assigned (was: Untriaged)

Comment 3 Deleted

Comment 4 by taku...@chromium.org, Jul 14 2016

Labels: -OS-Chrome OS-All
(Deleted comment 3 - forgot to attach images)
I agree that there's not enough margin at the top, but I think the margin at the bottom would look okay after we increase the top margin. I've made a mockup increasing the top margin from 8px to 15px. Does this look good?
mr_dialog_before.png
10.0 KB View Download
mr_dialog_after.png
10.0 KB View Download
mr_dialog_after_ver2.png
14.7 KB View Download

Comment 5 by mfo...@chromium.org, Jul 14 2016 

#2 looks pretty good to me.  If yhou haven't already, ping jonnymack@ our UX designer to get his thumbs-up on the change.

Comment 6 by taku...@chromium.org, Jul 18 2016

Status: Started (was: Assigned)

Comment 7 by taku...@chromium.org, Jul 20 2016

Status: Fixed (was: Started)
Fixed this by modifying the CSS for the extension view within the dialog (internal code: 127847499).
►

Sign in to add a comment