js_protcol.json and browser_protocol.json fails structural validation by a type checker
Reported by
noj...@gmail.com,
Jul 1 2016
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36 Steps to reproduce the problem: I am working on a project to autogenerate client and server(adapter) interfaces from protocol.json files. I wrote protocol.d.ts interface for the files. The typescript typechecker fails to validate the structure. They are minor issues with the hand edited json file What is the expected behavior? protocol.json files should be structurally consistent. The typechecker found bugs in the the json files What went wrong? I have created this bug to track the issue. I am sending a fix. Did this work before? N/A Chrome version: 51.0.2704.103 Channel: n/a OS Version: OS X 10.9.5 Flash Version: Shockwave Flash 22.0 r0
,
Jul 7 2016
Is the issue fixed? Assigning to pfeldman, since he reviewed the CL.
,
Jul 7 2016
I believe it is - nojvek has landed the patch.
,
Jul 8 2016
Pavel, It seems your merge commit after my patch introduced another structural regression. Basically "optional": "true" rather than "optional": true in GPUInfo Will send in another patch to fix it. https://chromium.googlesource.com/chromium/src/+/23f2c5c0aa550db9e4f51024bb412bcd8d770bd8%5E%21/#F7 Regards.
,
Jul 8 2016
Ouch. I'd expect to get a merge conflict for that. I'll fix it real quick.
,
Jul 8 2016
Ah, it was an error in a separate file, git is not to blame. I'll fix anyways.
,
Jul 8 2016
,
Jul 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f1958faeca7fab46f0974251e2d22b3b39ccfdb commit 9f1958faeca7fab46f0974251e2d22b3b39ccfdb Author: pfeldman <pfeldman@chromium.org> Date: Sat Jul 09 00:16:57 2016 DevTools: unquote 'true' in the protocol definition. BUG= 625341 TBR=dgozman Review-Url: https://codereview.chromium.org/2138463002 Cr-Commit-Position: refs/heads/master@{#404543} [modify] https://crrev.com/9f1958faeca7fab46f0974251e2d22b3b39ccfdb/third_party/WebKit/Source/core/inspector/browser_protocol.json
,
Aug 9 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jul 6 2016