New issue
Advanced search Search tips

Issue 625332 link

Starred by 3 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Oct 2016
Cc:
falken@chromium.org
dbeam@chromium.org
esprehn@chromium.org
michae...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocked on:
issue 632570
issue 632572
issue 632575
issue 632602
issue 632674
issue 633367
issue 633520
issue 633555


Sign in to add a comment

Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>

Project Member Reported by dpa...@chromium.org, Jul 1 2016 
Proof of concept was successful, see https://codereview.chromium.org/2059723003.

The benefits of this would be
1) Using native elements is better (lighter) than using Polymer elements.
2) Bugs related to PaperDialogBehavior will not be affecting cr-dialog users anymore. Concrete example of this, is https://bugs.chromium.org/p/chromium/issues/detail?id=62390.

One difference I noticed between the two dialog implementations is that the native dialog, focuses the first element in the dialog by default (unless autofocus is set on some other element). PaperDialogBehavior does not focus any element by default. This manifests with the 'x' button being focused (paper-ripple visible) right after opening the dialog (see screenshot). We should give meaningful autofocus elements to all our dialogs during the migration.
focus.png
69.0 KB View Download

Comment 1 by dpa...@chromium.org, Jul 1 2016

Summary: Migrate <cr-dialog> from PaperDialogBehavior to native <dialog> (was: Migrate cr-dialog from PaperDialogBehavior to native <dialog>)

Comment 2 by dpa...@chromium.org, Jul 1 2016

Cc: dbeam@chromium.org

Comment 3 by dbeam@chromium.org, Jul 1 2016

Cc: esprehn@chromium.org

Comment 4 by dbeam@chromium.org, Jul 1 2016

Cc: falken@chromium.org
yeah, right now it seems like the first focusable element is always focused:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/HTMLDialogElement.cpp?q=htmldialogelement&sq=package:chromium&dr=CSs&l=68

crazy hack: slap a <input autofocus hidden> at the top of the <dialog>[1]

note to falken@: the current implementation only checks whether something supportsAutoFocus(), but not if it isFocusable().  maybe we should fix?

[1] https://jsfiddle.net/dg16dwjj/9/

Comment 5 by falken@chromium.org, Jul 4 2016 

Yes, the spec is to focus the first focusable element:
https://html.spec.whatwg.org/multipage/forms.html#dialog-focusing-steps

> note to falken@: the current implementation only checks whether something supportsAutoFocus(), but not if it isFocusable().  maybe we should fix?

Yep, that sounds like a bug:
"Let control be the first non-inert focusable area in subject's control group whose DOM anchor has an autofocus attribute specified."

Comment 6 by dbeam@chromium.org, Jul 6 2016 

see also  issue 626041
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0df9bed02b720adb4c2be76dd8254b9ae3861906

commit 0df9bed02b720adb4c2be76dd8254b9ae3861906
Author: dpapad <dpapad@chromium.org>
Date: Fri Jul 08 00:30:27 2016

MD Settings: Reset page, fix dialog test that was erroneously passing.

The test that checks if a dialog can be closed in all possible ways ('x' button,
cancel button, escape key), was running the three sub-tests on the same dialog
instance in parallel. This caused all three sub-tests to pass, even though when
ran individually the 'escape' key test was failing.

Resolved by changing tests to not run in parallel, and fixing test code to
properly test closing using the 'Esc' key.

This bug was revealed while investigating migration to native <dialog>.

BUG= 625332 

Review-Url: https://codereview.chromium.org/2130023002
Cr-Commit-Position: refs/heads/master@{#404276}

[modify] https://crrev.com/0df9bed02b720adb4c2be76dd8254b9ae3861906/chrome/test/data/webui/settings/reset_page_test.js

Comment 8 by tbuck...@chromium.org, Jul 11 2016

Labels: Hotlist-MD-Settings-General OS-All
Status: Started (was: Untriaged)
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4af3d1625c8a80eface78c51d3a2811124f56d8

commit f4af3d1625c8a80eface78c51d3a2811124f56d8
Author: dpapad <dpapad@chromium.org>
Date: Tue Jul 19 19:17:28 2016

MD Settings: Bluetooth dialog, remove unnecessary 'close-dialog' event.

The interaction of blueetooth-device-dialog with its parent (bluetooth-page)
was more complex than necessary. Specifically summarizing the complexity
below
 - The dialog was firing a "close-dialog" event. In some of those occasions
   the dialog had already been closed by the time this event was fired (see
   BluetoothDeviceDialog#onIronOverlayClosed_).
 - Parent was catching the "close-dialog" event and was closing the
   dialog with the close() method (sometimes unnecessarily, since the dialog
   was already closed).
 - Parent was also additionally listening to the 'iron-overlay-closed'
   event.

It seems unnecessary to have the parent listen to two different events, one
to trigger the dialog closing, and one that fires after the dialog is closed.
Instead, the dialog can always close itself directly, and the parent can only
listen to the 'iron-overlay-closed' event.

This simplification is part of the effort to migrate <cr-dialog> to use
native <dialog>. Native <dialog> throws an error if close() is called while
it is already closed.

BUG= 625332 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2161753002
Cr-Commit-Position: refs/heads/master@{#406339}

[modify] https://crrev.com/f4af3d1625c8a80eface78c51d3a2811124f56d8/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
[modify] https://crrev.com/f4af3d1625c8a80eface78c51d3a2811124f56d8/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
[modify] https://crrev.com/f4af3d1625c8a80eface78c51d3a2811124f56d8/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/f4af3d1625c8a80eface78c51d3a2811124f56d8/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js

Comment 10 by dpa...@chromium.org, Jul 22 2016

Cc: michae...@chromium.org
Status update: The migration has been completed locally in two steps.
Specifically:

Step 1 https://codereview.chromium.org/2059723003:
 - Makes <cr-dialog> wrap a native <dialog>.
 - Preserves the API as much as possible.
 - Fixes all issues uncovered by the more strict behavior of open()/close(),
   as necessary for all tests to pass.

Step 2, https://codereview.chromium.org/2170213002:
 - Makes <cr-dialog> extend a <dialog> instead of wrapping one.
 - Updates all client code as necessary since the public API of
   <cr-dialog> is inevitably changed.
     - open() -> showModal()
     - opened -> open
     - <cr-dialog>...<cr-dialog> -> <dialog is="cr-dialog">..</dialog>

I am planning to send those CLs out very soon (probably tomorrow). During the
migration discovered the following issues,
 1) We are still using <paper-dialog> in internet_page/network_siminfo.html [1]
 2) [Blocking step2] Closure Compiler is crashing with an internal error when trying
    to run at step2 CL.

[1] https://cs.chromium.org/search/?q=paper-dialog+file:%5Esrc/chrome/browser/resources/settings/internet_page/&sq=package:chromium&type=cs
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644

commit 0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644
Author: dpapad <dpapad@chromium.org>
Date: Thu Jul 28 21:54:27 2016

Migrate <cr-dialog> from PaperDialogBehavior to native <dialog>.

 - Make <cr-dialog> extend a native <dialog> element.
 - Modify <cr-dialog> API as follows
   Events renamed:
     'iron-overlay-closed' -> 'close'
     'iron-overlay-canceled' -> 'cancel'
     'iron-overlay-opened' -> No equivalent event. Can be added if it
     turns out to be necessary.
   Method rename: 'open()' -> 'showModal()'
   Attribute rename: 'opened' -> 'open'

Also since HTMLDialogElement#showModal() and HTMLDialogElement#close()
are stricter than equivalent PaperDialogBehavior methods, the following
<cr-dialog> behavioral changes are caused by this migration.

 1) Calling showModal() when the element is not in the DOM throws exception.
 2) Calling showModal()/close() when dialog is already opened/closed throws
    exception.

BUG= 625332 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2180823004
Cr-Commit-Position: refs/heads/master@{#408495}

[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/md_history/list_container.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/md_history/list_container.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/about_page/channel_switcher_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/about_page/detailed_build_info.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/bluetooth_page/bluetooth_page.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/bluetooth_page/compiled_resources2.gyp
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/certificate_manager_page/ca_trust_edit_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/certificate_manager_page/certificate_delete_confirmation_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/certificate_manager_page/certificate_manager_page.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/certificate_manager_page/certificate_password_encryption_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/certificate_manager_page/certificates_error_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/certificate_manager_page/certificates_error_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/device_page/display_overscan_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/device_page/display_overscan_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/people_page/compiled_resources2.gyp
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/people_page/users_add_user_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/reset_page/powerwash_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/reset_page/reset_page.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/search_engines_page/search_engines_page.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/site_settings/site_data_details_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/test/data/webui/md_history/history_list_test.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/test/data/webui/settings/bluetooth_page_browsertest_chromeos.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/test/data/webui/settings/certificate_manager_page_test.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/test/data/webui/settings/device_page_tests.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/test/data/webui/settings/easy_unlock_browsertest_chromeos.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/test/data/webui/settings/fake_bluetooth.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/test/data/webui/settings/people_page_test.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/test/data/webui/settings/privacy_page_test.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/test/data/webui/settings/reset_page_test.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/test/data/webui/settings/settings_autofill_section_browsertest.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/chrome/test/data/webui/settings/startup_urls_page_test.js
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b19949388aaceb1d0dc2b48ad00b272dd1c72af5

commit b19949388aaceb1d0dc2b48ad00b272dd1c72af5
Author: dpapad <dpapad@chromium.org>
Date: Fri Jul 29 01:53:51 2016

Fix CrSettingsPrivacyPageTest.PrivacyPage test failure.

Also convert one more occurrence of iron-overlay-closed to close in site_settings/.

BUG= 625332 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2193073002
Cr-Commit-Position: refs/heads/master@{#408553}

[modify] https://crrev.com/b19949388aaceb1d0dc2b48ad00b272dd1c72af5/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/b19949388aaceb1d0dc2b48ad00b272dd1c72af5/chrome/browser/resources/settings/site_settings/site_data.js
[modify] https://crrev.com/b19949388aaceb1d0dc2b48ad00b272dd1c72af5/chrome/test/data/webui/settings/privacy_page_test.js

Comment 13 by dpa...@chromium.org, Jul 29 2016

Blockedon: 632570 632602 632572 632674
Adding regression bugs as dependencies, to keep track.

Comment 14 by dpa...@chromium.org, Jul 29 2016

Blockedon: 632575
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a33b37e0660858abe81a8bc60dddffe512e18109

commit a33b37e0660858abe81a8bc60dddffe512e18109
Author: dpapad <dpapad@chromium.org>
Date: Sat Jul 30 01:10:50 2016

MD Settings: Fix canceling of "Add site exception" dialog.

BUG= 625332 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2197723003
Cr-Commit-Position: refs/heads/master@{#408829}

[modify] https://crrev.com/a33b37e0660858abe81a8bc60dddffe512e18109/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/a33b37e0660858abe81a8bc60dddffe512e18109/chrome/browser/resources/settings/site_settings/add_site_dialog.js

Comment 16 by dpa...@chromium.org, Aug 1 2016

Blockedon: 633367

Comment 17 by dpa...@chromium.org, Aug 3 2016

Blockedon: 633555
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ae3d13515f1ca46261eda7264edd2e9293a8b80

commit 2ae3d13515f1ca46261eda7264edd2e9293a8b80
Author: stevenjb <stevenjb@chromium.org>
Date: Fri Aug 05 02:37:08 2016

MD Settings: Display: Fix overscan dialog for <dialog>

BUG= 625332 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2214343002
Cr-Commit-Position: refs/heads/master@{#409972}

[modify] https://crrev.com/2ae3d13515f1ca46261eda7264edd2e9293a8b80/chrome/browser/resources/settings/device_page/display_overscan_dialog.html

Comment 19 by dpa...@chromium.org, Aug 10 2016

Blockedon: 633520
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85a8d40a0c3182554e8915c1d088019210768fb9

commit 85a8d40a0c3182554e8915c1d088019210768fb9
Author: battre <battre@chromium.org>
Date: Wed Aug 31 09:45:33 2016

Disabled flaky CrSettingsPrivacyPageTest.PrivacyPage test

TBR=dpapad@chromium.org
BUG= 642574 , 625332 

Review-Url: https://codereview.chromium.org/2298113002
Cr-Commit-Position: refs/heads/master@{#415596}

[modify] https://crrev.com/85a8d40a0c3182554e8915c1d088019210768fb9/chrome/test/data/webui/settings/cr_settings_browsertest.js

Comment 21 by dpa...@chromium.org, Oct 24 2016

Status: Fixed (was: Started)
The last blocking bug ( crbug.com/633520 ) has been fixed, so marking this as fixed finally.
►

Sign in to add a comment