New issue
Advanced search Search tips

Issue 625320 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Settings: Assertion error when opening CBD dialog.

Project Member Reported by dpa...@chromium.org, Jul 1 2016

Issue description

Open CBD dialog, observe the console.

Uncaught Error: Assertion failed: Route not found: {"page":"basic","section":"","subpage":[],"dialog":"clear-browsing-data"}
 
Cc: tommycli@chromium.org

Comment 2 by dbeam@chromium.org, Jul 1 2016

Cc: -dbeam@chromium.org dpa...@chromium.org
Labels: Needs-Feedback
Owner: dbeam@chromium.org
Status: Started (was: Untriaged)
can you be more specific about how you opened CBD?  I just tried

1) chrome://settings/clearBrowserData
2) clicking "CLEAR BROWSER DATA" from chrome://settings/privacy
3) pressing back and forward after ever having shown CBD

and all worked for me (r403527 / 35a900e3ee8f2bf93654621eb24914c5eb07fd95)
1) Navigate to chrome://md-settings/
2) expand "Advanced" from the bottom of the page.
3) Click "Clear Browsing Data", boom.

Perhaps it only happens when you use chrome://md-settings instead of chrome://settings (see screenshot)?
error.png
125 KB View Download

Comment 4 by dbeam@chromium.org, Jul 1 2016

yeah, i was just trying to be too smart (and preserve scroll when showing the dialog).  our routing requires a certain page/section, which auto-scrolls to the privacy section in this case.  we'll have to do that for now.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4245543d64ef375474db34897fe5e6da62c0d4fe

commit 4245543d64ef375474db34897fe5e6da62c0d4fe
Author: dbeam <dbeam@chromium.org>
Date: Sat Jul 02 00:07:46 2016

MD Settings: fix clear browsing data dialog (again)

R=dpapad@chromium.org
BUG= 625320 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2116123002
Cr-Commit-Position: refs/heads/master@{#403571}

[modify] https://crrev.com/4245543d64ef375474db34897fe5e6da62c0d4fe/chrome/browser/resources/settings/privacy_page/privacy_page.js

Comment 6 by dbeam@chromium.org, Jul 6 2016

Status: Fixed (was: Started)

Sign in to add a comment