New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625312 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: 2019-07-09
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Let me sign into GAIA pages without adding an android account

Project Member Reported by danakj@chromium.org, Jul 1 2016

Issue description

This will probably never go upstream, but maybe I can use chrome again, cool.
 
My understanding: AccountReconcilor is the place that uses the "ubercookie" which gives us the system login basically, to merge system accounts into the chrome account list.

To make this work, something like..
- Add "whitelisted accounts" to account reconciler
 - It should be appended on-the-fly to the system accounts when checking whether
   the cookie contains the correct data.
 - See components/signin/core/browser/account_reconcilor.h
accounts.
- Add support for showing a web login
 - maybe see if something in components/signin/core/browser/signin_header_helper.h
   can help.
 - Somehow scrape the e-mail address and ensure that the web login calls
   /MergeSession. The Web login probably does this automatically.
- In the clank settings UI, add support for also showing the "whitelisted accounts".
 - The logout button will log out ALL accounts.
 - The call to logout should clear the whitelisted accounts from the account
   reconciler.
 - When logging in again, only the system accounts should be automatically logged
   in again by the account reconciler.

Thre reconciler has the system-accounts list and the "in-the-cookie" accounts, and tries to keep them in sync. Maybe add a third list "whitelisted" that is appended to the system-list before the reconciling. Except that you wouldn't be able to automatically reconcile later, so they would have to be "one-offs". Because to "reconcile" it'd need that uber token, which it gets from the android system.

Cc: nyquist@chromium.org
Maybe we could land this behind a flag? Then again, I guess flags aren't really meant as the way we want to maintain features... Maybe it in the end could evolve from behind-a-flag to behind-an-advanced-setting.
Well I found the place where the redirect happens, it's calls to signin::AppendMirrorRequestHeaderHelper, of which there are two in chrome_resource_dispatcher_host_delegate.cc: https://cs.chromium.org/search/?q=signin::AppendMirrorRequestHeaderHelper&sq=package:chromium&type=cs

If I don't do that, then I can log in normally.
Need to understand why im getting userdebug red borders when i use a clankium build tho.

Comment 5 by danakj@chromium.org, Aug 23 2016

I built and installed with the change described at 3 and was able to log into gaia sites without using mirror at all. But I was getting crashes which may or may not be related to the change, since I was building TOT and not using chrome-branding and stuff, I didn't try investigate more since then yet.

Comment 6 by danakj@chromium.org, May 10 2017

Status: Available (was: Assigned)

Comment 7 by danakj@chromium.org, May 10 2017

Cc: danakj@chromium.org
Owner: ----
Project Member

Comment 8 by sheriffbot@chromium.org, May 11 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 9 by danakj@chromium.org, May 11 2018

Status: Available (was: Untriaged)
Labels: Pri-3
NextAction: 2019-07-09
Downgrading P2s that haven't been modified in more than 6 months, which have no component or owner.
Status: Untriaged (was: Available)
Available, but no owner or component? Please find a component, as no one will ever find this without one.

Sign in to add a comment