Allow libcontainer to run containers as non root |
|||
Issue descriptionAllow libcontainer to run containers as non root
,
Jul 16 2016
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/268fa0354367c3c22a0536bfc86851801ff7bf5e commit 268fa0354367c3c22a0536bfc86851801ff7bf5e Author: Keshav Santhanam <ksanthanam@google.com> Date: Thu Jul 14 16:59:24 2016 libcontainer: Only configure device cgroup if root The CAP_SYS_ADMIN capability is needed to write to the device cgroup files, and CAP_MKNOD is required to call mknod. These capabilities are restricted to root, so this commit checks that the user is root before attempting to modify the device cgroup. BUG= chromium:625285 TEST=Run container as root and as non-root and verify that the device cgroup modification is skipped in the non-root case. Change-Id: Id3b227023a92c09b025a2b2397b4f70ce90b3098 Reviewed-on: https://chromium-review.googlesource.com/361595 Commit-Ready: Keshav Santhanam <ksanthanam@google.com> Tested-by: Keshav Santhanam <ksanthanam@google.com> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/268fa0354367c3c22a0536bfc86851801ff7bf5e/libcontainer/libcontainer.c
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/268fa0354367c3c22a0536bfc86851801ff7bf5e commit 268fa0354367c3c22a0536bfc86851801ff7bf5e Author: Keshav Santhanam <ksanthanam@google.com> Date: Thu Jul 14 16:59:24 2016 libcontainer: Only configure device cgroup if root The CAP_SYS_ADMIN capability is needed to write to the device cgroup files, and CAP_MKNOD is required to call mknod. These capabilities are restricted to root, so this commit checks that the user is root before attempting to modify the device cgroup. BUG= chromium:625285 TEST=Run container as root and as non-root and verify that the device cgroup modification is skipped in the non-root case. Change-Id: Id3b227023a92c09b025a2b2397b4f70ce90b3098 Reviewed-on: https://chromium-review.googlesource.com/361595 Commit-Ready: Keshav Santhanam <ksanthanam@google.com> Tested-by: Keshav Santhanam <ksanthanam@google.com> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/268fa0354367c3c22a0536bfc86851801ff7bf5e/libcontainer/libcontainer.c
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/268fa0354367c3c22a0536bfc86851801ff7bf5e commit 268fa0354367c3c22a0536bfc86851801ff7bf5e Author: Keshav Santhanam <ksanthanam@google.com> Date: Thu Jul 14 16:59:24 2016 libcontainer: Only configure device cgroup if root The CAP_SYS_ADMIN capability is needed to write to the device cgroup files, and CAP_MKNOD is required to call mknod. These capabilities are restricted to root, so this commit checks that the user is root before attempting to modify the device cgroup. BUG= chromium:625285 TEST=Run container as root and as non-root and verify that the device cgroup modification is skipped in the non-root case. Change-Id: Id3b227023a92c09b025a2b2397b4f70ce90b3098 Reviewed-on: https://chromium-review.googlesource.com/361595 Commit-Ready: Keshav Santhanam <ksanthanam@google.com> Tested-by: Keshav Santhanam <ksanthanam@google.com> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/268fa0354367c3c22a0536bfc86851801ff7bf5e/libcontainer/libcontainer.c
,
Aug 15 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 16 2016