New issue
Advanced search Search tips

Issue 625284 link

Starred by 2 users
Status: Fixed
Owner:
khushals...@chromium.org
Closed: Jul 2016
Cc:
danakj@chromium.org
vmp...@chromium.org
enne@chromium.org
dtrainor@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 625280



Sign in to add a comment

CC Layers Cleanup.

Project Member Reported by khushals...@chromium.org, Jul 1 2016 
To begin with, we need to clean up Layer, PictureLayer and SolidColorScrollbarLayer. These are what we support in the current Blimp implementation.

Start with cleaning up the header to clearly demarcate methods which are used by the embedder, methods which are public but used internally, for instance by the LayerTreeHost or PropertyTreeBuilder. Move data, callbacks and interfaces which come from the embedder and which are internal into separate structs.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b51998fe37830e22bd770de5f5ad08b663b465fd

commit b51998fe37830e22bd770de5f5ad08b663b465fd
Author: khushalsagar <khushalsagar@google.com>
Date: Fri Jul 08 01:04:21 2016

cc: Clean up Layer and the Layer public API.

To create a distinction between the Layer data that is received from
the embedder and values that are internally cached or set during
PropertyTree building, move the embedder data, callbacks and interfaces
into a seperate struct.

Also move public methods on Layer which are meant to be used internally
in cc but shouldn't be made available to the embedder to private and
restrict access using an explicit friend list.

The patch only moves the variables and method declarations and should
be a no-op.

BUG= 625284 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2128633002
Cr-Commit-Position: refs/heads/master@{#404286}

[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/BUILD.gn
[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/cc_tests.gyp
[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/layers/heads_up_display_layer.cc
[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/layers/layer.cc
[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/layers/layer.h
[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/layers/layer_unittest.cc
[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/layers/painted_scrollbar_layer.cc
[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/layers/texture_layer.cc
[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/layers/video_layer.cc
[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/test/fake_picture_layer.cc
[add] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/test/layer_internals_for_test.cc
[add] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/test/layer_internals_for_test.h
[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/b51998fe37830e22bd770de5f5ad08b663b465fd/cc/trees/tree_synchronizer_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42f5222403b9106ef7893beb08c5758af663200a

commit 42f5222403b9106ef7893beb08c5758af663200a
Author: mlliu <mlliu@chromium.org>
Date: Mon Jul 11 19:15:26 2016

cc: Clean up PictureLayer API.

To create a distinction between the PictureLayer data that is received
the embedder and values that are internally cached or set. Move the
embedder and interfaces into a separate struct.

BUG= 625284 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2131233003
Cr-Commit-Position: refs/heads/master@{#404705}

[modify] https://crrev.com/42f5222403b9106ef7893beb08c5758af663200a/cc/layers/picture_layer.cc
[modify] https://crrev.com/42f5222403b9106ef7893beb08c5758af663200a/cc/layers/picture_layer.h
[modify] https://crrev.com/42f5222403b9106ef7893beb08c5758af663200a/cc/layers/picture_layer_unittest.cc

Comment 4 by khushals...@chromium.org, Jul 30 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment