New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625282 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add "cronet_perf_test_apk" to "android_cronet_tester" builder

Project Member Reported by kapishnikov@chromium.org, Jul 1 2016

Issue description

"cronet_perf_test_apk" target should be run by "android_cronet_tester" builder to reduce the chance of CL rollbacks due to build errors.
 
Status: Available (was: Untriaged)
Adding the target should probably go in https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_android/chromium_config.py?rcl=0&l=88

  c.compile_py.default_targets=['cronet_package',
                                'cronet_sample_test_apk',
                                'cronet_test_instrumentation_apk',
                                'cronet_unittests',
                                'cronet_unittests_apk',
                                'net_unittests',
                                'net_unittests_apk',]

Owner: xunji...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/22a19f89867ce30a57f3543dca613621a46343f0

commit 22a19f89867ce30a57f3543dca613621a46343f0
Author: xunjieli <xunjieli@chromium.org>
Date: Wed Jul 13 16:37:30 2016

Add cronet_perf_test_apk to the list of compile targets for cronet

This CL adds cronet_perf_test_apk to the list of compile targets for cronet, so
it can be compiled on cronet continuous bots and trybot.

R=jbudorick@chromium.org

BUG= 625282 

Review-Url: https://codereview.chromium.org/2149663002

[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipe_modules/chromium_android/chromium_config.py
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipe_modules/cronet/example.expected/gn_test.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipe_modules/cronet/example.expected/local_test.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/android_cronet_arm64_builder__dbg_.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/android_cronet_armv6_builder.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/android_cronet_builder.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/android_cronet_data_reduction_proxy_builder.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/android_cronet_mips_builder.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/android_cronet_tester.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/android_cronet_x86_builder.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/android_cronet_x86_builder__dbg_.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/cronet_try.json
[modify] https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0/scripts/slave/recipes/cronet.expected/local_test.json

Status: Fixed (was: Started)
I was working on something related, so I thought I will put in a CL for this too.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13 2016

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/98f9d7f79daecba4a38cd0b5b8bb9a8128f96c28

commit 98f9d7f79daecba4a38cd0b5b8bb9a8128f96c28
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 13 16:56:50 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0 Add cronet_perf_test_apk to the list of compile targets for cronet (xunjieli@chromium.org)

R=jbudorick@chromium.org,xunjieli@chromium.org
BUG= 625282 

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2143073004

[modify] https://crrev.com/98f9d7f79daecba4a38cd0b5b8bb9a8128f96c28/infra/config/recipes.cfg

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40

commit bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 13 17:17:19 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0 Add cronet_perf_test_apk to the list of compile targets for cronet (xunjieli@chromium.org)
  https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3 recipes: Stop passing --build-tool=ninja to compile.py (thakis@chromium.org)
  https://crrev.com/853bfd83aba00955eccd0cf39eec2e14141384c7 recipes: Remove unused compile_py.solution and compile_py.xcode_project. (thakis@chromium.org)

R=jbudorick@chromium.org,thakis@chromium.org,xunjieli@chromium.org
BUG= 625282 ,none,622768

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2143943003

[modify] https://crrev.com/bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40/infra/config/recipes.cfg

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40

commit bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40
Author: recipe-roller <recipe-roller@chromium.org>
Date: Wed Jul 13 17:17:19 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/22a19f89867ce30a57f3543dca613621a46343f0 Add cronet_perf_test_apk to the list of compile targets for cronet (xunjieli@chromium.org)
  https://crrev.com/acfeec2bde1a7bef76690827dbfc46a9760d91d3 recipes: Stop passing --build-tool=ninja to compile.py (thakis@chromium.org)
  https://crrev.com/853bfd83aba00955eccd0cf39eec2e14141384c7 recipes: Remove unused compile_py.solution and compile_py.xcode_project. (thakis@chromium.org)

R=jbudorick@chromium.org,thakis@chromium.org,xunjieli@chromium.org
BUG= 625282 ,none,622768

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2143943003

[modify] https://crrev.com/bdf6acee3d9ded7d2efdce92eaaa6e19c0d1cf40/infra/config/recipes.cfg

Sign in to add a comment