New issue
Advanced search Search tips

Issue 625274 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.2% regression in angle_perftests/DrawCallPerf_gl_render_to_texture_null/score on chromium-rel-win7-gpu-nvidia at 403186:403233

Project Member Reported by jmad...@chromium.org, Jul 1 2016

Issue description

Performance dashboard identified a 7.2% regression in angle_perftests/DrawCallPerf_gl_render_to_texture_null/score on chromium-rel-win7-gpu-nvidia at revision range 403186:403233. Graph: https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-win7-gpu-nvidia&tests=angle_perftests%2FDrawCallPerf_gl_render_to_texture_null%2Fscore&checked=score%2Cscore_ref%2Cref&rev=403233

 
Cc: simonhatch@chromium.org
Perf sherrif: How do I link to the bisect job? Is it possible to make the bisect bot post an update when a job is triggered? (Also cc'ing Simon)
Blockedon: 625664
Blockedon: 622290
Spoke with Jamie directly, might as well copy on bug: When submitting jobs via chromeperf, there should be a popup that links you to the bisect job, unfortunately that isn't working properly ( crbug.com/622290 ). There's a bug id field on the job form, so that it can update the issue after it finishes the bisect.
I think it might make sense if the perf bisect job fails, to report that in the issue as well.

Comment 8 Deleted

Cc: -simonhatch@chromium.org jmad...@chromium.org
Owner: simonhatch@chromium.org
Simon, all of the bisect jobs are failing for the same reason, in extract build. Can you determine if there's an open issue for this, and create one if necessary?
Blockedon: 628215
I filed bug 628215 for this.
Perf sheriff ping
Blockedon: -622290 -628215 -625664
Blocking bugs now fixed.
Project Member

Comment 18 by 42576172...@developer.gserviceaccount.com, Oct 20 2016


===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision                          Mean    Std Dev  N  Good?
chromium@403185                   290077  1600.09  5  good
chromium@403191                   282642  2957.61  8  good
chromium@403191,angle@027cda6343  284460  7822.09  8  good
chromium@403191,angle@5733801abc  272344  3131.57  8  bad
chromium@403192                   271972  337.429  5  bad
chromium@403193                   270119  3297.51  5  bad
chromium@403194                   272233  556.015  5  bad
chromium@403197                   269570  4026.01  5  bad
chromium@403208                   270804  2072.56  5  bad
chromium@403233                   270773  1758.38  5  bad

Bisect job ran on: winx64nvidia_perf_bisect
Bug ID: 625274

Test Command: .\src\out\Release_x64\angle_perftests.exe --test-launcher-print-test-stdio=always --test-launcher-jobs=1
Test Metric: DrawCallPerf_gl_render_to_texture_null/score
Relative Change: 6.65%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1928
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8998335044518063712


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5808350523031552

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 19 by 42576172...@developer.gserviceaccount.com, Oct 20 2016


===== BISECT JOB RESULTS =====
Status: failed


===== TESTED REVISIONS =====
Revision                          Mean    Std Dev  N  Good?
chromium@403185                   289046  3418.38  5  good
chromium@403191                   291068  5610.91  8  good
chromium@403191,angle@027cda6343  288002  9981.38  8  good
chromium@403191,angle@5733801abc  275713  1739.99  8  bad
chromium@403192                   276530  265.295  5  bad
chromium@403193                   276080  1229.63  5  bad
chromium@403194                   275126  2126.53  5  bad
chromium@403197                   269058  12594.8  5  bad
chromium@403208                   274900  2151.09  5  bad
chromium@403233                   276053  1364.19  5  bad

Bisect job ran on: winx64nvidia_perf_bisect
Bug ID: 625274

Test Command: .\src\out\Release_x64\angle_perftests.exe --test-launcher-print-test-stdio=always --test-launcher-jobs=1
Test Metric: DrawCallPerf_gl_null/score
Relative Change: 4.50%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1927
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8998335049298589568


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5849652002291712

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Thanks for the update Quintin.. do you know what the failure for those try jobs means?
Project Member

Comment 22 by 42576172...@developer.gserviceaccount.com, Dec 17 2016

Cc: geoffl...@chromium.org
Owner: geoffl...@chromium.org

=== PERF REGRESSION ===


=== Auto-CCing suspected CL author geofflang@chromium.org ===

Hi geofflang@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : FramebufferD3D: Only make sure that enabled attachments are not the same.
Author  : Geoff Lang
Commit description:
  
It's acceptable to have the same object attached to muliple framebuffer
attachments if they are not being drawn to.

This was triggering failures in the conformance2/state/gl-object-get-calls.html
test.

BUG= 483282 

Change-Id: If088ccd9b1189f060dfa33ebbe4d82f1f47559b0
Reviewed-on: https://chromium-review.googlesource.com/354570
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Commit  : 4b7f12b2a79b9ebef8355725bae648032cdaed32
Date    : Tue Jun 28 15:29:02 2016


===== TESTED REVISIONS =====
Revision                          Mean    Std Dev  N  Good?
chromium@403185                   277334  4595.05  6  good
chromium@403191                   279304  7754.92  6  good
chromium@403191,angle@027cda6343  279152  14199.2  6  good
chromium@403191,angle@41db224555  284681  6751.57  6  good
chromium@403191,angle@4b7f12b2a7  265567  2309.55  6  bad    <--
chromium@403191,angle@82a468af33  265782  1124.72  6  bad
chromium@403191,angle@5733801abc  261036  10121.3  6  bad
chromium@403192                   262384  3295.64  6  bad
chromium@403193                   262560  1185.88  6  bad
chromium@403194                   262987  3777.89  6  bad
chromium@403197                   261410  4942.76  6  bad
chromium@403208                   262700  1628.75  6  bad
chromium@403233                   261343  9842.69  6  bad

Bisect job ran on: winx64nvidia_perf_bisect
Bug ID: 625274

Test Command: .\src\out\Release_x64\angle_perftests.exe --test-launcher-print-test-stdio=always --test-launcher-jobs=1
Test Metric: DrawCallPerf_gl_render_to_texture_null/score
Relative Change: 5.77%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64nvidia_perf_bisect/builds/1979
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8993074601826541168


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5209034884382720

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
geofflang: anhy update on this bug?
Status: Fixed (was: Assigned)
Whoops, this should be closed now.  The original change was required for correctness and this function is no longer a hotspot due to caching of framebuffer completeness.

Sign in to add a comment