New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 625271 link

Starred by 1 user
Status: Verified
Owner:
█ nxia@chromium.org
Last visit > 30 days ago
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Should use starting_build_id as the filter to get build history in cros_uprevchrome

Project Member Reported by nxia@chromium.org, Jul 1 2016 
A bug found in https://bugs.chromium.org/p/chromium/issues/detail?id=625249
 
cros_uprevchrome calls GetBuildHistory (with start_date as the filter) to get all the builds after the given pfq_build_id. Turns out start_date doesn't include the timestamp, but only the date. Using starting_build_id should be the right resolution.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/426443a3bc4477b3c6ba09601ff42f41ef71c637

commit 426443a3bc4477b3c6ba09601ff42f41ef71c637
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Jul 01 20:07:24 2016

Fix GetBuildHistory for cros_uprevchrome.

Add starting_build_id in GetBuildHistory for cros_uprevchrome tool.

BUG= chromium:625271 
TEST=manually run tool; unit_tests

Change-Id: I5e9cc693d4053122f3fcbc9bd44b0a3d3d0887e0
Reviewed-on: https://chromium-review.googlesource.com/358090
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/426443a3bc4477b3c6ba09601ff42f41ef71c637/cli/cros/cros_uprevchrome.py
[modify] https://crrev.com/426443a3bc4477b3c6ba09601ff42f41ef71c637/lib/cidb.py

Comment 2 by nxia@chromium.org, Jul 6 2016

Status: Fixed (was: Untriaged)

Comment 3 by abod...@chromium.org, Aug 12 2016

Status: Verified (was: Fixed)
Closing. please reopen if its not fixed.
►

Sign in to add a comment