New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625254 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 632780

Blocking:
issue 621599



Sign in to add a comment

Add functionality to update expectations files based on failures.

Project Member Reported by qyears...@chromium.org, Jul 1 2016

Issue description

After updating w3c tests, we want to wait until there are try job results, look at the failures on different platforms, and depending on the failures we then want to update TestExpectations or W3CImportExpectations.

This is required for  issue 625253 .
 
Blocking: 625253
Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56797ef5d98f8aaebe5c534ad760b4ad9befb194

commit 56797ef5d98f8aaebe5c534ad760b4ad9befb194
Author: dcampb <dcampb@google.com>
Date: Thu Jul 07 03:45:01 2016

Add get_issue_number function to webkitpy/common/checkout/scm/git.py

This CL adds a "git cl issue" function that returns the issue number if one is associated with a branch and "None" otherwise.

Also adds unit test located in webkitpy/common/checkout/scm/scm_unittest.py

BUG= 625254 

Review-Url: https://codereview.chromium.org/2129733002
Cr-Commit-Position: refs/heads/master@{#404065}

[modify] https://crrev.com/56797ef5d98f8aaebe5c534ad760b4ad9befb194/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py
[modify] https://crrev.com/56797ef5d98f8aaebe5c534ad760b4ad9befb194/third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py

Blocking: -625253
Blocking: 621599

Comment 5 by dcampb@google.com, Jul 8 2016

Blockedon: 626529
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0fd6054bf41efe4882888b877b438bc61e1e21c

commit f0fd6054bf41efe4882888b877b438bc61e1e21c
Author: dcampb <dcampb@google.com>
Date: Sat Jul 09 18:46:26 2016

Add "didnt_run_as_expected_results" to layouttestresults.py.

BUG= 625254 

Review-Url: https://codereview.chromium.org/2132193002
Cr-Commit-Position: refs/heads/master@{#404565}

[modify] https://crrev.com/f0fd6054bf41efe4882888b877b438bc61e1e21c/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jul 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2d465d888b64ea9053cd03ab2af8623dc05a4de

commit e2d465d888b64ea9053cd03ab2af8623dc05a4de
Author: dcampb <dcampb@google.com>
Date: Sat Jul 23 04:02:14 2016

Adds functionality to update-w3c-test-expectations

This cl adds functionality to the skip so that it skips adding
the failing test line if it already exists in TestExpectations.

BUG= 625254 

Review-Url: https://codereview.chromium.org/2174073002
Cr-Commit-Position: refs/heads/master@{#407349}

[modify] https://crrev.com/e2d465d888b64ea9053cd03ab2af8623dc05a4de/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py
[modify] https://crrev.com/e2d465d888b64ea9053cd03ab2af8623dc05a4de/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9756dcab651b7c31a1bc029d68800e71bc6dae16

commit 9756dcab651b7c31a1bc029d68800e71bc6dae16
Author: dcampb <dcampb@google.com>
Date: Mon Jul 25 00:48:12 2016

Change w3c-test-expectations file name

Fix the spelling error in the file name.
expection --> expectations.

BUG= 625254 

Review-Url: https://codereview.chromium.org/2176983002
Cr-Commit-Position: refs/heads/master@{#407394}

[rename] https://crrev.com/9756dcab651b7c31a1bc029d68800e71bc6dae16/third_party/WebKit/Tools/Scripts/update-w3c-test-expectations

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/201b0fae1eb4cbd645603683631fa3959faf74b9

commit 201b0fae1eb4cbd645603683631fa3959faf74b9
Author: dcampb <dcampb@google.com>
Date: Wed Jul 27 19:48:59 2016

Removes build and builder object references along with minor bug fixes

This CL:

1. Removes the uses of build and builder objects in main and get_failing_results_dict.

2. Returns a new dictionary with merged_keys in merge_same_valued_keys.

3. Adds more test failure types to get_expectations to return more accurate expectations.

4. Modifies create_line_list to only create a line if the test name starts with 'imported'.

5. Changes variable names in main.

6. Adds unit tests to cover multiple actual and expected results in get_expectations.

BUG= 625254 

Review-Url: https://codereview.chromium.org/2183913002
Cr-Commit-Position: refs/heads/master@{#408217}

[modify] https://crrev.com/201b0fae1eb4cbd645603683631fa3959faf74b9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py
[modify] https://crrev.com/201b0fae1eb4cbd645603683631fa3959faf74b9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py

Comment 11 by dcampb@google.com, Jul 29 2016

Blockedon: 632780

Comment 12 by dcampb@google.com, Aug 3 2016

Status: Started (was: Assigned)
Blockedon: -626529

Sign in to add a comment