Running:

$ cros uprevchrome --pfq-build 928659 --cred-dir ~/Work/prod_cidb_readonly -- bug chromium:625249  --draft

I got:

12:15:16: ERROR: cros uprevchrome failed before completing.
12:15:16: ERROR: pfq_build 928659 is invalid as build 927938 passed.

Which is confusing since 927938 < 928659 and 927938 was for  53.0.2784.3  whereas 928659 is for  53.0.2785.0 

+nxia@, +akeshet@

I'll take a look. 

cros_uprevchrome calls GetBuildHistory (with start_date as the filter) to get all the builds after the given pfq_build_id. Turns out start_date doesn't include the timestamp, but only the date.

Filed a bug at:
https://bugs.chromium.org/p/chromium/issues/detail?id=625271

Sent a fix CL:
https://chromium-review.googlesource.com/#/c/358090/


I used the fixed uprev tool and generated the uprev CLs, stevenjb@ want to take a look if the CLs are what you need? 

https://chromium-review.googlesource.com/#/c/358082/
https://chrome-internal-review.googlesource.com/#/c/268225/

nxia@ - Thanks! Those look good, I +2'd them and marked them Verified and CQ ready.

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-partner-overlay/+/56b81c1d06cf555685a54c1a92e2611870e007a9

commit 56b81c1d06cf555685a54c1a92e2611870e007a9
Author: Ningning Xia <nxia@google.com>
Date: Fri Jul 01 20:05:42 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-partner-overlay/+/56b81c1d06cf555685a54c1a92e2611870e007a9

commit 56b81c1d06cf555685a54c1a92e2611870e007a9
Author: Ningning Xia <nxia@google.com>
Date: Fri Jul 01 20:05:42 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-partner-overlay/+/56b81c1d06cf555685a54c1a92e2611870e007a9

commit 56b81c1d06cf555685a54c1a92e2611870e007a9
Author: Ningning Xia <nxia@google.com>
Date: Fri Jul 01 20:05:42 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9

commit 85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9
Author: Ningning Xia <nxia@google.com>
Date: Fri Jul 01 20:05:41 2016

Manual Uprev Chrome: generated by cros_uprevchrome based on build_id 928659, build_number 3082

Marking set of ebuilds as stable

x86-generic-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST

amd64-generic-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST

veyron_minnie-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST

daisy-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST

arm-generic-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST

arm-generic_freon-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST

amd64-LATEST_RELEASE_CHROME_BINHOST.conf: updating LATEST_RELEASE_CHROME_BINHOST

"Set {arch: afdo_file} pairs {'arm': 'chromeos-chrome-amd64-53.0.2785.0_rc-r1.afdo', 'x86': 'chromeos-chrome-amd64-53.0.2785.0_rc-r1.afdo', 'amd64': 'chromeos-chrome-amd64-53.0.2785.0_rc-r1.afdo'} and updated Manifest"

Marking latest_release for chromium-source ebuild with version 53.0.2785.0 as stable.

Marking latest_release for chromeos-chrome ebuild with version 53.0.2785.0 as stable.

BUG= chromium:625249 
TEST=None
CQ-DEPEND=*I6463182ed9fc8eedf2ca64e6e6d76e92a0ba7bf0

Change-Id: Ic8408441d32c75013522161f144d92f8a8b90edc
Reviewed-on: https://chromium-review.googlesource.com/358082
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9/chromeos-base/chromeos-chrome/Manifest
[modify] https://crrev.com/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9/chromeos/binhost/target/amd64-generic-LATEST_RELEASE_CHROME_BINHOST.conf
[modify] https://crrev.com/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9/chromeos/binhost/target/daisy-LATEST_RELEASE_CHROME_BINHOST.conf
[modify] https://crrev.com/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9/chromeos/binhost/target/arm-generic-LATEST_RELEASE_CHROME_BINHOST.conf
[rename] https://crrev.com/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9/chromeos-base/chromium-source/chromium-source-53.0.2785.0_rc-r1.ebuild
[modify] https://crrev.com/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9/chromeos/binhost/target/x86-generic-LATEST_RELEASE_CHROME_BINHOST.conf
[modify] https://crrev.com/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
[modify] https://crrev.com/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9/chromeos/binhost/target/arm-generic_freon-LATEST_RELEASE_CHROME_BINHOST.conf
[modify] https://crrev.com/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9/chromeos/binhost/target/veyron_minnie-LATEST_RELEASE_CHROME_BINHOST.conf
[rename] https://crrev.com/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9/chromeos-base/chromeos-chrome/chromeos-chrome-53.0.2785.0_rc-r1.ebuild
[modify] https://crrev.com/85c69a9c4ab8dc53acf76a888cd43c3ed74f58b9/chromeos/binhost/host/amd64-LATEST_RELEASE_CHROME_BINHOST.conf

Closing. please reopen if its not fixed.