MacViews: bubbles should always appear inside the work area |
|||
Issue descriptionVersion: 53.0.2785.0 OS: 10_11_5 What steps will reproduce the problem? (1) --enable-features=MacViewsNativeDialogs,MacViewsWebUIDialogs (2) Move the browser window so that the right edge is flush with the edge of the display (3) Click the bookmark star icon (4) The bookmark bubble opens partially of-screen What is the expected output? In Cocoa, it looks like the bubble tip is on the right side of the bubble, so that this is generally avoided. What do you see instead? In views, the bubble just appears centered with respect to the star decoration (no tip)/ Please use labels and text to provide additional information.
,
Aug 12 2016
Anchoring in Harmony is very specific - I don't think we should move things around depending on the work area. See Issue 600209
,
Sep 20 2016
Ooh, in fact there are already two methods: void BubbleFrameView::MirrorArrowIfOffScreen(..) void BubbleFrameView::OffsetArrowIfOffScreen(..) But I think the reason this regressed is that after r380411 the bubble type for the passwords bubble became "none" on MacViews, so mirroring/offsetting the arrow started doing nothing. Anyway Issue 600209 should resolve this, but the above methods may be useful in figuring out how to deal with the dichotomy of the Cocoa and toolkit-views omniboxes (which both should work on "mac", but the Cocoa omnibox isn't [yet?] fully flipped in RTL). |
|||
►
Sign in to add a comment |
|||
Comment 1 by tapted@chromium.org
, Jul 4 2016Labels: -Pri-3 M-54 Phase3 Pri-2
Summary: MacViews: bubbles should always appear inside the work area (was: MacViews bookmark bubble can open outside the screen bounds)