New issue
Advanced search Search tips

Issue 625247 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews: bubbles should always appear inside the work area

Project Member Reported by rsesek@chromium.org, Jul 1 2016

Issue description

Version: 53.0.2785.0
OS: 10_11_5

What steps will reproduce the problem?
(1) --enable-features=MacViewsNativeDialogs,MacViewsWebUIDialogs
(2) Move the browser window so that the right edge is flush with the edge of the display
(3) Click the bookmark star icon
(4) The bookmark bubble opens partially of-screen

What is the expected output?
In Cocoa, it looks like the bubble tip is on the right side of the bubble, so that this is generally avoided.

What do you see instead?
In views, the bubble just appears centered with respect to the star decoration (no tip)/


Please use labels and text to provide additional information.

 
Screen Shot 2016-07-01 at 3.08.54 PM.png
35.9 KB View Download
Cc: tapted@chromium.org ellyjo...@chromium.org
Labels: -Pri-3 M-54 Phase3 Pri-2
Summary: MacViews: bubbles should always appear inside the work area (was: MacViews bookmark bubble can open outside the screen bounds)
Yah - this regressed in r380411 (see  Issue 603394 ), which we're following up in  Issue 600209 .

Bookmark bubble can probably assume it opens to the left, and might even be intentionally skipping over the "ensure on screen" logic.

Some other bubbles should actually switch depending where the anchor is on screen. There's logic for moving the arrow/anchor around in toolkit-views already, but it might not be hooked up. One thing that comes to mind is the OIB - particularly in RTL locales where it opens to the left.

So there's probably two issues -  Issue 600209  for the bookmark bubble position, and the more general "bubbles should be contained in the work area regardless" issue.

Comment 2 by tapted@chromium.org, Aug 12 2016

Status: WontFix (was: Available)
Anchoring in Harmony is very specific - I don't think we should move things around depending on the work area.

See  Issue 600209 

Comment 3 by tapted@chromium.org, Sep 20 2016

Cc: eugene...@chromium.org
Ooh, in fact there are already two methods:

void BubbleFrameView::MirrorArrowIfOffScreen(..)
void BubbleFrameView::OffsetArrowIfOffScreen(..)

But I think the reason this regressed is that after r380411 the bubble type for the passwords bubble became "none" on MacViews, so mirroring/offsetting the arrow started doing nothing.

Anyway  Issue 600209  should resolve this, but the above methods may be useful in figuring out how to deal with the dichotomy of the Cocoa and toolkit-views omniboxes (which both should work on "mac", but the Cocoa omnibox isn't [yet?] fully flipped in RTL).

Sign in to add a comment