New issue
Advanced search Search tips

Issue 625242 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

metrics: report CL handling time breakdown to monarch

Project Member Reported by akes...@chromium.org, Jul 1 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/402b3bde37ab2762bd32e56e9ed5c32b70150157

commit 402b3bde37ab2762bd32e56e9ed5c32b70150157
Author: Aviv Keshet <akeshet@chromium.org>
Date: Fri Jul 01 04:18:01 2016

metrics: record CL handling time and false rejection stats in monarch

At the time of CL submission (either in CQ or pre-CQ), compute and
record the various handling time and rejection counts, and emit them to
monarch.

BUG= chromium:625242 
TEST=cidb_integration_test; unit tests modified to cover new code paths
for syntax; remote trybot of master-paladin and pre-cq-launcher

Change-Id: I41c1bd6d5a5676b6c8529069ec5066b4f3267b35
Reviewed-on: https://chromium-review.googlesource.com/357942
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/402b3bde37ab2762bd32e56e9ed5c32b70150157/lib/clactions_unittest.py
[modify] https://crrev.com/402b3bde37ab2762bd32e56e9ed5c32b70150157/lib/metrics.py
[modify] https://crrev.com/402b3bde37ab2762bd32e56e9ed5c32b70150157/lib/clactions.py
[modify] https://crrev.com/402b3bde37ab2762bd32e56e9ed5c32b70150157/lib/cidb.py
[modify] https://crrev.com/402b3bde37ab2762bd32e56e9ed5c32b70150157/cbuildbot/constants.py
[modify] https://crrev.com/402b3bde37ab2762bd32e56e9ed5c32b70150157/cbuildbot/stages/completion_stages.py
[modify] https://crrev.com/402b3bde37ab2762bd32e56e9ed5c32b70150157/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/402b3bde37ab2762bd32e56e9ed5c32b70150157/cbuildbot/stages/sync_stages.py
[modify] https://crrev.com/402b3bde37ab2762bd32e56e9ed5c32b70150157/lib/cidb_integration_test.py

I think this is working. Example query http://shortn/_43LxJs05sa
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Closing. please reopen if its not fixed.

Sign in to add a comment