ARC custom notification crash when closing as bubble |
|||||||
Issue description
1. Run an app that creates custom notification with proper priority that would be shown as a bubble (toast),
e.g. Podcast Addict
2. Close the bubble and crash.
It is because the notification surface is removed before bubble is closed.
Crash stack:
Program received signal SIGSEGV, Segmentation fault.
0x00007f3262099eed in Rect (size=..., this=<synthetic pointer>) at ../../ui/gfx/geometry/rect.h:41
41 constexpr explicit Rect(const Size& size) : size_(size) {}
(gdb) bt
#0 0x00007f3262099eed in Rect (size=..., this=<synthetic pointer>) at ../../ui/gfx/geometry/rect.h:41
#1 arc::ArcCustomNotificationView::Layout (this=0x3d0e7a73a200) at ../../ui/arc/notification/arc_custom_notification_view.cc:93
#2 0x00007f3261644df5 in views::View::PropagateVisibilityNotifications (this=0x3d0e7aa7ca80, start=0x3d0e79e56000, is_visible=false) at ../../ui/views/view.cc:1900
#3 0x00007f3261644df5 in views::View::PropagateVisibilityNotifications (this=0x3d0e79ea5798, start=0x3d0e79e56000, is_visible=false) at ../../ui/views/view.cc:1900
#4 0x00007f3261644df5 in views::View::PropagateVisibilityNotifications (this=0x3d0e79e56000, start=0x3d0e79e56000, is_visible=false) at ../../ui/views/view.cc:1900
#5 0x00007f326164f586 in views::Widget::OnNativeWidgetVisibilityChanged (this=0x3d0e79885780, visible=false) at ../../ui/views/widget/widget.cc:1052
#6 0x00007f326077c3ed in aura::Window::SetVisible (this=0x3d0e7a530840, visible=<optimized out>) at ../../ui/aura/window.cc:742
#7 0x00007f32616aaa85 in message_center::ToastContentsView::OnBoundsAnimationEndedOrCancelled (this=0x3d0e79ea5780, animation=<optimized out>)
,
Jul 2 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f093ef33a9fc0d9661204fc0255b9b0d8dca995 commit 4f093ef33a9fc0d9661204fc0255b9b0d8dca995 Author: xiyuan <xiyuan@chromium.org> Date: Tue Jul 05 16:50:11 2016 arc: Fix custom notification crash on closing Reset surface_ in ArcCustomNotificationView when the underlying ArcCustomNotificationItem is gone or the notification surface is removed. BUG= 625220 Review-Url: https://codereview.chromium.org/2120593002 Cr-Commit-Position: refs/heads/master@{#403796} [modify] https://crrev.com/4f093ef33a9fc0d9661204fc0255b9b0d8dca995/ui/arc/notification/arc_custom_notification_item.cc [modify] https://crrev.com/4f093ef33a9fc0d9661204fc0255b9b0d8dca995/ui/arc/notification/arc_custom_notification_item.h [modify] https://crrev.com/4f093ef33a9fc0d9661204fc0255b9b0d8dca995/ui/arc/notification/arc_custom_notification_view.cc [modify] https://crrev.com/4f093ef33a9fc0d9661204fc0255b9b0d8dca995/ui/arc/notification/arc_custom_notification_view.h
,
Jul 6 2016
Think we need this for M53 since it is a reproducible crash.
,
Jul 6 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7e631cde89ff25f738db2b4fbaf42e92b094b90 commit b7e631cde89ff25f738db2b4fbaf42e92b094b90 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed Jul 06 16:24:03 2016 Merge "arc: Fix custom notification crash on closing" > Reset surface_ in ArcCustomNotificationView when the underlying > ArcCustomNotificationItem is gone or the notification surface is > removed. > > BUG= 625220 > > Review-Url: https://codereview.chromium.org/2120593002 > Cr-Commit-Position: refs/heads/master@{#403796} > (cherry picked from commit 4f093ef33a9fc0d9661204fc0255b9b0d8dca995) Review URL: https://codereview.chromium.org/2123283002 . Cr-Commit-Position: refs/branch-heads/2785@{#29} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/b7e631cde89ff25f738db2b4fbaf42e92b094b90/ui/arc/notification/arc_custom_notification_item.cc [modify] https://crrev.com/b7e631cde89ff25f738db2b4fbaf42e92b094b90/ui/arc/notification/arc_custom_notification_item.h [modify] https://crrev.com/b7e631cde89ff25f738db2b4fbaf42e92b094b90/ui/arc/notification/arc_custom_notification_view.cc [modify] https://crrev.com/b7e631cde89ff25f738db2b4fbaf42e92b094b90/ui/arc/notification/arc_custom_notification_view.h
,
Jul 6 2016
,
Sep 27 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by xiy...@chromium.org
, Jul 1 2016