Issue metadata
Sign in to add a comment
|
Bookmarks bar text color goes white after exiting High Contrast mode
Reported by
sungmann...@navercorp.com,
Jul 1 2016
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.106 Safari/537.36 Steps to reproduce the problem: 1. Open "High contrast" settings panel. 2. Under "Choose a theme", select a high contrast theme from the drop-down menu, and then select "Apply". 3. Select "None" from the drop-down menu and then select "Apply" to turn off high contrast mode. What is the expected behavior? What went wrong? Bookmarks bar text color goes white. Did this work before? N/A Chrome version: 51.0.2704.106 Channel: stable OS Version: 10.0 Flash Version: Shockwave Flash 22.0 r0
,
Jul 2 2016
I'm working on it. https://codereview.chromium.org/2111323003
,
Jul 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea4e665db506d059c72cc51593888e5476eac4ac commit ea4e665db506d059c72cc51593888e5476eac4ac Author: sungmann.cho <sungmann.cho@navercorp.com> Date: Wed Jul 06 16:39:38 2016 Turn off the auto color readability of LabelButton in non-high contrast mode We turn on the auto color readability of LabelButton when entering into high contrast mode, and never turn it off even after exiting the mode. This leads to wrong colored text when switching from high contrast mode to non-high contrast mode. BUG= 625205 Review-Url: https://codereview.chromium.org/2111323003 Cr-Commit-Position: refs/heads/master@{#403917} [modify] https://crrev.com/ea4e665db506d059c72cc51593888e5476eac4ac/ui/views/controls/button/label_button.cc [modify] https://crrev.com/ea4e665db506d059c72cc51593888e5476eac4ac/ui/views/controls/button/label_button.h [modify] https://crrev.com/ea4e665db506d059c72cc51593888e5476eac4ac/ui/views/controls/button/label_button_unittest.cc
,
Jul 28 2016
,
Nov 2 2016
Looks like this was fixed; closing. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by b...@chromium.org
, Jul 1 2016