Flash component installer asserts on PathService::Override |
|||||
Issue descriptionbase.dll!base::debug::BreakDebugger() Line 21 C++ base.dll!logging::LogMessage::~LogMessage() Line 751 C++ base.dll!base::ThreadRestrictions::AssertIOAllowed() Line 45 C++ base.dll!base::PathExists(const base::FilePath & path) Line 243 C++ base.dll!base::PathService::OverrideAndCreateIfNeeded(int key, const base::FilePath & path, bool is_absolute, bool create) Line 247 C++ base.dll!base::PathService::Override(int key, const base::FilePath & path) Line 227 C++ chrome.dll!component_updater::`anonymous namespace'::FlashComponentInstallerTraits::ComponentReady(const base::Version & version, const base::FilePath & path, std::unique_ptr<base::DictionaryValue,std::default_delete<base::DictionaryValue> > manifest) Line 229 C++ > chrome.dll!component_updater::DefaultComponentInstaller::ComponentReady(std::unique_ptr<base::DictionaryValue,std::default_delete<base::DictionaryValue> > manifest) Line 364 C++ chrome.dll!component_updater::DefaultComponentInstaller::FinishRegistration(component_updater::ComponentUpdateService * cus, const base::Callback<void __cdecl(void),1> & callback) Line 356 C++ chrome.dll!base::internal::RunnableAdapter<void (__thiscall component_updater::DefaultComponentInstaller::*)(component_updater::ComponentUpdateService *,base::Callback<void __cdecl(void),1> const &)>::Run<scoped_refptr<component_updater::DefaultComponentInstaller> const &,component_updater::ComponentUpdateService * const &,base::Callback<void __cdecl(void),1> const &>(const scoped_refptr<component_updater::DefaultComponentInstaller> & receiver_ptr, component_updater::ComponentUpdateService * const & <args_0>, const base::Callback<void __cdecl(void),1> & <args_1>) Line 187 C++ chrome.dll!base::internal::InvokeHelper<0,void>::MakeItSo<base::internal::RunnableAdapter<void (__thiscall component_updater::DefaultComponentInstaller::*)(component_updater::ComponentUpdateService *,base::Callback<void __cdecl(void),1> const &)> const &,scoped_refptr<component_updater::DefaultComponentInstaller> const &,component_updater::ComponentUpdateService * const &,base::Callback<void __cdecl(void),1> const &>(const base::internal::RunnableAdapter<void (__thiscall component_updater::DefaultComponentInstaller::*)(component_updater::ComponentUpdateService *,base::Callback<void __cdecl(void),1> const &)> & runnable, const scoped_refptr<component_updater::DefaultComponentInstaller> & <args_0>, component_updater::ComponentUpdateService * const & <args_1>, const base::Callback<void __cdecl(void),1> & <args_2>) Line 313 C++ chrome.dll!base::internal::Invoker<base::internal::BindState<base::internal::RunnableAdapter<void (__thiscall component_updater::DefaultComponentInstaller::*)(component_updater::ComponentUpdateService *,base::Callback<void __cdecl(void),1> const &)>,component_updater::DefaultComponentInstaller * const,component_updater::ComponentUpdateService * &,base::Callback<void __cdecl(void),1> const &>,void __cdecl(void)>::RunImpl<base::internal::RunnableAdapter<void (__thiscall component_updater::DefaultComponentInstaller::*)(component_updater::ComponentUpdateService *,base::Callback<void __cdecl(void),1> const &)> const &,std::tuple<scoped_refptr<component_updater::DefaultComponentInstaller>,component_updater::ComponentUpdateService *,base::Callback<void __cdecl(void),1> > const &,0,1,2>(const base::internal::RunnableAdapter<void (__thiscall component_updater::DefaultComponentInstaller::*)(component_updater::ComponentUpdateService *,base::Callback<void __cdecl(void),1> const &)> & runnable, const std::tuple<scoped_refptr<component_updater::DefaultComponentInstaller>,component_updater::ComponentUpdateService *,base::Callback<void __cdecl(void),1> > & bound, base::IndexSequence<0,1,2> __formal) Line 379 C++ chrome.dll!base::internal::Invoker<base::internal::BindState<base::internal::RunnableAdapter<void (__thiscall component_updater::DefaultComponentInstaller::*)(component_updater::ComponentUpdateService *,base::Callback<void __cdecl(void),1> const &)>,component_updater::DefaultComponentInstaller * const,component_updater::ComponentUpdateService * &,base::Callback<void __cdecl(void),1> const &>,void __cdecl(void)>::Run(base::internal::BindStateBase * base) Line 358 C++ base.dll!base::Callback<void __cdecl(void),1>::Run() Line 389 C++ base.dll!base::`anonymous namespace'::PostTaskAndReplyRelay::RunReplyAndSelfDestruct() Line 61 C++ base.dll!base::internal::RunnableAdapter<void (__thiscall base::`anonymous namespace'::PostTaskAndReplyRelay::*)(void)>::Run<base::`anonymous namespace'::PostTaskAndReplyRelay *>(base::`anonymous-namespace'::PostTaskAndReplyRelay * && receiver_ptr) Line 187 C++ base.dll!base::internal::InvokeHelper<0,void>::MakeItSo<base::internal::RunnableAdapter<void (__thiscall base::`anonymous namespace'::PostTaskAndReplyRelay::*)(void)> const &,base::`anonymous namespace'::PostTaskAndReplyRelay *>(const base::internal::RunnableAdapter<void (__thiscall base::`anonymous namespace'::PostTaskAndReplyRelay::*)(void)> & runnable, base::`anonymous-namespace'::PostTaskAndReplyRelay * && <args_0>) Line 313 C++ base.dll!base::internal::Invoker<base::internal::BindState<base::internal::RunnableAdapter<void (__thiscall base::`anonymous namespace'::PostTaskAndReplyRelay::*)(void)>,base::internal::UnretainedWrapper<base::`anonymous namespace'::PostTaskAndReplyRelay> >,void __cdecl(void)>::RunImpl<base::internal::RunnableAdapter<void (__thiscall base::`anonymous namespace'::PostTaskAndReplyRelay::*)(void)> const &,std::tuple<base::internal::UnretainedWrapper<base::`anonymous namespace'::PostTaskAndReplyRelay> > const &,0>(const base::internal::RunnableAdapter<void (__thiscall base::`anonymous namespace'::PostTaskAndReplyRelay::*)(void)> & runnable, const std::tuple<base::internal::UnretainedWrapper<base::`anonymous namespace'::PostTaskAndReplyRelay> > & bound, base::IndexSequence<0> __formal) Line 379 C++ base.dll!base::internal::Invoker<base::internal::BindState<base::internal::RunnableAdapter<void (__thiscall base::`anonymous namespace'::PostTaskAndReplyRelay::*)(void)>,base::internal::UnretainedWrapper<base::`anonymous namespace'::PostTaskAndReplyRelay> >,void __cdecl(void)>::Run(base::internal::BindStateBase * base) Line 358 C++ base.dll!base::Callback<void __cdecl(void),1>::Run() Line 389 C++ base.dll!base::debug::TaskAnnotator::RunTask(const char * queue_function, const base::PendingTask & pending_task) Line 53 C++ base.dll!base::MessageLoop::RunTask(const base::PendingTask & pending_task) Line 494 C++ base.dll!base::MessageLoop::DeferOrRunPendingTask(const base::PendingTask & pending_task) Line 505 C++ base.dll!base::MessageLoop::DoWork() Line 624 C++ base.dll!base::MessagePumpForUI::DoRunLoop() Line 262 C++ base.dll!base::MessagePumpWin::Run(base::MessagePump::Delegate * delegate) Line 140 C++ base.dll!base::MessageLoop::RunHandler() Line 457 C++ base.dll!base::RunLoop::Run() Line 36 C++ chrome.dll!ChromeBrowserMainParts::MainMessageLoopRun(int * result_code) Line 1943 C++ content.dll!content::BrowserMainLoop::RunMainMessageLoopParts() Line 936 C++ content.dll!content::BrowserMainRunnerImpl::Run() Line 156 C++ content.dll!content::BrowserMain() Line 46 C++ content.dll!content::RunNamedProcessTypeMain() Line 418 C++ content.dll!content::ContentMainRunnerImpl::Run() Line 785 C++ content.dll!content::ContentMain() Line 20 C++ chrome.dll!ChromeMain(HINSTANCE__ * instance, sandbox::SandboxInterfaceInfo * sandbox_info) Line 84 C++ chrome.exe!MainDllLoader::Launch(HINSTANCE__ * instance) Line 185 C++ chrome.exe!wWinMain(HINSTANCE__ * instance, HINSTANCE__ * prev, wchar_t * __formal, int __formal) Line 262 C++ chrome.exe!invoke_main() Line 118 C++ chrome.exe!__scrt_common_main_seh() Line 255 C++ chrome.exe!__scrt_common_main() Line 300 C++ chrome.exe!wWinMainCRTStartup() Line 17 C++ kernel32.dll!@BaseThreadInitThunk@12 () Unknown ntdll.dll!___RtlUserThreadStart@8 () Unknown ntdll.dll!__RtlUserThreadStart@8 () Unknown
,
Jul 1 2016
,
Jul 6 2016
,
Jul 6 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 10 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e73cf3b133a9e41f2204311b70c6c20abf76bf9 commit 4e73cf3b133a9e41f2204311b70c6c20abf76bf9 Author: Joshua Pawlicki <waffles@google.com> Date: Mon Jul 11 16:11:01 2016 Fix Flash assert. Reland of https://codereview.chromium.org/2109873002/. BUG= 625201 Review-Url: https://codereview.chromium.org/2116723002 Cr-Commit-Position: refs/heads/master@{#403476} (cherry picked from commit 4d66c388052c2c22791e859e6918e779fa5e4732) Review URL: https://codereview.chromium.org/2138113002 . Cr-Commit-Position: refs/branch-heads/2785@{#82} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/4e73cf3b133a9e41f2204311b70c6c20abf76bf9/chrome/browser/component_updater/pepper_flash_component_installer.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jul 1 2016