New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625190 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Mac][MaterialDesign] Toolbar: The Home Button is too close to the Omnibox

Project Member Reported by meh...@chromium.org, Jul 1 2016

Issue description

Version: Chrome 53.0.2785.0 canary (64-bit)
OS: OSX 10.11.5

What steps will reproduce the problem?
(1) Go to chrome://settings
(2) Enable the Home Button
(3) Hover over it

What is the expected output? What do you see instead?
You will notice that the Home Button is too close to the Omnibox 

Please use labels and text to provide additional information.
Screenshots are attached.

This is also broken in Chrome 52 Beta.

 
 
actual.png
30.2 KB View Download
expected.png
30.4 KB View Download
Labels: Proj-MaterialDesign-NativeUI OS-Android
Labels: -OS-Android

Comment 3 by shrike@chromium.org, Jul 28 2016

Cc: bettes@chromium.org shrike@chromium.org sgabr...@chromium.org
 Issue 632159  has been merged into this issue.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1aa063a58ac043b5f4a8c6d7e9115e6ec2b8f05

commit b1aa063a58ac043b5f4a8c6d7e9115e6ec2b8f05
Author: shrike <shrike@chromium.org>
Date: Wed Aug 03 17:19:45 2016

[Mac][Material Design] Increase space between home button and Omnibox.

When the home button is visible in Material Design it's too close to
the Omnibox. This cl adds the proper spacing.

R=tapted@chromium.org
BUG= 625190 

Review-Url: https://codereview.chromium.org/2208593002
Cr-Commit-Position: refs/heads/master@{#409553}

[modify] https://crrev.com/b1aa063a58ac043b5f4a8c6d7e9115e6ec2b8f05/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment