64-bit release win component builds with clang are broken after https://codereview.chromium.org/2006923006 |
|||
Issue descriptionhttps://codereview.chromium.org/2006923006 https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dll%29/builds/6282 https://build.chromium.org/p/chromium.fyi/builders/CrWinClang64%28dll%29/builds/6282/steps/compile/logs/stdio [570/1699] LINK_EMBED(DLL) gpu.dll FAILED: gpu.dll gpu.dll.lib gpu.dll.pdb E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True gpu.dll "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /IMPLIB:gpu.dll.lib /DLL /OUT:gpu.dll @gpu.dll.rsp" 2 mt.exe rc.exe "obj\gpu\gpu.gpu.dll.intermediate.manifest" obj\gpu\gpu.gpu.dll.generated.manifest gpu.gles2_cmd_decoder.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl SkMatrix44::SkMatrix44(class SkMatrix44 const &)" (__imp_??0SkMatrix44@@QEAA@AEBV0@@Z) referenced in function "private: enum gpu::error::Error __cdecl gpu::gles2::GLES2DecoderImpl::HandleScheduleCALayerCHROMIUM(unsigned int,void const *)" (?HandleScheduleCALayerCHROMIUM@GLES2DecoderImpl@gles2@gpu@@AEAA?AW4Error@error@3@IPEBX@Z)
,
Jul 1 2016
I have a fix.
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/629e39e4149fd8dbe730bf27d7851d21969fff94 commit 629e39e4149fd8dbe730bf27d7851d21969fff94 Author: thakis <thakis@chromium.org> Date: Fri Jul 01 16:39:54 2016 Add a few missing &s. Without this, gfx::Transform is copied at calling sites, which requires its copy ctor, which requires SkMatrix44's copy ctor -- but we don't want everyone using this object having to have to depend on skia. BUG= 625175 Review-Url: https://codereview.chromium.org/2117813002 Cr-Commit-Position: refs/heads/master@{#403468} [modify] https://crrev.com/629e39e4149fd8dbe730bf27d7851d21969fff94/ui/gl/ca_renderer_layer_params.cc [modify] https://crrev.com/629e39e4149fd8dbe730bf27d7851d21969fff94/ui/gl/ca_renderer_layer_params.h
,
Jul 1 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by h...@chromium.org
, Jul 1 2016