New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625169 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit 15 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MemoryInfra: heap profiler should self-symbolize on chrome desktop

Project Member Reported by primiano@chromium.org, Jul 1 2016

Issue description

Background context:go/memory-infra: memory profiling in chrome://tracing

On Linux Desktop at least we shouldn't require the symbolize_trace script. We should be able to symbolize at trace generation time (when we fill the stacktrace dictionary) by self-inspecting the binary. ... unless folk use debug fission, in which case we should just say : run this script.
 
Components: Platform>DevTools>Memory

Comment 2 by l...@chromium.org, Aug 15 2016

Cc: alph@chromium.org

Comment 3 by l...@chromium.org, Aug 19 2016

Owner: alph@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by dskiba@chromium.org, Aug 19 2016

I'm curious what is your plan here? Note that there are several issues with this:

1. Typical Linux trace has several thousand addresses from Chrome and couple of hundreds from other libraries (which we also need to symbolize).

2. We have plans to do some post-processing in the symbolization script, e.g. assign proper categories to allocations - that won't be possible to do from the Chrome itself. So this features should be disable-able.

Comment 5 by ssid@chromium.org, Aug 19 2016

I think we are waiting for the TracingV2 format and changing the format of the memory dump to have all allocations. Only then the symbolization script which will assign categories will work. When we have such a format, it is also possible to symbolize inside chrome and post process just to see categories if needed. I do not get why this should be disable-able.

Comment 6 by dskiba@chromium.org, Aug 19 2016

We need paths for proper categorization, i.e. we need to do proper symbolization using dwarf info, and not just resolve address to function name (which StackTrace does). That is going to be hard (dwarf reading stuff from breakpad might not even be compiled in by default) and slow (compared to running several addr2line instances in parallel in the script).

Overall, runtime symbolization is limited (desktop builds only), and just duplicates code that we already have in the symbolization script.

Maybe instead tracing UI should just invoke symbolization script after getting the trace file?

Comment 7 by alph@chromium.org, Aug 19 2016

Owner: dskiba@chromium.org
I believe Dmitry is a better owner of this. ;-)

Comment 8 by alph@chromium.org, Aug 19 2016

Components: -Platform>DevTools>Memory Internals>Tracing
Components: Internals>Instrumentation>Memory
Components: -Internals>Tracing
Status: WontFix (was: Assigned)
Chrome switched to memlog, and erikchen@ et al. is working on that now.

Sign in to add a comment