New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 625161 link

Starred by 1 user
Status: Verified
Owner:
treib@chromium.org
Closed: Jul 2016
Cc:
█ sfiera@chromium.org
treib@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 611341



Sign in to add a comment

Remove "provider ID" from NewTabPage histograms

Project Member Reported by treib@chromium.org, Jul 1 2016 
A number of NTP histograms are split by tile source: TopSites ("client"), PopularSites ("popular"), MostLikely ("server0" or "server8"). The MostLikely ones are further split by "provider ID", which in practice is always 0 on desktop and always 8 on mobile. It's also not always included.
We should remove the provider ID from all histograms, and just use "server".

Comment 1 by treib@chromium.org, Jul 1 2016

Owner: treib@chromium.org
Status: Assigned (was: Available)

Comment 2 by treib@chromium.org, Jul 5 2016

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d304d764311a09dc1f680368e42bd8a94937d04f

commit d304d764311a09dc1f680368e42bd8a94937d04f
Author: treib <treib@chromium.org>
Date: Wed Jul 06 11:02:39 2016

Cleanup: Change LogMostVisitedImpression|Navigation APIs to take an enum
(instead of a string with only a few legal values)

BUG= 625161 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2117373002
Cr-Commit-Position: refs/heads/master@{#403880}

[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/resources/local_ntp/most_visited_single.js
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/resources/local_ntp/most_visited_thumbnail.js
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/resources/local_ntp/most_visited_title.js
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/resources/local_ntp/most_visited_util.js
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/ui/search/search_ipc_router.cc
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/ui/search/search_ipc_router.h
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/ui/search/search_ipc_router_unittest.cc
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/ui/search/search_tab_helper.cc
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/ui/search/search_tab_helper.h
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/ui/search/search_tab_helper_unittest.cc
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/browser/ui/webui/ntp/ntp_user_data_logger_unittest.cc
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/common/render_messages.h
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/common/search/ntp_logging_events.h
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/renderer/searchbox/searchbox.cc
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/renderer/searchbox/searchbox.h
[modify] https://crrev.com/d304d764311a09dc1f680368e42bd8a94937d04f/chrome/renderer/searchbox/searchbox_extension.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/685953392608663cae88b39dbaf65c45fb685d40

commit 685953392608663cae88b39dbaf65c45fb685d40
Author: treib <treib@chromium.org>
Date: Thu Jul 07 09:13:35 2016

Fix typo in multi-iframe NTP JS

Follow-up to https://codereview.chromium.org/2117373002/ which broke this.

BUG= 625161 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2126803002
Cr-Commit-Position: refs/heads/master@{#404101}

[modify] https://crrev.com/685953392608663cae88b39dbaf65c45fb685d40/chrome/browser/resources/local_ntp/most_visited_util.js

Comment 5 by treib@chromium.org, Jul 11 2016

Labels: zine-16-07-04 zine-16-07-11
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/886cb467d57a5b91d1c7afcc9500358b79363d13

commit 886cb467d57a5b91d1c7afcc9500358b79363d13
Author: treib <treib@chromium.org>
Date: Wed Jul 13 12:41:26 2016

Remove provider index from Android NewTabPage histograms

BUG= 625161 

Review-Url: https://codereview.chromium.org/2121133002
Cr-Commit-Position: refs/heads/master@{#405129}

[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/browser/android/ntp/most_visited_sites_bridge.h
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/components/ntp_tiles/most_visited_sites.cc
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/components/ntp_tiles/most_visited_sites.h
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/tools/metrics/histograms/histograms.xml

Comment 7 by treib@chromium.org, Jul 13 2016

Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/886cb467d57a5b91d1c7afcc9500358b79363d13

commit 886cb467d57a5b91d1c7afcc9500358b79363d13
Author: treib <treib@chromium.org>
Date: Wed Jul 13 12:41:26 2016

Remove provider index from Android NewTabPage histograms

BUG= 625161 

Review-Url: https://codereview.chromium.org/2121133002
Cr-Commit-Position: refs/heads/master@{#405129}

[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/browser/android/ntp/most_visited_sites_bridge.cc
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/chrome/browser/android/ntp/most_visited_sites_bridge.h
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/components/ntp_tiles/most_visited_sites.cc
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/components/ntp_tiles/most_visited_sites.h
[modify] https://crrev.com/886cb467d57a5b91d1c7afcc9500358b79363d13/tools/metrics/histograms/histograms.xml

Comment 9 by son...@google.com, May 15 2017

Status: Verified (was: Fixed)
Verified.
►

Sign in to add a comment