New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625153 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 611341



Sign in to add a comment

Implement NewTabPage.SuggestionsImpression and .MostVisited on Android

Project Member Reported by treib@chromium.org, Jul 1 2016

Issue description

Android already has NewTabPage.SuggestionsImpression.[client|server|...] histograms, but not the summed-up versions.
 
Owner: mastiz@chromium.org
Status: Assigned (was: Available)
I can give this a try.

Comment 2 by treib@chromium.org, Jul 7 2016

Cc: mastiz@chromium.org
Owner: treib@chromium.org
Status: Started (was: Assigned)

Comment 3 by treib@chromium.org, Jul 11 2016

Labels: zine-16-07-04 zine-16-07-11
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47e486826a2a7a8865e1fceb2e1494443625c954

commit 47e486826a2a7a8865e1fceb2e1494443625c954
Author: treib <treib@chromium.org>
Date: Wed Jul 13 14:28:55 2016

Add NewTabPage.MostVisited and .SuggestionsImpression on Android

The same histograms already exist on desktop, see ntp_user_data_logger.cc

BUG= 625153 

Review-Url: https://codereview.chromium.org/2126263002
Cr-Commit-Position: refs/heads/master@{#405142}

[modify] https://crrev.com/47e486826a2a7a8865e1fceb2e1494443625c954/components/ntp_tiles/most_visited_sites.cc
[modify] https://crrev.com/47e486826a2a7a8865e1fceb2e1494443625c954/components/ntp_tiles/most_visited_sites.h

Comment 5 by treib@chromium.org, Jul 13 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47e486826a2a7a8865e1fceb2e1494443625c954

commit 47e486826a2a7a8865e1fceb2e1494443625c954
Author: treib <treib@chromium.org>
Date: Wed Jul 13 14:28:55 2016

Add NewTabPage.MostVisited and .SuggestionsImpression on Android

The same histograms already exist on desktop, see ntp_user_data_logger.cc

BUG= 625153 

Review-Url: https://codereview.chromium.org/2126263002
Cr-Commit-Position: refs/heads/master@{#405142}

[modify] https://crrev.com/47e486826a2a7a8865e1fceb2e1494443625c954/components/ntp_tiles/most_visited_sites.cc
[modify] https://crrev.com/47e486826a2a7a8865e1fceb2e1494443625c954/components/ntp_tiles/most_visited_sites.h

Sign in to add a comment