New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625145 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Refine snap scrolling behaviour for tablets

Project Member Reported by peconn@chromium.org, Jul 1 2016

Issue description

The NTP page on tablet has both the fakebox and the omnibox. How should the scrolling transition work with this?

I have attached videos of two options:

- Do not have any transition on the fakebox. Since we no longer fade out the logo, maybe we should just let the fakebox get scrolled up behind the omnibox.

- Have the fakebox fade out as it approaches the omnibox (what the vanilla NTP does).
 
no-fade.mp4
7.7 MB View Download
fade.mp4
8.9 MB View Download
For now let's keep the fade. We could start a bit earlier if we want, but I don't feel strongly.

Comment 2 by finkm@google.com, Jul 13 2016

Labels: -zine- zine-client-v1
Labels: M-54 zine-ux OS-Android
Labels: -Pri-3 -zine-ux zine-triaged Pri-1
We'll go with the fading option in M54. Keep current fade point. This is currently implemented.

Peter - this doesn't seem to work as intended on yesterday's trunk build. You can ask pke@.

Comment 5 by peconn@chromium.org, Aug 10 2016

Sorry, what do you mean by 'this is currently implemented, but doesn't work'?
Cc: pke@google.com
+pke to clarify

Comment 7 by pke@google.com, Aug 10 2016

Attached two screenshots.

The first shows the snapping position, where the box is still fully visible. The second shows a few pixels above, where the box is fading away.
The position where it snaps / starts fading is way too high.
Screenshot_20160810-162724.png
128 KB View Download
Screenshot_20160810-162809.png
134 KB View Download

Comment 8 by peconn@chromium.org, Aug 23 2016

Labels: zine-16-08-22

Comment 9 by nepper@chromium.org, Aug 26 2016

Hi Peter,

did this make the M54 BP?

Thanks

Patrick
This has not made the branch point, I am hoping to get it merged though.
Labels: zine-ux
How does this look?
2016-08-29_14-07-51.mp4
8.0 MB View Download
Hm - this feels like the transition is happening too close to the omnibox. Let's discuss in the weekly.
Documenting our discussion in the weekly. Pete will try starting the animation a second before reaching the top of the screen.
Thanks for the update, Rachel! :)

Pete, what's the status here?
Labels: zine-16-09-12
I had discussed the desired result with Rachel, I've not got around to implementing it.
Rachel, how do these before and after videos look?
625145-before.mp4
2.3 MB View Download
625145-after.mp4
3.7 MB View Download
Thanks Pete!

Now it feels just a little early. Could you possibly tweak it to be somewhere between the two timing-wise?
How about this?

The other important question is how this will change NTP interaction. Do we want to snap scroll out of the entire animation region (so users cannot come to rest midway through the transition).
2016-09-16_10-16-15.mp4
6.4 MB View Download
That looks good. 

//The other important question is how this will change NTP interaction. Do we want to snap scroll out of the entire animation region (so users cannot come to rest midway through the transition).

No, I think we should leave it as is for now. We'll do more work in this space a bit later on.
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c68e23208ff63d1e6562443618a5310883d0efae

commit c68e23208ff63d1e6562443618a5310883d0efae
Author: peconn <peconn@chromium.org>
Date: Fri Sep 16 10:23:04 2016

[NewTabPage] Refine fakebox scrolling transition on tablets.

- Add the tab strip height factor into the transition equation to make sure the
transition is anchored to the top of the tab.
- Override ntp_search_box_transition_length to make the transition take longer
on tablets.

BUG= 625145 

Review-Url: https://codereview.chromium.org/2345673002
Cr-Commit-Position: refs/heads/master@{#419137}

[modify] https://crrev.com/c68e23208ff63d1e6562443618a5310883d0efae/chrome/android/java/res/values-sw600dp/dimens.xml
[modify] https://crrev.com/c68e23208ff63d1e6562443618a5310883d0efae/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Status: Fixed (was: Assigned)
Labels: -M-54 M-55
Cc: -pke@google.com peconn@chromium.org
Labels: -M-55 M-56
Owner: ----
Status: Available (was: Fixed)
Reopening this for even more refinement :)

Specifically, do we want to snap away from a state where the fakebox is partially transparent? It does look a bit strange to have that as a steady state.
OK to spend time experimenting.
Labels: -zine-ux

Comment 27 by fi...@chromium.org, Nov 22 2016

Labels: -Pri-1 -M-56 -zine-client-v1 zine-client-ux-v1 M-57 Pri-2
How do we want to proceed here? Who is going to make the first step? :-)
Cc: -rachelis@chromium.org
Owner: rachelis@chromium.org
What was the decision? I was not present on Nov 2.
Labels: zine-ux
I can't find any mention of this bug in the Zine UX meeting minutes from 2nd Nov (it was mentioned the week before, but no comments were made).

Rachel, what do you believe the next step is (can you expand on comment #25)?
I believe we agreed that it would be ok for eng to prototype changes to motion, but that we don't want to invest in this work on the ux side.
Labels: -Pri-2 -zine-ux Pri-3
Status: WontFix (was: Available)
This will no longer apply with Chrome Home. 

Sign in to add a comment