Refine snap scrolling behaviour for tablets |
||||||||||||||||
Issue descriptionThe NTP page on tablet has both the fakebox and the omnibox. How should the scrolling transition work with this? I have attached videos of two options: - Do not have any transition on the fakebox. Since we no longer fade out the logo, maybe we should just let the fakebox get scrolled up behind the omnibox. - Have the fakebox fade out as it approaches the omnibox (what the vanilla NTP does).
,
Jul 13 2016
,
Aug 3 2016
,
Aug 10 2016
We'll go with the fading option in M54. Keep current fade point. This is currently implemented. Peter - this doesn't seem to work as intended on yesterday's trunk build. You can ask pke@.
,
Aug 10 2016
Sorry, what do you mean by 'this is currently implemented, but doesn't work'?
,
Aug 10 2016
+pke to clarify
,
Aug 10 2016
Attached two screenshots. The first shows the snapping position, where the box is still fully visible. The second shows a few pixels above, where the box is fading away. The position where it snaps / starts fading is way too high.
,
Aug 23 2016
,
Aug 26 2016
Hi Peter, did this make the M54 BP? Thanks Patrick
,
Aug 26 2016
This has not made the branch point, I am hoping to get it merged though.
,
Aug 29 2016
How does this look?
,
Aug 30 2016
Hm - this feels like the transition is happening too close to the omnibox. Let's discuss in the weekly.
,
Sep 5 2016
Documenting our discussion in the weekly. Pete will try starting the animation a second before reaching the top of the screen.
,
Sep 9 2016
Thanks for the update, Rachel! :) Pete, what's the status here?
,
Sep 12 2016
,
Sep 13 2016
I had discussed the desired result with Rachel, I've not got around to implementing it.
,
Sep 14 2016
Rachel, how do these before and after videos look?
,
Sep 16 2016
Thanks Pete! Now it feels just a little early. Could you possibly tweak it to be somewhere between the two timing-wise?
,
Sep 16 2016
How about this? The other important question is how this will change NTP interaction. Do we want to snap scroll out of the entire animation region (so users cannot come to rest midway through the transition).
,
Sep 16 2016
That looks good. //The other important question is how this will change NTP interaction. Do we want to snap scroll out of the entire animation region (so users cannot come to rest midway through the transition). No, I think we should leave it as is for now. We'll do more work in this space a bit later on.
,
Sep 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c68e23208ff63d1e6562443618a5310883d0efae commit c68e23208ff63d1e6562443618a5310883d0efae Author: peconn <peconn@chromium.org> Date: Fri Sep 16 10:23:04 2016 [NewTabPage] Refine fakebox scrolling transition on tablets. - Add the tab strip height factor into the transition equation to make sure the transition is anchored to the top of the tab. - Override ntp_search_box_transition_length to make the transition take longer on tablets. BUG= 625145 Review-Url: https://codereview.chromium.org/2345673002 Cr-Commit-Position: refs/heads/master@{#419137} [modify] https://crrev.com/c68e23208ff63d1e6562443618a5310883d0efae/chrome/android/java/res/values-sw600dp/dimens.xml [modify] https://crrev.com/c68e23208ff63d1e6562443618a5310883d0efae/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
,
Sep 22 2016
,
Sep 22 2016
,
Oct 21 2016
Reopening this for even more refinement :) Specifically, do we want to snap away from a state where the fakebox is partially transparent? It does look a bit strange to have that as a steady state.
,
Oct 24 2016
OK to spend time experimenting.
,
Nov 2 2016
,
Nov 22 2016
How do we want to proceed here? Who is going to make the first step? :-)
,
Nov 24 2016
What was the decision? I was not present on Nov 2.
,
Nov 24 2016
I can't find any mention of this bug in the Zine UX meeting minutes from 2nd Nov (it was mentioned the week before, but no comments were made). Rachel, what do you believe the next step is (can you expand on comment #25)?
,
Nov 24 2016
I believe we agreed that it would be ok for eng to prototype changes to motion, but that we don't want to invest in this work on the ux side.
,
Dec 5 2016
This will no longer apply with Chrome Home. |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by rachelis@chromium.org
, Jul 13 2016