New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625136 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Intervention: block Web Audio without user gesture in cross origin iframes

Project Member Reported by mlamouri@chromium.org, Jul 1 2016

Issue description

Usage of Web Audio without a user gesture is too high on top level frames to block it without breaking websites. In order to still prevent abuses, blocking cross origin iframes from using Web Audio without a user gesture on Android should be a step forward.

The first step is to get metrics regarding usage of the API in cross origin iframes (it will likely be low). Then, we should figure out how to expose the change to websites.
 
Labels: -Pri-3 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab151b40b44688092a5c0a8b5e0d26d963020dec

commit ab151b40b44688092a5c0a8b5e0d26d963020dec
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Jul 04 12:11:37 2016

Web Audio: measure cross origin iframe usage.

In order to figure out whether we can add restrictions on Web Audio
usage on cross origin iframes without breaking the Web.

BUG= 625136 

Review-Url: https://codereview.chromium.org/2120473002
Cr-Commit-Position: refs/heads/master@{#403669}

[modify] https://crrev.com/ab151b40b44688092a5c0a8b5e0d26d963020dec/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/ab151b40b44688092a5c0a8b5e0d26d963020dec/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp
[modify] https://crrev.com/ab151b40b44688092a5c0a8b5e0d26d963020dec/tools/metrics/histograms/histograms.xml

Labels: Merge-Request-53
Asking permission to merge the UMA to M53.

Comment 4 by dimu@google.com, Jul 4 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 4 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaad16cd6a623d566e75f072db80264e4a5836ac

commit aaad16cd6a623d566e75f072db80264e4a5836ac
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Jul 04 13:05:59 2016

Web Audio: measure cross origin iframe usage.

In order to figure out whether we can add restrictions on Web Audio
usage on cross origin iframes without breaking the Web.

BUG= 625136 

Review-Url: https://codereview.chromium.org/2120473002
Cr-Commit-Position: refs/heads/master@{#403669}
(cherry picked from commit ab151b40b44688092a5c0a8b5e0d26d963020dec)

Review URL: https://codereview.chromium.org/2117053002 .

Cr-Commit-Position: refs/branch-heads/2785@{#11}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/aaad16cd6a623d566e75f072db80264e4a5836ac/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/aaad16cd6a623d566e75f072db80264e4a5836ac/third_party/WebKit/Source/modules/webaudio/AudioContext.cpp
[modify] https://crrev.com/aaad16cd6a623d566e75f072db80264e4a5836ac/tools/metrics/histograms/histograms.xml

Comment 6 by rtoy@chromium.org, Nov 16 2016

Can we close this?  Is there something else that needs to be done?
Status: Fixed (was: Started)
Sounds good to close.

Sign in to add a comment