Non-Regression : "SIGN IN TO CHROME" Button is seen even after signing into the Account in chrome://history Page |
|||||
Issue descriptionVersion: 53.0.2785.0 OS: Ubuntu 14.04,Windows Pre-Condition : Enable 'Material Design history' flag from 'chrome://flags' What steps will reproduce the problem? (1)Launch chrome -> Go to chrome://history page -> Now click on "Synced tabs" (2)Click on "SIGN IN TO CHROME" Button -> Sign into the Account -> Wait til the history of other devices is synced (3)Now On synced tabs page Press F12 to open Dev tools->Click on "Toggle device toolbar" -> Scroll down the page (4)Now Reload the page and click on "Synced tabs" and scroll down the page and observe (Please refer Video) Expected: "SIGN IN TO CHROME" Button should not be seen even after signing into the Account Actual: Instead "SIGN IN TO CHROME" Button is seen This is Non-Regression Issue from M-53 as "SIGN IN TO CHROME" Button in "Synced Tabs" is introduced from 53.0.2776.0 Build Below is the MANUAL CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/53.0.2774.0..53.0.2776.0?pretty=fuller&n=10000 Suspecting https://codereview.chromium.org/2077473002 from Manual Changelog @lshang : Please feel free to re-assign if its not related to your change
,
Jul 1 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12 2016
,
Jul 22 2016
brajkumar@: I couldn't reproduce it now on M54, could you confirm?
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93473de1895935289af8159ac8e0def340659fcb commit 93473de1895935289af8159ac8e0def340659fcb Author: lshang <lshang@chromium.org> Date: Tue Aug 02 02:03:40 2016 MD History: Get sign in state from backend when refreshing the page In synced tabs page, the sign in promo will still show up when user signs in via the sign in promo and refresh the page. The reason of this bug is that internal sign in state of the element got updated, but refreshing the page, which gets the sign in state default value from loadTimeData, will still get the outdated state. Fix of the bug is to get sign in state from HistoryLoginHandler every time the page is reloaded, this will get the updated current sign in state. BUG= 625109 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2191173003 Cr-Commit-Position: refs/heads/master@{#409120} [modify] https://crrev.com/93473de1895935289af8159ac8e0def340659fcb/chrome/browser/resources/md_history/synced_device_manager.js
,
Aug 2 2016
,
Aug 9 2016
Tested the issue on Windows 7, Mac 10.11.6 using 54.0.2824.0, Ubuntu 14.04 using 54.0.2823.0(as unable to verify the fix on linux due to bug 635768).Observed that "SIGN IN TO CHROME" Button is not seen after signing into the account. Please find attached screencast. Marking it as TE-Verified. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by brajkumar@chromium.org
, Jul 1 2016