New issue
Advanced search Search tips

Issue 625100 link

Starred by 1 user
Status: Fixed
Owner:
eseckler@chromium.org
Closed: Jul 2016
Cc:
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Scrolling the inner viewport does not always respect --disable-threaded-scrolling.

Project Member Reported by eseckler@chromium.org, Jul 1 2016 
When scrolling occurs outside of any layers in Blink (e.g. overscroll), LayerTreeHostImpl::FindScrollLayerForDeviceViewportPoint falls back to the root layer (inner viewport scroll layer). For historical reasons, this fallback is enforced via compositor scrolling - Overscroll handling was originally not supported through Blink scrolling. Now that it is, the fallback should respect the layer's main thread scrolling reasons and the --disable-threaded-scrolling flag.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59eeb0282913e575a4409c257ce13f6de8e03d69

commit 59eeb0282913e575a4409c257ce13f6de8e03d69
Author: eseckler <eseckler@chromium.org>
Date: Tue Jul 05 10:45:17 2016

Respect main thread scrolling reasons for fallback to root layer scrolling.

For this purpose, ScrollingCoordinator now also commits the main thread scrolling reasons to the visual viewport scroll layer. We can thus simply check for main thread scrolling reasons on the final layer selected for scrolling in LayerTreeHostImpl::FindScrollLayerForDeviceViewportPoint.

BUG= 625100 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2118773002
Cr-Commit-Position: refs/heads/master@{#403765}

[modify] https://crrev.com/59eeb0282913e575a4409c257ce13f6de8e03d69/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/59eeb0282913e575a4409c257ce13f6de8e03d69/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/59eeb0282913e575a4409c257ce13f6de8e03d69/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
[modify] https://crrev.com/59eeb0282913e575a4409c257ce13f6de8e03d69/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Comment 2 by eseckler@chromium.org, Jul 5 2016

Status: Fixed (was: Untriaged)
►

Sign in to add a comment