Issue metadata
Sign in to add a comment
|
Chrome OS Virtual Keyboard's Globe key not working |
||||||||||||||||||||||
Issue descriptionVersion: 53.0.2785.0 OS: 8529.0.0 What steps will reproduce the problem? (1) Enable US keyboard and Google Japanese Input in Language setting. (2) Enable on-screen keyboard in Accessibility setting. (3) Focus omnibox. (4) Click the Globe icon on the virtual keyboard. What is the expected output? The keyboard switches (from US keyboard to Google Japanese Input). What do you see instead? Notification pop up "The shortcut to switch to the next input method is Ctrl-Shift-Space" is shown, and the keyboard does not switch. I believe this is a consequence of http://crbug.com/612990 -- Alt-Shift keyboard shortcut is removed at M53, but I guess the VK is still sending Alt-Shift from the button. CC'ed folks: I'm not sure who's the right owner in this area... Could you take a look or dispatch to appropriate person? Thanks!
,
Jul 3 2016
Yingbing, can you please fix this by using chrome.inputMethodPrivate.setCurrentInputMethod API instead of the shortcut keys? Thanks!
,
Jul 4 2016
Hi Shu, Use chrome.inputMethodPrivate.setCurrentInputMethod to fix the issue. We need know the previous input tools. Current JS only can get the input tools list. By the way, our input tools has two instance. So we can't simply record the previous input tools. We need export an API to fetch the previous input tools. (It may belong to different input tool extension) but I suggest to export chrome.inputMethodPrivate.revertCurrentInputMethod to reduce the API call time.
,
Jul 4 2016
Offline discussed, this is to switch to the next input tool instead of revert to previous input tool. So setCurrentInputMethod() can do the job.
,
Jul 6 2016
,
Jul 21 2016
CL https://chrome-internal-review.googlesource.com/#/c/268977/ has landed. This issue should have been fixed by it in M54.
,
Jul 21 2016
Requesting merge to M53.
,
Jul 22 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 26 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 29 2016
PEK office is moving, and I don't have a machine with ChromeOS enlistment to do the merge. kinaba@, can you please help to merge https://chrome-internal-review.googlesource.com/#/c/268977/ to M53? Thanks!
,
Jul 29 2016
Sure. Cherry-pick CL: https://chrome-internal-review.googlesource.com/#/c/272105/
,
Jul 29 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/chromeos-overlay/+/e9bdf51ebbb95b38cc8c8e12dc435cad4e23219a commit e9bdf51ebbb95b38cc8c8e12dc435cad4e23219a Author: Yingbing Wu <wuyingbing@google.com> Date: Mon Jul 11 04:39:23 2016
,
Jul 29 2016
I hope it's done
,
Jul 29 2016
,
Jul 29 2016
Thanks!
,
Aug 12 2016
verified on 53.0.2785.55 / 8530.49.0 build |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Jul 1 2016