New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625089 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 310763
issue 643449



Sign in to add a comment

Remove [Shared]DeviceDisplayInfo in favor of a DisplayManager and ui/display

Project Member Reported by gsennton@chromium.org, Jul 1 2016

Issue description

DeviceDisplayInfo is a native cache for the primary display. The cache is updated every time the orientation of a display changes (as a special case in ScreenOrientationListener). With the effort to support several displays in WebView (or at least to be able to attach a WebView to a Presentation, see https://developer.android.com/reference/android/app/Presentation.html)  in  crbug.com/310763 , we want to store a cache containing several displays instead of just one.

Furthermore it seems beneficial to use the screen interface (https://cs.chromium.org/chromium/src/ui/display/screen.h) for fetching display information from the native side, thus making Android more similar to the rest of Chrome, instead of having an Android-specific DeviceDisplayInfo object. This means using Screen.GetPrimaryDisplay() for cases where we specifically want the primary display and using Screen.GetDisplayNearestWindow(NativeView) to get the display of a certain ContentViewCore.

A doc explaining the effort to support several displays for WebView can be found here:
https://docs.google.com/a/google.com/document/d/1fJDGn3wSzKtm7HSkSatWRXgkAZqj95iBJ20gtsZhqrc/edit?usp=sharing

that doc also describes what changes we need to make to ui/display to have it replace the native DeviceDisplayInfo, this means adding a couple of fields. To replace the java-side DeviceDisplayInfo I believe we just need some static utility methods that can fetch the information we want from an Android Display object.
 
Cc: siev...@chromium.org mfomitchev@chromium.org
Hm, I just noticed
https://codereview.chromium.org/1474873002
which implies that there are cases where the native screen instance hasn't been set yet, and where we need to fetch display metrics.

mfomitchev@ is that CL still needed? It seems like the associated bug was closed as Won't Fix since Aura for Android was cancelled. (and according to one of your comments on the CL this should be fine for ScreenAndroid, just not for ScreenAura).

The place that CL touches is ResourceBundle::InitSharedInstance which seems to be called super-early (e.g. through  ChromeMainDelegate::PreSandboxStartup -> ResourceBundle::InitSharedInstanceWithLocale -> ResourceBundle::InitSharedInstance).
IIRC with the changes we want to do here we will have to set the ScreenAndroid instance manually, so we will have to do it before, or in, PreSandboxStartup.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32db3cb3ef603f3510ca843ffc57e80f558f53d1

commit 32db3cb3ef603f3510ca843ffc57e80f558f53d1
Author: gsennton <gsennton@chromium.org>
Date: Fri Jul 08 14:08:11 2016

Replace/remove some uses of DeviceDisplayInfo

This is part of an effort to remove the Android-specific
DeviceDisplayInfo that can currently only handle one Display. To support
attaching WebView to a Presentation we need a solution that allows for
multiple displays.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2121973003
Cr-Commit-Position: refs/heads/master@{#404353}

[modify] https://crrev.com/32db3cb3ef603f3510ca843ffc57e80f558f53d1/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/32db3cb3ef603f3510ca843ffc57e80f558f53d1/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/32db3cb3ef603f3510ca843ffc57e80f558f53d1/content/browser/web_contents/web_contents_android.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd7bd961d337a05e0be0e66aa3f31806a7b14909

commit dd7bd961d337a05e0be0e66aa3f31806a7b14909
Author: gsennton <gsennton@chromium.org>
Date: Tue Jul 26 16:07:15 2016

Add the fields bits-per-pixel and bits-per-component to Display.

On Android we currently use an object called DeviceDisplayInfo to hold
information about a display. To replace this object with
ui::display::Display we need to add some fields, that are specific to
Android, to Display.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2151563002
Cr-Commit-Position: refs/heads/master@{#407821}

[modify] https://crrev.com/dd7bd961d337a05e0be0e66aa3f31806a7b14909/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/dd7bd961d337a05e0be0e66aa3f31806a7b14909/ui/display/android/screen_android.cc
[modify] https://crrev.com/dd7bd961d337a05e0be0e66aa3f31806a7b14909/ui/display/display.cc
[modify] https://crrev.com/dd7bd961d337a05e0be0e66aa3f31806a7b14909/ui/display/display.h

@gsennton: Sorry, just noticed this. Feel free to ignore https://codereview.chromium.org/1474873002. As you said, Aura Android is cancelled, so feel free to change the code back how it was before if that makes things easier.

Comment 5 by boliu@chromium.org, Sep 16 2016

Cc: gsennton@chromium.org
Owner: boliu@chromium.org
I'm gonna actively work on this. I'm going to introduce a "Display" concept that matches roughly with what ui/display means by "Display", and nuke DeviceDisplayInfo, and probably ViewConfiguration. And probably fix some layering in ui/android (there is no layering at all right now!)

Also I wrote a doc, although not directly relevant to this bug:
https://docs.google.com/document/d/18vnzIAo31K9V5sp6fVS8V_RcZdav6444UuYUsdqiWv4/edit?usp=sharing

Comment 7 by boliu@chromium.org, Sep 21 2016

Cc: aelias@chromium.org mlamouri@chromium.org
WIP CL here: https://codereview.chromium.org/2361633002. It's going to require moving OrientationListener down to the ui/display layer, which is where it belongs.

But before doing that, I'm going to rip out the polling code, which is only used on jb api level 16 to detect 180 degree rotations.

Comment 8 by boliu@chromium.org, Sep 28 2016

all the orientation listener tests are flaky/disabled. I'm considering if I should rewrite them, or just delete them

Comment 9 by ti...@chromium.org, Sep 28 2016

Cc: ti...@chromium.org

Comment 10 by boliu@chromium.org, Sep 28 2016

hmm.....maybe the tests were broken because android is broken, I'm testing on L and REVERSE_PORTRAIT actually just rotates to regular portrait o_O

Comment 11 by boliu@chromium.org, Sep 28 2016

oh, heh, old test has ALLOW_0_FOR_180, isn't android great..
Some phones for some reasons refuse to rotate to reverse portrait but I was never able to find one and Android doesn't expose an API that exposes this.

Comment 13 by boliu@chromium.org, Sep 29 2016

I found both reverse portrait and reverse landscape don't work, at least on L nexus 4.

Did you remember any nexus device where this *does* work?

Also still plenty of work left to do, but I basically rewrote the tests, and just deleted everything that involves reverse orientations, so deleted 4/6 of the tests. You are welcome to take a look now if you are interested: https://codereview.chromium.org/2361633002
N4 on 5.1.1 in front of me works as expected.

Test page: https://mounirlamouri.github.io/sandbox/screenorientation.html

STR:
- "Toggle fullscreen"
- Select "portrait-secondary"
- Press "Go"
- Select "landscope-secondary"
- Press "Go"

Comment 15 by boliu@chromium.org, Sep 29 2016

I'm on N4 5.1.1 as well. Testing latest archived build 55.0.2875.0.

portrait-secondary isn't upside down, but landscope-secondary is uhh...."right side" down as expected. I'll double check what happens in the test with REVERSE_LANDSCAPE

Comment 16 by boliu@chromium.org, Sep 29 2016

ok, yeah, REVERSE_LANDSCAPE/LANDSCAPE_SECONDARY works without any changes, not sure what I was thinking yesterday..
I'm confused by "portrait-secondary" not being upside down. Do you reproduce this only on that specific phone?

Comment 18 by boliu@chromium.org, Sep 30 2016

I've tried on that phone only. Isn't that what ALLOW_0_FOR_180 in the test is for, that portrait-secondary and REVERSE_PORTRAIT is just plain old portrait, not actually "upside down"?
No it's not. It is because some bots couldn't do proper reverse portrait but I've never been able to reproduce locally. On my phones, it has always been working.

Comment 20 by boliu@chromium.org, Sep 30 2016

what's ALLOW_0_FOR_180 for then?
Cc: -mfomitchev@chromium.org
The flag was added to let the tests pass on the bots that wouldn't allow the rotation. I realised that it was better to have this partially covered that not at all. As I said, locally, I couldn't reproduce this and I tried on many phones with various versions of Android.

Comment 23 by boliu@chromium.org, Sep 30 2016

I'll try on more devices when I get a chance. I guess somehow I just happened to run into a device where it's broken.

But I'd rather not have the test rely on android behavior if that behavior is proven to be not consistent. I believe very strongly that tests that can't run consistently is not worth the maintenance cost.
Ok, all other devices I tested all work fine. So the N4 I happened to be using is the special one.

N5 K <- cq configuration
N7 M
N9 M
Pixel C N

I didn't have a 5x handy right now, but I suspect it's probably fine. Besides, cq will catch it if I break it.

So I think I'm going to add back REVERSE_PORTRAIT, but remove the old ALLOW_0_FOR_180.
Sounds good. I guess the CQ was using N4 when I wrote this test.
REVERSE_PORTRAIT failed on both cq configurations, including the one I tested. wat?!
Oh I got it! REVERSE_PORTRAIT doesn't work when the device is orientation locked. Guess all the devices on cq are orientation locked then..
Project Member

Comment 28 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16136c0600c027d8dac41a3871f687851fd8d773

commit 16136c0600c027d8dac41a3871f687851fd8d773
Author: boliu <boliu@chromium.org>
Date: Thu Oct 06 00:55:28 2016

android: Introduce DisplayAndroid

DisplayAndroid is the Display abstraction. It will eventually
replace all usage of DeviceDisplayInfo. Main difference is
DeviceDisplayInfo assumes there is only one display, whereas
DisplayAndroid can support many.

Move ScreenOrientationListener to the ui layer as an
implementation detail. Rewrote the tests to use
CallbackHelper.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2361633002
Cr-Commit-Position: refs/heads/master@{#423363}

[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/public/android/BUILD.gn
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[delete] https://crrev.com/88a14008509adefe2b764ccb573ba629ba68dac5/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java
[delete] https://crrev.com/88a14008509adefe2b764ccb573ba629ba68dac5/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/public/test/android/BUILD.gn
[delete] https://crrev.com/88a14008509adefe2b764ccb573ba629ba68dac5/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockOrientationObserver.java
[delete] https://crrev.com/88a14008509adefe2b764ccb573ba629ba68dac5/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/OrientationChangeObserverCriteria.java
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/shell/android/BUILD.gn
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/ui/android/BUILD.gn
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
[add] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java
[add] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java

Project Member

Comment 29 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df

commit ca85be85c0bf1d91b9d06b50c2216e7a7394d4df
Author: boliu <boliu@chromium.org>
Date: Fri Oct 07 06:08:32 2016

android: Use DisplayAndroid in java

This replaces usage of java DeviceDisplayInfo with DisplayAndroid.
Unfortunately java code generally only pass around the Context instead
of WindowAndroid, so need to officially expose the DisplayAndroid.get
method to the public.

The rest is pretty easy. Only had to add getDIPScale.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2394773006
Cr-Commit-Position: refs/heads/master@{#423806}

[modify] https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df/android_webview/java/src/org/chromium/android_webview/AwViewAndroidDelegate.java
[modify] https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
[modify] https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java
[modify] https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java
[modify] https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java
[modify] https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
[modify] https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java
[modify] https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df/components/autofill/android/java/src/org/chromium/components/autofill/AutofillKeyboardAccessory.java
[modify] https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java
[modify] https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java
[modify] https://crrev.com/ca85be85c0bf1d91b9d06b50c2216e7a7394d4df/ui/android/java/src/org/chromium/ui/resources/ResourceManager.java

Project Member

Comment 30 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1d7c92e975b51de35471b539d6840ceabd68374

commit c1d7c92e975b51de35471b539d6840ceabd68374
Author: boliu <boliu@chromium.org>
Date: Wed Oct 12 23:15:47 2016

android: Register Display lazily

Apparently trying to look up the Display inside onDisplayAdded returns
null, and causing crashes. Lazily register display to be added on first
use instead to avoid this crash.

BUG=655241,  625089 

Review-Url: https://codereview.chromium.org/2420453002
Cr-Commit-Position: refs/heads/master@{#424901}

[modify] https://crrev.com/c1d7c92e975b51de35471b539d6840ceabd68374/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java
[modify] https://crrev.com/c1d7c92e975b51de35471b539d6840ceabd68374/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java

Project Member

Comment 31 by bugdroid1@chromium.org, Oct 14 2016

Labels: merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4912b292e1176dae1976affdfa6ab15b0b7eda33

commit 4912b292e1176dae1976affdfa6ab15b0b7eda33
Author: Bo Liu <boliu@chromium.org>
Date: Fri Oct 14 22:28:04 2016

[Merge M55] android: Register Display lazily

Apparently trying to look up the Display inside onDisplayAdded returns
null, and causing crashes. Lazily register display to be added on first
use instead to avoid this crash.

BUG=655241,  625089 

Review-Url: https://codereview.chromium.org/2420453002
Cr-Commit-Position: refs/heads/master@{#424901}
(cherry picked from commit c1d7c92e975b51de35471b539d6840ceabd68374)

Review URL: https://codereview.chromium.org/2418283003 .

Cr-Commit-Position: refs/branch-heads/2883@{#123}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/4912b292e1176dae1976affdfa6ab15b0b7eda33/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java
[modify] https://crrev.com/4912b292e1176dae1976affdfa6ab15b0b7eda33/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java

Project Member

Comment 32 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16136c0600c027d8dac41a3871f687851fd8d773

commit 16136c0600c027d8dac41a3871f687851fd8d773
Author: boliu <boliu@chromium.org>
Date: Thu Oct 06 00:55:28 2016

android: Introduce DisplayAndroid

DisplayAndroid is the Display abstraction. It will eventually
replace all usage of DeviceDisplayInfo. Main difference is
DeviceDisplayInfo assumes there is only one display, whereas
DisplayAndroid can support many.

Move ScreenOrientationListener to the ui layer as an
implementation detail. Rewrote the tests to use
CallbackHelper.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2361633002
Cr-Commit-Position: refs/heads/master@{#423363}

[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/public/android/BUILD.gn
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[delete] https://crrev.com/88a14008509adefe2b764ccb573ba629ba68dac5/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationListener.java
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationListenerTest.java
[delete] https://crrev.com/88a14008509adefe2b764ccb573ba629ba68dac5/content/public/android/javatests/src/org/chromium/content/browser/ScreenOrientationProviderTest.java
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/public/test/android/BUILD.gn
[delete] https://crrev.com/88a14008509adefe2b764ccb573ba629ba68dac5/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/MockOrientationObserver.java
[delete] https://crrev.com/88a14008509adefe2b764ccb573ba629ba68dac5/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/OrientationChangeObserverCriteria.java
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/content/shell/android/BUILD.gn
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/ui/android/BUILD.gn
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
[add] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java
[add] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
[modify] https://crrev.com/16136c0600c027d8dac41a3871f687851fd8d773/ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java

Project Member

Comment 33 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4912b292e1176dae1976affdfa6ab15b0b7eda33

commit 4912b292e1176dae1976affdfa6ab15b0b7eda33
Author: Bo Liu <boliu@chromium.org>
Date: Fri Oct 14 22:28:04 2016

[Merge M55] android: Register Display lazily

Apparently trying to look up the Display inside onDisplayAdded returns
null, and causing crashes. Lazily register display to be added on first
use instead to avoid this crash.

BUG=655241,  625089 

Review-Url: https://codereview.chromium.org/2420453002
Cr-Commit-Position: refs/heads/master@{#424901}
(cherry picked from commit c1d7c92e975b51de35471b539d6840ceabd68374)

Review URL: https://codereview.chromium.org/2418283003 .

Cr-Commit-Position: refs/branch-heads/2883@{#123}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/4912b292e1176dae1976affdfa6ab15b0b7eda33/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java
[modify] https://crrev.com/4912b292e1176dae1976affdfa6ab15b0b7eda33/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java

Project Member

Comment 34 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05d1753af587de2e87ea796c4e7608b0254d26b3

commit 05d1753af587de2e87ea796c4e7608b0254d26b3
Author: mthiesse <mthiesse@chromium.org>
Date: Wed Nov 02 16:45:50 2016

Make clear that WindowAndroid::getDisplay must be used when supporting multi-display.

Contexts cannot be clearly mapped to displays, so while you may get the correct display from DisplayAndroid::get, you shouldn't count on that.

This is important because future work will be adding virtual, or "fake", displays that will only be mapped to WindowAndroids, and not Contexts.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2455653002
Cr-Commit-Position: refs/heads/master@{#429305}

[modify] https://crrev.com/05d1753af587de2e87ea796c4e7608b0254d26b3/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
[modify] https://crrev.com/05d1753af587de2e87ea796c4e7608b0254d26b3/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java
[modify] https://crrev.com/05d1753af587de2e87ea796c4e7608b0254d26b3/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java
[modify] https://crrev.com/05d1753af587de2e87ea796c4e7608b0254d26b3/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java
[modify] https://crrev.com/05d1753af587de2e87ea796c4e7608b0254d26b3/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
[modify] https://crrev.com/05d1753af587de2e87ea796c4e7608b0254d26b3/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java
[modify] https://crrev.com/05d1753af587de2e87ea796c4e7608b0254d26b3/content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java
[modify] https://crrev.com/05d1753af587de2e87ea796c4e7608b0254d26b3/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
[modify] https://crrev.com/05d1753af587de2e87ea796c4e7608b0254d26b3/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java
[modify] https://crrev.com/05d1753af587de2e87ea796c4e7608b0254d26b3/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java

Comment 35 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 36 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974

commit 77e12a6a2c9d9eaf2000204dbfa3426fbd14f974
Author: timav <timav@chromium.org>
Date: Tue Nov 08 22:06:54 2016

Rename getDIPScale() to getDipScale()

Rename the method to comply to Java code guidelines.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2485063004
Cr-Commit-Position: refs/heads/master@{#430733}

[modify] https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974/android_webview/java/src/org/chromium/android_webview/AwViewAndroidDelegate.java
[modify] https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974/android_webview/javatests/src/org/chromium/android_webview/test/AndroidScrollIntegrationTest.java
[modify] https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974/android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java
[modify] https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsAnchorViewTest.java
[modify] https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974/android_webview/javatests/src/org/chromium/android_webview/test/AwLegacyQuirksTest.java
[modify] https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
[modify] https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974/chrome/android/java/src/org/chromium/chrome/browser/firstrun/ProfileDataCache.java
[modify] https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[modify] https://crrev.com/77e12a6a2c9d9eaf2000204dbfa3426fbd14f974/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java

Project Member

Comment 37 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49d4682679e71d1863b589b29933d9d0f5051059

commit 49d4682679e71d1863b589b29933d9d0f5051059
Author: timav <timav@chromium.org>
Date: Tue Nov 15 17:15:00 2016

Android: Create ScreenInfo for the right display

Since API 17 Android can have multiple displays.
This CL creates ScreenInfo object for the display that
holds the view, and not for the primary display as before.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2499173002
Cr-Commit-Position: refs/heads/master@{#432203}

[modify] https://crrev.com/49d4682679e71d1863b589b29933d9d0f5051059/content/browser/web_contents/web_contents_view_android.cc

Project Member

Comment 38 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8

commit 3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8
Author: timav <timav@chromium.org>
Date: Wed Nov 16 00:19:53 2016

Android: support multiple displays on C++ side

Starting with API 17 Android can have multiple displays.

CL https://codereview.chromium.org/2361633002 introduced the map
of DisplayAndroid objects on Java side. This CL uses the information
from Java layer to maintain a similar map on the native side.

Similar to other platforms, an individual display is represented
by a Display object, and the collection of all displays in the
system is the Screen object. The Screen object for Android
maintains the mapping between the Android display ID and Display
and receives updates from DisplayAndroidManager.java through JNI.
Therefore the Screen implementation is placed in DisplayAndroidManager
class.

The Screen interface assumes the existence of the primary display.
To support this we always add the primary display on the Java side
(it is propagated to native) during the initialization of
DisplayAndroidManager.java

Native DisplayAndroidManager obtains the display ID from WindowAndroid
and thus depends on /ui/android. This CL places the manager in /ui/android
as well. Because of this we have to explicitly initialize the Screen
singleton by calling SetScreenAndroid() (similar to
other platforms) instead of creating the Screen object on demand.

The explicit initialization of the Screen happens on most platforms,
and required some tests modification.

Note: the explicit initialization of the Android Screen object required
some tests modification. Since the screen used to be created on demand,
we could have missed some tests that run on Android and not
covered by CQ.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2416403002
Cr-Commit-Position: refs/heads/master@{#432310}

[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/content/browser/browser_main_loop.cc
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/content/public/test/test_renderer_host.h
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/content/test/BUILD.gn
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/BUILD.gn
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/DEPS
[add] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/display_android_manager.cc
[add] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/display_android_manager.h
[add] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/dummy_screen_android.cc
[add] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/dummy_screen_android.h
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
[add] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/screen_android.h
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/ui_android_jni_registrar.cc
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/window_android.cc
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/android/window_android.h
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/display/BUILD.gn
[delete] https://crrev.com/491d3509af0f0ba16bca665a91014c9d8aeb2b80/ui/display/android/screen_android.cc
[modify] https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8/ui/display/screen.cc

Project Member

Comment 39 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ece04082b79fd30261b48ad895e7f05beeda7823

commit ece04082b79fd30261b48ad895e7f05beeda7823
Author: timav <timav@chromium.org>
Date: Fri Nov 18 04:38:33 2016

Revert of Android: support multiple displays on C++ side (patchset #32 id:690001 of https://codereview.chromium.org/2416403002/ )

Reason for revert:
Revert to see whether it fixes failures in webkit_tests, e.g.
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/57004

see  http://crbug.com/666420 

unexpected_failures:
svg/batik/text/textAnchor3.svg
images/paletted-png-with-color-profile.html
svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg
svg/as-background-image/svg-width-100p-as-background.html

Original issue's description:
> Android: support multiple displays on C++ side
>
> Starting with API 17 Android can have multiple displays.
>
> CL https://codereview.chromium.org/2361633002 introduced the map
> of DisplayAndroid objects on Java side. This CL uses the information
> from Java layer to maintain a similar map on the native side.
>
> Similar to other platforms, an individual display is represented
> by a Display object, and the collection of all displays in the
> system is the Screen object. The Screen object for Android
> maintains the mapping between the Android display ID and Display
> and receives updates from DisplayAndroidManager.java through JNI.
> Therefore the Screen implementation is placed in DisplayAndroidManager
> class.
>
> The Screen interface assumes the existence of the primary display.
> To support this we always add the primary display on the Java side
> (it is propagated to native) during the initialization of
> DisplayAndroidManager.java
>
> Native DisplayAndroidManager obtains the display ID from WindowAndroid
> and thus depends on /ui/android. This CL places the manager in /ui/android
> as well. Because of this we have to explicitly initialize the Screen
> singleton by calling SetScreenAndroid() (similar to
> other platforms) instead of creating the Screen object on demand.
>
> The explicit initialization of the Screen happens on most platforms,
> and required some tests modification.
>
> Note: the explicit initialization of the Android Screen object required
> some tests modification. Since the screen used to be created on demand,
> we could have missed some tests that run on Android and not
> covered by CQ.
>
> BUG= 625089 
>
> Committed: https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8
> Cr-Commit-Position: refs/heads/master@{#432310}

TBR=boliu@chromium.org,tedchoc@chromium.org,mthiesse@chromium.org,sky@chromium.org,derat@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 625089 

Review-Url: https://codereview.chromium.org/2514633002
Cr-Commit-Position: refs/heads/master@{#433108}

[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/content/browser/browser_main_loop.cc
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/content/public/test/test_renderer_host.h
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/content/test/BUILD.gn
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/ui/android/BUILD.gn
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/ui/android/DEPS
[delete] https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b/ui/android/display_android_manager.cc
[delete] https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b/ui/android/display_android_manager.h
[delete] https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b/ui/android/dummy_screen_android.cc
[delete] https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b/ui/android/dummy_screen_android.h
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
[delete] https://crrev.com/572f871f139ed9a514b69707a7e25345fff0de2b/ui/android/screen_android.h
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/ui/android/ui_android_jni_registrar.cc
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/ui/android/window_android.cc
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/ui/android/window_android.h
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/ui/display/BUILD.gn
[add] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/ui/display/android/screen_android.cc
[modify] https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823/ui/display/screen.cc

Blocking: 643449
Project Member

Comment 41 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe53c2c64abb741b886b16b9a8c725ed397be99f

commit fe53c2c64abb741b886b16b9a8c725ed397be99f
Author: timav <timav@chromium.org>
Date: Wed Nov 23 02:35:46 2016

Reland of Android: support multiple displays on C++ side

Original description:

Starting with API 17 Android can have multiple displays.

CL https://codereview.chromium.org/2361633002 introduced the map
of DisplayAndroid objects on Java side. This CL uses the information
from Java layer to maintain a similar map on the native side.

Similar to other platforms, an individual display is represented
by a Display object, and the collection of all displays in the
system is the Screen object. The Screen object for Android
maintains the mapping between the Android display ID and Display
and receives updates from DisplayAndroidManager.java through JNI.
Therefore the Screen implementation is placed in DisplayAndroidManager
class.

The Screen interface assumes the existence of the primary display.
To support this we always add the primary display on the Java side
(it is propagated to native) during the initialization of
DisplayAndroidManager.java

Native DisplayAndroidManager obtains the display ID from WindowAndroid
and thus depends on /ui/android. This CL places the manager in /ui/android
as well. Because of this we have to explicitly initialize the Screen
singleton by calling SetScreenAndroid() (similar to
other platforms) instead of creating the Screen object on demand.

The explicit initialization of the Screen happens on most platforms,
and required some tests modification.

Note: the explicit initialization of the Android Screen object required
some tests modification. Since the screen used to be created on demand,
we could have missed some tests that run on Android and not
covered by CQ.

BUG= 625089 

> > Committed: https://crrev.com/3da850c3bfadcf3d83407bb4aa9b1e047cbd44a8
> > Cr-Commit-Position: refs/heads/master@{#432310}

> Revert:
> Committed: https://crrev.com/ece04082b79fd30261b48ad895e7f05beeda7823
> Cr-Commit-Position: refs/heads/master@{#433108}

Review-Url: https://codereview.chromium.org/2416403002
Cr-Commit-Position: refs/heads/master@{#434090}

[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/content/browser/browser_main_loop.cc
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/content/browser/renderer_host/render_widget_host_unittest.cc
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/content/public/test/test_renderer_host.cc
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/content/public/test/test_renderer_host.h
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/content/test/BUILD.gn
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/BUILD.gn
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/DEPS
[add] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/display_android_manager.cc
[add] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/display_android_manager.h
[add] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/dummy_screen_android.cc
[add] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/dummy_screen_android.h
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/java/src/org/chromium/ui/base/WindowAndroid.java
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
[add] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/screen_android.h
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/ui_android_jni_registrar.cc
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/window_android.cc
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/android/window_android.h
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/display/BUILD.gn
[delete] https://crrev.com/cde36206b72b750f08a91a6ff4c50a9e269b8362/ui/display/android/screen_android.cc
[modify] https://crrev.com/fe53c2c64abb741b886b16b9a8c725ed397be99f/ui/display/screen.cc

Project Member

Comment 42 by bugdroid1@chromium.org, Jan 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae18bbf1c86ae6c94daefd7db49fcd7c660aa501

commit ae18bbf1c86ae6c94daefd7db49fcd7c660aa501
Author: boliu <boliu@chromium.org>
Date: Thu Jan 05 22:18:22 2017

Remove DeviceDisplayInfo from WebContentsViewAndroid

It's unused already.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2610853009
Cr-Commit-Position: refs/heads/master@{#441771}

[modify] https://crrev.com/ae18bbf1c86ae6c94daefd7db49fcd7c660aa501/content/browser/web_contents/web_contents_view_android.cc

Project Member

Comment 43 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02c81cd8f5b5ee59289345c3c73f2953c5708b9e

commit 02c81cd8f5b5ee59289345c3c73f2953c5708b9e
Author: boliu <boliu@chromium.org>
Date: Sat Jan 07 01:05:15 2017

android: Use Display in thumbnail_cache

Get the primary display to get the display dimensions, which removes
dependency on the deprecated DeviceDisplayInfo.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2619103002
Cr-Commit-Position: refs/heads/master@{#442123}

[modify] https://crrev.com/02c81cd8f5b5ee59289345c3c73f2953c5708b9e/chrome/browser/android/thumbnail/thumbnail_cache.cc

Project Member

Comment 44 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f8ab17a9400e5c22a19baec33d744658cde0496

commit 6f8ab17a9400e5c22a19baec33d744658cde0496
Author: boliu <boliu@chromium.org>
Date: Tue Jan 10 05:06:36 2017

android: Use ScreenInfo to calculate tile size

This removes the dependency on deprecated DeviceDisplayInfo.
Try to emulate previous logic, though the physical dimension computed
from ScreenInfo has rounding errors, so it's not exact.

Note for perf sheriffs: this may have device-specific perf impact.

BUG= 625089 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_blink_rel

Review-Url: https://codereview.chromium.org/2613303002
Cr-Commit-Position: refs/heads/master@{#442490}

[modify] https://crrev.com/6f8ab17a9400e5c22a19baec33d744658cde0496/blimp/client/support/compositor/blimp_layer_tree_settings.cc
[modify] https://crrev.com/6f8ab17a9400e5c22a19baec33d744658cde0496/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/6f8ab17a9400e5c22a19baec33d744658cde0496/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/6f8ab17a9400e5c22a19baec33d744658cde0496/content/renderer/gpu/render_widget_compositor_unittest.cc
[modify] https://crrev.com/6f8ab17a9400e5c22a19baec33d744658cde0496/content/renderer/render_widget.cc
[modify] https://crrev.com/6f8ab17a9400e5c22a19baec33d744658cde0496/content/test/layouttest_support.cc

Project Member

Comment 46 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa8bcd12c55c0997520ff969de9e70ab6d0a59dc

commit fa8bcd12c55c0997520ff969de9e70ab6d0a59dc
Author: boliu <boliu@chromium.org>
Date: Tue Jan 10 18:25:08 2017

Switch RenderWidgetHostViewAndroid to use Screen

Start to remove usage of native device_display_info.h and eventually
removing it altogether.

RenderWidgetHostViewAndroid uses the primary display size to calculate
the max texture size. Loop over all Displays and use the largest one to
calculate this instead.

Note need to add storage for physical size in Display, since there are
rounding errors if the physical size is computed from float scale and
integer dip size.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2617623002
Cr-Commit-Position: refs/heads/master@{#442634}

[modify] https://crrev.com/fa8bcd12c55c0997520ff969de9e70ab6d0a59dc/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/fa8bcd12c55c0997520ff969de9e70ab6d0a59dc/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/fa8bcd12c55c0997520ff969de9e70ab6d0a59dc/ui/android/display_android_manager.cc
[modify] https://crrev.com/fa8bcd12c55c0997520ff969de9e70ab6d0a59dc/ui/display/display.cc
[modify] https://crrev.com/fa8bcd12c55c0997520ff969de9e70ab6d0a59dc/ui/display/display.h

Project Member

Comment 47 by bugdroid1@chromium.org, Jan 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4868d4131b01a3e3520fcb2d65d9c5a1058a606a

commit 4868d4131b01a3e3520fcb2d65d9c5a1058a606a
Author: boliu <boliu@chromium.org>
Date: Tue Jan 10 19:13:05 2017

android: Remove DeviceDisplayInfo usage from ComopsitorImpl

Use the window to get the correct display instead.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2615793003
Cr-Commit-Position: refs/heads/master@{#442648}

[modify] https://crrev.com/4868d4131b01a3e3520fcb2d65d9c5a1058a606a/content/browser/renderer_host/compositor_impl_android.cc

Project Member

Comment 48 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb

commit 21c5afa38918f95dd79a171a9d9d16c85ae4e9eb
Author: boliu <boliu@chromium.org>
Date: Wed Jan 11 19:34:23 2017

android: Remove DeviceDisplayInfo

Move getSmallestDIPWidth to ChromeContextUtil in chrome. This removes
the last usage of DeviceDisplayInfo, so finally remove it.

BUG= 625089 

Review-Url: https://codereview.chromium.org/2623653002
Cr-Commit-Position: refs/heads/master@{#442981}

[add] https://crrev.com/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb/chrome/android/java/src/org/chromium/chrome/browser/util/ChromeContextUtil.java
[modify] https://crrev.com/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb/chrome/android/java_sources.gni
[modify] https://crrev.com/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb/chrome/browser/BUILD.gn
[add] https://crrev.com/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb/chrome/browser/android/chrome_context_util.cc
[add] https://crrev.com/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb/chrome/browser/android/chrome_context_util.h
[modify] https://crrev.com/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb/ui/android/BUILD.gn
[modify] https://crrev.com/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
[delete] https://crrev.com/bbdc4e44cb9a49b299fe296b0f02271bc60776e7/ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java
[modify] https://crrev.com/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb/ui/gfx/BUILD.gn
[delete] https://crrev.com/bbdc4e44cb9a49b299fe296b0f02271bc60776e7/ui/gfx/android/device_display_info.cc
[delete] https://crrev.com/bbdc4e44cb9a49b299fe296b0f02271bc60776e7/ui/gfx/android/device_display_info.h
[modify] https://crrev.com/21c5afa38918f95dd79a171a9d9d16c85ae4e9eb/ui/gfx/android/gfx_jni_registrar.cc
[delete] https://crrev.com/bbdc4e44cb9a49b299fe296b0f02271bc60776e7/ui/gfx/android/shared_device_display_info.cc
[delete] https://crrev.com/bbdc4e44cb9a49b299fe296b0f02271bc60776e7/ui/gfx/android/shared_device_display_info.h

Comment 49 by boliu@chromium.org, Jan 11 2017

Status: Fixed (was: Assigned)
it's gone \o/
Awesome! Thanks Bo
 Issue 681613  has been merged into this issue.

Sign in to add a comment