New issue
Advanced search Search tips

Issue 625084 link

Starred by 2 users
Status: Fixed
Owner:
eseckler@chromium.org
Closed: Sep 2016
Cc:
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Incorrect use of minimumScrollPosition() in ScrollingCoordinator

Project Member Reported by eseckler@chromium.org, Jul 1 2016 
ScrollingCoordinator::scrollableAreaScrollLayerDidChange() subtracts the minimumScrollPosition() of the ScrollableArea from the scroll position that is applied to the area's scroll layer. This seems to be done for the purpose of supporting right-to-left frames. In this context, it makes more sense to use the area's scrollOrigin(), which directly reflects the RTL behavior, instead of the minimumScrollPosition(), as the minimumScrollPosition may be overridden by users of the area (see e.g. https://codereview.chromium.org/2096633002/).
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a591c7e2e4fca8ef2bb1d775422b3f15e55bae8

commit 9a591c7e2e4fca8ef2bb1d775422b3f15e55bae8
Author: eseckler <eseckler@chromium.org>
Date: Fri Jul 01 17:41:49 2016

ScrollingCoordinator: On layer update, add scrollOrigin instead of subtracting minimumScrollPosition.

BUG= 625084 

Review-Url: https://codereview.chromium.org/2111203004
Cr-Commit-Position: refs/heads/master@{#403478}

[modify] https://crrev.com/9a591c7e2e4fca8ef2bb1d775422b3f15e55bae8/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Comment 2 by eseckler@chromium.org, Jul 4 2016

Status: Fixed (was: Started)

Comment 3 by eseckler@chromium.org, Jul 20 2016

Status: Started (was: Fixed)
This also happens in PaintLayerCompositor::frameViewDidScroll() and GraphicsLayer::didScroll(). We should use scrollOrigin() there as well.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ace38cb311d604745708c31284ba4ff291c4734

commit 0ace38cb311d604745708c31284ba4ff291c4734
Author: eseckler <eseckler@chromium.org>
Date: Tue Sep 27 09:39:17 2016

Use scrollOrigin instead of minimumScrollPosition to calculate current
layer position in PaintLayerCompositor and GraphicsLayer.

It makes more sense to use the area's scrollOrigin() instead of the
minimumScrollPosition(), as the minimumScrollPosition may be
overridden by users of the area (see e.g.
https://codereview.chromium.org/2096633002/).

BUG= 625084 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2169483002
Cr-Commit-Position: refs/heads/master@{#421159}

[modify] https://crrev.com/0ace38cb311d604745708c31284ba4ff291c4734/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/0ace38cb311d604745708c31284ba4ff291c4734/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Comment 5 by eseckler@chromium.org, Sep 27 2016

Status: Fixed (was: Started)
►

Sign in to add a comment