New issue
Advanced search Search tips

Issue 625072 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Storage manager: Count the size of site data as a part of size of "Browsing data".

Project Member Reported by fukino@chromium.org, Jul 1 2016

Issue description

Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Click "Storage management" from chrome://settings.
(2) Check the size of "Browsing data"

What is the expected output?
The displayed size is the size of HTTP cache.
The size of site data should also be added.

Please use labels and text to provide additional information.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bace6ed0fd91cd357569dc9ad1d285ff2390520e

commit bace6ed0fd91cd357569dc9ad1d285ff2390520e
Author: fukino <fukino@chromium.org>
Date: Fri Jul 08 09:28:43 2016

Storage manager: Add site data size on the amount of browsing data.

The size of browsing data used to contain only HTTP cache.
This CL adds the total size of site data as a part of browsing data.

BUG= 625072 
TEST=manually tested

Review-Url: https://codereview.chromium.org/2123133002
Cr-Commit-Position: refs/heads/master@{#404320}

[modify] https://crrev.com/bace6ed0fd91cd357569dc9ad1d285ff2390520e/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/bace6ed0fd91cd357569dc9ad1d285ff2390520e/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h

Comment 2 by fukino@chromium.org, Jul 11 2016

Labels: Merge-Request-53
Status: Fixed (was: Assigned)

Comment 3 by dimu@google.com, Jul 11 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 11 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3353c6c9ecee6c2ff5e5ebc91b95367c234d40a2

commit 3353c6c9ecee6c2ff5e5ebc91b95367c234d40a2
Author: Naoki Fukino <fukino@chromium.org>
Date: Mon Jul 11 08:37:38 2016

Storage manager: Add site data size on the amount of browsing data.

The size of browsing data used to contain only HTTP cache.
This CL adds the total size of site data as a part of browsing data.

BUG= 625072 
TEST=manually tested
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2123133002
Cr-Commit-Position: refs/heads/master@{#404320}
(cherry picked from commit bace6ed0fd91cd357569dc9ad1d285ff2390520e)

Review URL: https://codereview.chromium.org/2140533002 .

Cr-Commit-Position: refs/branch-heads/2785@{#75}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/3353c6c9ecee6c2ff5e5ebc91b95367c234d40a2/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/3353c6c9ecee6c2ff5e5ebc91b95367c234d40a2/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h

Comment 5 by fukino@chromium.org, Jul 14 2016

Labels: -ReleaseBlock-Stable
Status: Verified (was: Fixed)
Chrome OS 53.0.2785.55/8530.49.0 

Sign in to add a comment