New issue
Advanced search Search tips

Issue 625071 link

Starred by 2 users
Status: Verified
Owner:
fukino@chromium.org
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Storage manager: Storage usage shown on the UI should be updated periodically.

Project Member Reported by fukino@chromium.org, Jul 1 2016 
Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Click "Storage management" from chrome://settings
(2) Keep the storage manager visible and delete some files in Downloads.

What is the expected output?
The storage usage should be updated, but it isn't.

Please use labels and text to provide additional information.
We can't all the timing the storage usage changes, so we need to update the usage periodically.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0938c187331beb68a020bc36d9162c924b7e991

commit d0938c187331beb68a020bc36d9162c924b7e991
Author: fukino <fukino@chromium.org>
Date: Mon Jul 11 04:20:53 2016

Storage manager: Update storage usage periodically.

To show the up-to-date storage information, this CL modifies storage manager
to update the information every 5 seconds while the manager overlay is visible.
Also, avoiding updating storage size while computing size is ongoing.

BUG= 625071 
TEST=manually tested
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2137463002
Cr-Commit-Position: refs/heads/master@{#404596}

[modify] https://crrev.com/d0938c187331beb68a020bc36d9162c924b7e991/chrome/browser/resources/options/chromeos/storage_manager.js
[modify] https://crrev.com/d0938c187331beb68a020bc36d9162c924b7e991/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/d0938c187331beb68a020bc36d9162c924b7e991/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h

Comment 2 by fukino@chromium.org, Jul 11 2016

Labels: Merge-Request-53
Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11 2016

Labels: merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/823118c1f17a653be09c2d79a5b50964aae6f6d2

commit 823118c1f17a653be09c2d79a5b50964aae6f6d2
Author: Naoki Fukino <fukino@chromium.org>
Date: Mon Jul 11 08:42:30 2016

Storage manager: Update storage usage periodically.

To show the up-to-date storage information, this CL modifies storage manager
to update the information every 5 seconds while the manager overlay is visible.
Also, avoiding updating storage size while computing size is ongoing.

BUG= 625071 
TEST=manually tested
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2137463002
Cr-Commit-Position: refs/heads/master@{#404596}
(cherry picked from commit d0938c187331beb68a020bc36d9162c924b7e991)

Review URL: https://codereview.chromium.org/2135923002 .

Cr-Commit-Position: refs/branch-heads/2785@{#76}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/823118c1f17a653be09c2d79a5b50964aae6f6d2/chrome/browser/resources/options/chromeos/storage_manager.js
[modify] https://crrev.com/823118c1f17a653be09c2d79a5b50964aae6f6d2/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.cc
[modify] https://crrev.com/823118c1f17a653be09c2d79a5b50964aae6f6d2/chrome/browser/ui/webui/options/chromeos/storage_manager_handler.h

Comment 4 by dimu@google.com, Jul 12 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)

Comment 5 by fukino@chromium.org, Jul 12 2016

Labels: -Merge-Approved-53
The change has already been merged by commit c#3.
I'm so sorry I merged the change before approval. I thought the merge was approved yesterday, but the approval was for a different CL...

Comment 6 by fukino@chromium.org, Jul 14 2016

Labels: -ReleaseBlock-Stable

Comment 7 by rookrishna@chromium.org, Aug 12 2016

Status: Verified (was: Fixed)
Chrome OS 53.0.2785.55/8530.49.0
►

Sign in to add a comment