New issue
Advanced search Search tips

Issue 625070 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Storage manager: Show user list to remove a user.

Project Member Reported by fukino@chromium.org, Jul 1 2016

Issue description

Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Click "Storage management" from chrome://settings.
(2) Click "Other users" on the UI.

What is the expected output?
User list should be shown, but it isn't.

 

Comment 2 by fukino@chromium.org, Jul 18 2016

We should show "Users" dialog, which users were able to open from "Manager other users..." button in People section.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd79db4b1cea32d3fc151fb753e767a2c24b765f

commit fd79db4b1cea32d3fc151fb753e767a2c24b765f
Author: fukino <fukino@chromium.org>
Date: Tue Jul 19 06:21:02 2016

Storage manager: Show accounts panel from "Other users" link.

BUG= 625070 
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2162753002
Cr-Commit-Position: refs/heads/master@{#406222}

[modify] https://crrev.com/fd79db4b1cea32d3fc151fb753e767a2c24b765f/chrome/browser/resources/options/chromeos/storage_manager.html
[modify] https://crrev.com/fd79db4b1cea32d3fc151fb753e767a2c24b765f/chrome/browser/resources/options/chromeos/storage_manager.js

Comment 4 by fukino@chromium.org, Jul 20 2016

Labels: Merge-Request-53
Status: Fixed (was: Assigned)

Comment 5 by dimu@google.com, Jul 20 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 20 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/961147b7cba9901f8ffafed047a52b15ad35755f

commit 961147b7cba9901f8ffafed047a52b15ad35755f
Author: Naoki Fukino <fukino@chromium.org>
Date: Wed Jul 20 08:57:36 2016

Storage manager: Show accounts panel from "Other users" link.

BUG= 625070 
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2162753002
Cr-Commit-Position: refs/heads/master@{#406222}
(cherry picked from commit fd79db4b1cea32d3fc151fb753e767a2c24b765f)

Review URL: https://codereview.chromium.org/2168583002 .

Cr-Commit-Position: refs/branch-heads/2785@{#242}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/961147b7cba9901f8ffafed047a52b15ad35755f/chrome/browser/resources/options/chromeos/storage_manager.html
[modify] https://crrev.com/961147b7cba9901f8ffafed047a52b15ad35755f/chrome/browser/resources/options/chromeos/storage_manager.js

Status: Verified (was: Fixed)
 8530.89.0, 53.0.2785.128

Sign in to add a comment