New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 625068 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 638351



Sign in to add a comment

Spellcheck should not visit RenderViews with no local frames

Project Member Reported by yabinh@chromium.org, Jul 1 2016

Issue description

Spellcheck uses RenderViewVisitor, so it visits all RenderViews, even ones
with no local frames at all. Thus, FocusController::focusedOrMainFrame() 
sometimes returns a remote frame. This is not correct.

See the discussion in:
https://codereview.chromium.org/2012823003/#msg11
 
Cc: alex...@chromium.org
Components: Internals>Sandbox>SiteIsolation
This is a blocker for enforcing the precondition that FocusController::focusedOrMainFrame() should only return local frames.
I guess this bug will be fixed by making SpellCheckProvider into RenderFrameObserver, since a RenderFrame always has a WebLocalFrame.

Am I correct?

https://crrev.com/2799923003 will do the above change.
Cc: xiaoche...@chromium.org

Comment 4 by creis@chromium.org, Apr 10 2017

Blocking: 638351
Owner: xiaoche...@chromium.org
That sounds right to me.  Thanks!

Comment 5 by creis@chromium.org, Apr 10 2017

Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c92b1cfa21b855c0e8c19f5550ae5209a325936

commit 0c92b1cfa21b855c0e8c19f5550ae5209a325936
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Apr 12 03:06:49 2017

Change SpellCheckProvider into a RenderFrameObserver

This is Patch 6 of 6 for making SpellCheckProvider a RenderFrameObserver, so
that spellcheck can work in OOPIF. Full design: https://goo.gl/VfCENk

This patch changes SpellCheckProvider into a RenderFrameObserver, so that
spellcheck messages from OOPIFs can be successfully sent to browser, making
spell-checking work in OOPIFs.

BUG= 638361 ,710044, 625068 

Review-Url: https://codereview.chromium.org/2799923003
Cr-Commit-Position: refs/heads/master@{#463912}

[modify] https://crrev.com/0c92b1cfa21b855c0e8c19f5550ae5209a325936/android_webview/renderer/aw_content_renderer_client.cc
[modify] https://crrev.com/0c92b1cfa21b855c0e8c19f5550ae5209a325936/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/0c92b1cfa21b855c0e8c19f5550ae5209a325936/components/spellcheck/renderer/spellcheck.cc
[modify] https://crrev.com/0c92b1cfa21b855c0e8c19f5550ae5209a325936/components/spellcheck/renderer/spellcheck_provider.cc
[modify] https://crrev.com/0c92b1cfa21b855c0e8c19f5550ae5209a325936/components/spellcheck/renderer/spellcheck_provider.h

Status: Fixed (was: Started)
Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck

Sign in to add a comment