Spellcheck should not visit RenderViews with no local frames |
|||||
Issue descriptionSpellcheck uses RenderViewVisitor, so it visits all RenderViews, even ones with no local frames at all. Thus, FocusController::focusedOrMainFrame() sometimes returns a remote frame. This is not correct. See the discussion in: https://codereview.chromium.org/2012823003/#msg11
,
Apr 10 2017
I guess this bug will be fixed by making SpellCheckProvider into RenderFrameObserver, since a RenderFrame always has a WebLocalFrame. Am I correct? https://crrev.com/2799923003 will do the above change.
,
Apr 10 2017
,
Apr 10 2017
,
Apr 10 2017
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c92b1cfa21b855c0e8c19f5550ae5209a325936 commit 0c92b1cfa21b855c0e8c19f5550ae5209a325936 Author: xiaochengh <xiaochengh@chromium.org> Date: Wed Apr 12 03:06:49 2017 Change SpellCheckProvider into a RenderFrameObserver This is Patch 6 of 6 for making SpellCheckProvider a RenderFrameObserver, so that spellcheck can work in OOPIF. Full design: https://goo.gl/VfCENk This patch changes SpellCheckProvider into a RenderFrameObserver, so that spellcheck messages from OOPIFs can be successfully sent to browser, making spell-checking work in OOPIFs. BUG= 638361 ,710044, 625068 Review-Url: https://codereview.chromium.org/2799923003 Cr-Commit-Position: refs/heads/master@{#463912} [modify] https://crrev.com/0c92b1cfa21b855c0e8c19f5550ae5209a325936/android_webview/renderer/aw_content_renderer_client.cc [modify] https://crrev.com/0c92b1cfa21b855c0e8c19f5550ae5209a325936/chrome/renderer/chrome_content_renderer_client.cc [modify] https://crrev.com/0c92b1cfa21b855c0e8c19f5550ae5209a325936/components/spellcheck/renderer/spellcheck.cc [modify] https://crrev.com/0c92b1cfa21b855c0e8c19f5550ae5209a325936/components/spellcheck/renderer/spellcheck_provider.cc [modify] https://crrev.com/0c92b1cfa21b855c0e8c19f5550ae5209a325936/components/spellcheck/renderer/spellcheck_provider.h
,
Apr 13 2017
,
Apr 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dcheng@chromium.org
, Jul 1 2016Components: Internals>Sandbox>SiteIsolation